From: Florian Weimer <fweimer@redhat.com>
To: Nix <nix@esperi.org.uk>, libc-alpha@sourceware.org
Cc: Nick Alcock <nick.alcock@oracle.com>
Subject: Re: [PATCH 02/12] Do not stack-protect ifunc resolvers.
Date: Thu, 15 Dec 2016 12:18:00 -0000 [thread overview]
Message-ID: <cba5ceea-a976-d509-a0cb-79f3b2144375@redhat.com> (raw)
In-Reply-To: <20161128123228.30856-3-nix@esperi.org.uk>
On 11/28/2016 01:32 PM, Nix wrote:
> diff --git a/config.h.in b/config.h.in
> index 1b58612..b42c4d8 100644
> --- a/config.h.in
> +++ b/config.h.in
> @@ -48,6 +48,10 @@
> /* Define if compiler accepts -ftree-loop-distribute-patterns. */
> #undef HAVE_CC_INHIBIT_LOOP_TO_LIBCALL
>
> +/* Define if compiler accepts -fno-stack-protector in an
> + __attribute__((__optimize__)). */
Space after __attribute__; at least that's the current style.
> +#undef HAVE_CC_NO_STACK_PROTECTOR
> +
> /* The level of stack protection in use for glibc as a whole. */
> #undef STACK_PROTECTOR_LEVEL
I don't have STACK_PROTECTOR_LEVEL in my sources, so this patch does not
apply. Did you post the sequence in the right order?
Thanks,
Florian
next prev parent reply other threads:[~2016-12-15 12:18 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 12:33 --enable-stack-protector for glibc, v9 Nix
2016-11-28 12:33 ` [PATCH 06/12] Work even with compilers hacked to enable -fstack-protector by default Nix
2016-11-28 12:33 ` [PATCH 03/12] Mark all machinery needed in early static-link init as -fno-stack-protector Nix
2016-12-15 14:01 ` Florian Weimer
2016-12-15 14:21 ` Nick Alcock
2016-12-15 14:31 ` Florian Weimer
2016-12-15 14:44 ` Nick Alcock
2016-11-28 12:33 ` [PATCH 12/12] Enable -fstack-protector=* when requested by configure Nix
2016-11-28 12:33 ` [PATCH 04/12] Compile the entire dynamic linker with -fno-stack-protector Nix
2016-11-28 12:33 ` [PATCH 07/12] Add stack_chk_fail_local to libc.so Nix
2016-11-28 13:25 ` [PATCH 09/12] Link various tests with -fno-stack-protector Nix
2016-12-15 14:43 ` Florian Weimer
2016-12-15 14:54 ` Nix
2016-12-15 15:54 ` Florian Weimer
2016-12-15 15:56 ` Nix
2016-12-15 15:55 ` Nix
2016-11-28 13:25 ` [PATCH 08/12] De-PLTize __stack_chk_fail internal calls within libc.so Nix
2016-12-15 13:56 ` Florian Weimer
2016-12-15 14:16 ` Nix
2016-12-15 14:21 ` Florian Weimer
2016-12-15 14:29 ` Nix
2016-12-15 14:33 ` Florian Weimer
2016-12-15 14:40 ` Nix
2016-12-15 17:24 ` Nix
2016-12-15 18:22 ` Florian Weimer
2016-12-15 20:00 ` Nix
2016-12-15 20:22 ` Florian Weimer
2016-12-15 20:44 ` Florian Weimer
2016-12-15 20:49 ` Nix
2016-12-15 20:58 ` Florian Weimer
2016-12-16 11:39 ` Florian Weimer
2016-12-16 11:44 ` Nix
2016-11-28 13:25 ` [PATCH 10/12] Drop explicit stack-protection of pieces of the system Nix
2016-11-28 13:26 ` [PATCH 11/12] Do not stack-protect sigreturn stubs Nix
2016-11-28 13:26 ` [PATCH 01/12] Initialize the stack guard earlier when linking statically Nix
2016-11-28 13:26 ` [PATCH 05/12] Prevent the rtld mapfile computation from dragging in __stack_chk_fail* Nix
2016-11-28 13:26 ` [PATCH 02/12] Do not stack-protect ifunc resolvers Nix
2016-12-15 12:18 ` Florian Weimer [this message]
2016-12-15 12:34 ` Nick Alcock
2016-12-15 12:58 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cba5ceea-a976-d509-a0cb-79f3b2144375@redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=nick.alcock@oracle.com \
--cc=nix@esperi.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).