From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by sourceware.org (Postfix) with ESMTPS id 872313858C41 for ; Fri, 19 May 2023 22:50:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 872313858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-3f41dceb93bso25160125e9.1 for ; Fri, 19 May 2023 15:50:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684536654; x=1687128654; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=S8AN4Y3SLJ8FFfH3AcdVy8lNqRcKKxnRe01WCDc0FbA=; b=ry+C/GTiXTtvoo2B5G7uAPtlTCvuRVe9o3wuYt12UOv8hloCEXN8IsEQpEGP5HlG/j oWOSqwXmYMutE/GG48aZSKiP3tNXKC7IAQjLXUal29dTvhWo19g24Mq0I50G3R9lASk1 b9qdm4IknMSnXX4TrHp/Th9V59hm9jHbsejfl7MMskfeZrR3SyFoDCeXRfVY2RByAF6j mhkyY9tbW8uNhFgC+uh6J1PJnzxHJgNzuARXjW8F73TYFDosMdCFMUrfJaN7kv6tT+Jh VrxQQY6/zE4crPH/UL7WOGZDnnLpgjb9qjya9knoIjyus2p1kk0ZTMXPzC6LehqBCTQy K0ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684536654; x=1687128654; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=S8AN4Y3SLJ8FFfH3AcdVy8lNqRcKKxnRe01WCDc0FbA=; b=IIF5M5b1tSz5isN9HWwXJKJgOkUCzm9kr8UFMzeo880kN7HBtdK3691I61UPEhXRnj HQKmnSIQU40cxuigoNYJ8nNC0SKLsXZoBxUjOOCGp54VA9CMxy1SzNVXRHhufgzqb33K ZxJfIkr6A4++Zhk76ImG1dDeEKX+AgLA8DMhqbLcWyNuYHti5I48DIZgprsU13qvlEAn IF550FFP7x3oHc6mVMJDF7JSRaEq+QlGkV7TUZSu9rEXgJsODvkCduJGxY5ayI+W6eyf aL4u29b/ug/cKSJUerNkMLumheJFRi/brl2WyKTlhPYq7igicWf6ojGaVctHNNnU+H+9 Xb9g== X-Gm-Message-State: AC+VfDyOno7X0Y8Cpt2FXDvRAVuKtueBWUGElf3WVMGMK4TkKb5qP/X1 mFP5jp4m2HXawcXib8mdaw8= X-Google-Smtp-Source: ACHHUZ51BhyjvzA/MBBrK3cpsUYSESXmA+zZ9aRQ+PtvJrzM4gCKlMu23w+gq2HlxG3nNRBYlvogew== X-Received: by 2002:a1c:7504:0:b0:3f4:2148:e8c5 with SMTP id o4-20020a1c7504000000b003f42148e8c5mr2559507wmc.1.1684536654114; Fri, 19 May 2023 15:50:54 -0700 (PDT) Received: from [192.168.0.160] ([170.253.51.134]) by smtp.gmail.com with ESMTPSA id o5-20020a05600c378500b003f42314832fsm439957wmr.18.2023.05.19.15.50.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 May 2023 15:50:53 -0700 (PDT) Message-ID: Date: Sat, 20 May 2023 00:50:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US To: Adhemerval Zanella , GNU C Library From: Alejandro Colomar Subject: nonnull on epoll_wait(2) syscall wrappers? Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------yt3gvVhazqVs0w7AZzNUZbV7" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------yt3gvVhazqVs0w7AZzNUZbV7 Content-Type: multipart/mixed; boundary="------------LG2nVe1gyeDwIRo2FYzXRM9q"; protected-headers="v1" From: Alejandro Colomar To: Adhemerval Zanella , GNU C Library Message-ID: Subject: nonnull on epoll_wait(2) syscall wrappers? --------------LG2nVe1gyeDwIRo2FYzXRM9q Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Adhemerval, I was checking the epoll_pwait2(2) man page to see if it needs some updating for the wrapper you added recently. It seems all's good. However, I noticed that there's a difference between the current manual page and the glibc wrappers for the 3 related functions: $ grepc -x /sys/epoll.h$ epoll_wait /usr/include/ /usr/include/x86_64-linux-gnu/sys/epoll.h:124: extern int epoll_wait (int __epfd, struct epoll_event *__events, int __maxevents, int __timeout) __attr_access ((__write_only__, 2, 3)); $ grepc -x /sys/epoll.h$ epoll_pwait /usr/include/ /usr/include/x86_64-linux-gnu/sys/epoll.h:134: extern int epoll_pwait (int __epfd, struct epoll_event *__events, int __maxevents, int __timeout, const __sigset_t *__ss) __attr_access ((__write_only__, 2, 3)); $ grepc -x /sys/epoll.h$ epoll_pwait2 /usr/include/ /usr/include/x86_64-linux-gnu/sys/epoll.h:144: extern int epoll_pwait2 (int __epfd, struct epoll_event *__events, int __maxevents, const struct timespec *__timeout, const __sigset_t *__ss) __attr_access ((__write_only__, 2, 3)); /usr/include/x86_64-linux-gnu/sys/epoll.h:157: # define epoll_pwait2 __epoll_pwait2_time64 The man page synopsis is: SYNOPSIS #include int epoll_wait(int epfd, struct epoll_event *events, int maxevents, int timeout); int epoll_pwait(int epfd, struct epoll_event *events, int maxevents, int timeout, const sigset_t *_Nullable sigmask); int epoll_pwait2(int epfd, struct epoll_event *events, int maxevents, const struct timespec *_Nullable tim= eout, const sigset_t *_Nullable sigmask); I didn't use _Nullable in the events parameter, because I don't think it can be NULL. Does it make any sense in any case having a NULL there? Should we use nonnull in glibc? Cheers, Alex --=20 GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5 --------------LG2nVe1gyeDwIRo2FYzXRM9q-- --------------yt3gvVhazqVs0w7AZzNUZbV7 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6jqH8KTroDDkXfJAnowa+77/2zIFAmRn/UwACgkQnowa+77/ 2zLb/w//XQzooX0fobFTOmdXX/dUukKtwJhtfXu7GrGh/UlaAXbu2mTvPfcc703S LGexfv0pUADtVDHLpb66NAQgzpqOvHNQ5ncYKN0dP0V4/6p1xKA6ZVHV7avWyYYm sZpwzV5RrsswQrKWGHdrLY7CxFslWRzDt9UgIx3ZvI6XSxjnLK69QUfVVTqezJ1r P4V4UoEzhQDrK7AsxkxpH2wVnSgkEllWcXK3uMR7QLsgumpOk7A1nMCLqGuLijS7 z6IB7A6jnBBpMb0g2za1aRBXBkeWt+95bcG95/rUOrjSl3OO2bZkqS0Gsv/1Z0mW b4B2Ja1TEpI8WRPTZWJqxViF3oyz6m7hCGrPaAG3O2IgOvc83IE80NYCwSMwHFub eG5C2FruEo9HO7UQvgTqnSNnqT5SfBd7au35hBopbS1T6kVlrzTuw+ZIG0MDA+Xl ePqI4//j958ETzLwJht3yDcvghw02+V9NoxbB8yBtcYOCR9vSnq82ciJ/LEQYKhr mWT3rAQn6UX4/oQQ/6DNRVcSfS0dpT9Qr3ZcCym+JpAIcMuMcpjuog2T6JgVbNxh /5j52No4q9cuyTy9iHn0YoBhGRlgqAyu2wa7JaPBjFKBH+t7Qeob0mkTtZJcoHXB fVyqZmTqrb6TEhjEFGLMLi4zkunFPVbI4D2lBod4CY2qKEAtPk0= =k/2G -----END PGP SIGNATURE----- --------------yt3gvVhazqVs0w7AZzNUZbV7--