From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bumble.maple.relay.mailchannels.net (bumble.maple.relay.mailchannels.net [23.83.214.25]) by sourceware.org (Postfix) with ESMTPS id 06962385782C; Mon, 21 Dec 2020 05:27:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 06962385782C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id A7EBE341E19; Mon, 21 Dec 2020 05:27:06 +0000 (UTC) Received: from pdx1-sub0-mail-a2.g.dreamhost.com (100-96-9-178.trex.outbound.svc.cluster.local [100.96.9.178]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id BEE78341D56; Mon, 21 Dec 2020 05:27:05 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a2.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.11); Mon, 21 Dec 2020 05:27:06 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Company-Versed: 411b014c09b55040_1608528426433_3941180803 X-MC-Loop-Signature: 1608528426433:1463838527 X-MC-Ingress-Time: 1608528426432 Received: from pdx1-sub0-mail-a2.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a2.g.dreamhost.com (Postfix) with ESMTP id 7439182462; Sun, 20 Dec 2020 21:27:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gotplt.org; h=subject:to :cc:references:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=gotplt.org; bh=lHSLSf R9eTWMA9VVu8Z5nAAhed8=; b=MgsJZ1IK87XXwy/5JQHEDAImA1fJ83JXs8Cy9v DK8gcT6WLyB8HEsWg+Alh3k/G8jTDqweMctg/phF0+c8P6okmiPpFV61W43LSTPf uOkqljWesCFCr0vVPp6TCqeFlL4xRfz4ScyqAW3pT5NhoXUacl5JDRLg6MdCCMvp sPmyE= Received: from [192.168.1.111] (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a2.g.dreamhost.com (Postfix) with ESMTPSA id 86DC67E3A5; Sun, 20 Dec 2020 21:27:02 -0800 (PST) Subject: Re: [RFC][PATCH] * bits/confname.h: Define _CS_POSIX_V7_THREADS_CFLAGS, _CS_POSIX_V7_THREADS_LDFLAGS To: =?UTF-8?Q?=c3=89rico_Nogueira?= , libc-alpha@sourceware.org Cc: elfutils-devel@sourceware.org References: <20201026233303.16034-1-ericonr@disroot.org> X-DH-BACKEND: pdx1-sub0-mail-a2 From: Siddhesh Poyarekar Message-ID: Date: Mon, 21 Dec 2020 10:56:58 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201026233303.16034-1-ericonr@disroot.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Dec 2020 05:27:10 -0000 On 10/27/20 5:03 AM, =C3=89rico Nogueira via Libc-alpha wrote: > From: =C3=89rico Rolim >=20 > I would like to add these enums in order to conform to the POSIX > specification: https://www.man7.org/linux/man-pages/man0/unistd.h.0p.ht= ml >=20 > This change also helps musl-libc, since they want to have these defines > with the same values as glibc. >=20 > I tried to add them for the bits/confname.h and > conform/data/unistd.h-data files following the example of the other > values, but didn't know how to plug them into the confstr / __sysconf > implementations. It's been a while since I touched this code, but IIRC you need to add=20 your new variables to posix/posix-conf-vars.list. That said, could you please let me know if you have a copyright=20 assignment agreement with the FSF? I suppose this change may be OK=20 given that it is under 20 lines but one of the stewards could confirm=20 for sure. Thanks, Siddhesh > =20 > bits/confname.h | 7 ++++++- > conform/data/unistd.h-data | 2 ++ > 2 files changed, 8 insertions(+), 1 deletion(-) >=20 > diff --git a/bits/confname.h b/bits/confname.h > index 5dc8215093..fdc5403697 100644 > --- a/bits/confname.h > +++ b/bits/confname.h > @@ -670,6 +670,11 @@ enum > =20 > _CS_V6_ENV, > #define _CS_V6_ENV _CS_V6_ENV > - _CS_V7_ENV > + _CS_V7_ENV, > #define _CS_V7_ENV _CS_V7_ENV > + > + _CS_POSIX_V7_THREADS_CFLAGS, > +#define _CS_POSIX_V7_THREADS_CFLAGS _CS_POSIX_V7_THREADS_CFLAGS > + _CS_POSIX_V7_THREADS_LDFLAGS > +#define _CS_POSIX_V7_THREADS_LDFLAGS _CS_POSIX_V7_THREADS_LDFLAGS > }; > diff --git a/conform/data/unistd.h-data b/conform/data/unistd.h-data > index aa070528e8..6c4b52a733 100644 > --- a/conform/data/unistd.h-data > +++ b/conform/data/unistd.h-data > @@ -367,6 +367,8 @@ constant _CS_POSIX_V7_LP64_OFF64_LIBS > constant _CS_POSIX_V7_LPBIG_OFFBIG_CFLAGS > constant _CS_POSIX_V7_LPBIG_OFFBIG_LDFLAGS > constant _CS_POSIX_V7_LPBIG_OFFBIG_LIBS > +constant _CS_POSIX_V7_THREADS_CFLAGS > +constant _CS_POSIX_V7_THREADS_LDFLAGS > constant _CS_POSIX_V7_WIDTH_RESTRICTED_ENVS > constant _CS_V7_ENV > # endif >=20