From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 5490A3858D20 for ; Mon, 6 Nov 2023 16:54:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5490A3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5490A3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699289657; cv=none; b=sWtqlnQdJ8H0wAuKVZwUH/nbBdXh3r2jjOSaXBNW+ZvdqQBEHaVtQm1j8cFg7+5j2FBqHigfVWV7phHXqmE4aKEpiH+BaxkWBGc+3A7ClHL8MUOO3Gr6cu50GP1uQ4rboKHLt6TSAsQ7UnyM+9L6Kd/g+jq0iXyNRbe/sYJB9vk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699289657; c=relaxed/simple; bh=1bepPjaNKAT0evmiQYoVyEsPEmiSBx34GOT7l6adryw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=u4AnEmzsDFdzIcHzV6vm8F3lxD036PNeH4HbTeoUmwlUjFDTtKfKAJOz2Vjo+jMbrDyIeGzGO/UGiqEy4geONGXJoPWisZxbElqn1anvHNUCfiUB0braB/fXXawK24cqkq1hVryTaFmNf3BGiXTlNQpHfP0xN0bwM36SjykDh1Y= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699289656; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0gZIpSdtnVGgGZQPOLr6NhC2BdZq20dCrZIn+CMjx4U=; b=UlnNcwNRygDQ7305qw77SyUiRJVTVkrfMGOFcqX4T989Ud02hdMtk+D97R7/89/gHaOo3P DUikByHMuA7UaW+gJt2e8w3pyaT6a5KldPw1kdPvHGnEGMLMXPMAIt2HUXgwH/Z1+434CW XLgxt0wWtVPPn06IUtju1SnZ0TdXpN4= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-648-by23i-baOaW7d-xRVvHOUA-1; Mon, 06 Nov 2023 11:54:14 -0500 X-MC-Unique: by23i-baOaW7d-xRVvHOUA-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-66fe14725aeso58832586d6.2 for ; Mon, 06 Nov 2023 08:54:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699289654; x=1699894454; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0gZIpSdtnVGgGZQPOLr6NhC2BdZq20dCrZIn+CMjx4U=; b=DHphQofyDsjMup2Su2NmzkeIKtgxK/sajVk7nz9J8qhIjH3fQW5e+2gdOct0CBPGCX 3B3GvpTcqvzBpqQZVzuSnO5PH3aNE6eaem2DpkNr9LUNidkQi/PtvGRqOQikcLTaeQEm +nk+FrfjW+o9wQ4h9WQ86JusEPdyG/oxa5pe0iKidDJMfnRvhrg599wvozqxmzhtONzT BQzZa92OlQjx4g3YhSuIEq2gMv0AK6QW9s0X0LKWmcdk3rRToRzLaJKmQwOFYccglvXt bawveU7fhwXymNj3NUqPhoHwNxNusjo8HTVicM4d4k5FoSMAsSCbz7Pq0juA8dMGhEpy jhQA== X-Gm-Message-State: AOJu0Yyg7pkXJrRm2Kk4FY9Xdk0O6LnLnooctU7IL+8QlZqXaDkuiU/V 3cIXrddFH/SLgsLh/k5WLeKsveMUR7BbzbulXPXwj0PPAhi7sRb8gdyhdZFgL+FonUkX46/C+Z1 guF36gaSfoqGdEG5buv3A X-Received: by 2002:ad4:5c46:0:b0:670:f55e:573b with SMTP id a6-20020ad45c46000000b00670f55e573bmr36791184qva.12.1699289654041; Mon, 06 Nov 2023 08:54:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IH1OvVpU2uA9fgzQSN/+5lLGcYqoYcktkFGAaie/w0gvwOwQFbArNs8Vg0QgKn6/4+82Oa9Lg== X-Received: by 2002:ad4:5c46:0:b0:670:f55e:573b with SMTP id a6-20020ad45c46000000b00670f55e573bmr36791166qva.12.1699289653684; Mon, 06 Nov 2023 08:54:13 -0800 (PST) Received: from [192.168.0.241] ([198.48.244.52]) by smtp.gmail.com with ESMTPSA id ct9-20020a056214178900b00674bdf8bfa9sm3572145qvb.29.2023.11.06.08.54.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Nov 2023 08:54:12 -0800 (PST) Message-ID: Date: Mon, 6 Nov 2023 11:54:10 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2 6/7] alpha: Fix fesetexceptflag (BZ 30998) To: Adhemerval Zanella , libc-alpha@sourceware.org, Bruno Haible References: <20231106132713.953501-1-adhemerval.zanella@linaro.org> <20231106132713.953501-7-adhemerval.zanella@linaro.org> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <20231106132713.953501-7-adhemerval.zanella@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-14.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/6/23 08:27, Adhemerval Zanella wrote: > From: Bruno Haible > > It clears some exception flags that are outside the EXCEPTS argument. > > It fixes math/test-fexcept on qemu-user. > --- > sysdeps/alpha/fpu/fsetexcptflg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sysdeps/alpha/fpu/fsetexcptflg.c b/sysdeps/alpha/fpu/fsetexcptflg.c > index 70f3666a6e..63eb06845d 100644 > --- a/sysdeps/alpha/fpu/fsetexcptflg.c > +++ b/sysdeps/alpha/fpu/fsetexcptflg.c > @@ -27,7 +27,7 @@ __fesetexceptflag (const fexcept_t *flagp, int excepts) > tmp = __ieee_get_fp_control (); > > /* Set all the bits that were called for. */ > - tmp = (tmp & ~SWCR_STATUS_MASK) | (*flagp & excepts & SWCR_STATUS_MASK); > + tmp ^= (tmp ^ *flagp) & excepts & SWCR_STATUS_MASK; Does this actually work? Assume excepts is FE_INVALID, and *flagp bit 17 is 0. Assume currently bit 17 is 1. tmp ^ *flagp => bit 17 is still 1, even though bit 17 in flagp is 0. & excepts => bit 17 is still 1. & SWCR_STATUS_MASK => bit 17 is still 1. ^= => bit 17 is still 1. The operation will set a bit, but won't clear it? I would expect (taken from hppa code I wrote for that port): /* Clear all status bits we care about. */ tmp = tmp & ~(excepts & SWCR_STATUS_MASK); /* Install the new ones. */ tmp |= *flagp & excepts & SWCR_STATUS_MASK; > > /* And store it back. */ > __ieee_set_fp_control (tmp); -- Cheers, Carlos.