From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by sourceware.org (Postfix) with ESMTPS id 1865B3858D28 for ; Tue, 2 Apr 2024 15:06:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1865B3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=huawei.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1865B3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=45.249.212.191 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712070399; cv=none; b=mMiHiV0qgaY9Z/P4tDHXIMCso8M+DRawWyu3ugYx/P5/TRpR2QOLwOPSQhzB8qdlBZZIeNh1H8pNY01R+xbIpZz1l1OCoF+X26VrqZD1jHA19Vm23t7ncfeFHNsE3VBWuPqyLVk8T76/4ruT1CH5Lr+1r8aGsTUrvPkHiURY9gM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712070399; c=relaxed/simple; bh=kS3MLPHW16H/YXlCcYkvjYzQtgt9u2fR1dKkOlEBQwI=; h=Subject:To:From:Message-ID:Date:MIME-Version; b=PJ2GtMYo9JaXD4qyevNVwshXIEbhvdoqB7NdnKmoMDy1l61Pniy6obYuIAwa/+rPi9hSJQlHmVCHfcNBDIF/xdJXd77awH/UjYN+KatRX9iYDi8Kxtuy4/d32UsGOF0IGeSjs9DoxShqsHmHdbzObwzbq5MGZSlmTltxLY/Qldk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from mail.maildlp.com (unknown [172.19.163.17]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4V8B5v68Txz1GFBs; Tue, 2 Apr 2024 23:05:55 +0800 (CST) Received: from canpemm500010.china.huawei.com (unknown [7.192.105.118]) by mail.maildlp.com (Postfix) with ESMTPS id 73CE21A0172; Tue, 2 Apr 2024 23:06:33 +0800 (CST) Received: from [10.67.111.82] (10.67.111.82) by canpemm500010.china.huawei.com (7.192.105.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 2 Apr 2024 23:06:33 +0800 Subject: Re: [PATCH] elf: sanitize objname in _dl_signal_error To: "H.J. Lu" References: <1711806052-117857-1-git-send-email-xiaojiangfeng@huawei.com> <1711939509-1411-1-git-send-email-xiaojiangfeng@huawei.com> <3f6a6290-9136-4a72-a24b-7c6bb7965569@linaro.org> <0d0aaf71-4f20-0bc1-9ac7-f31f1b426398@huawei.com> CC: Adhemerval Zanella Netto , , , , , , From: Jiangfeng Xiao Message-ID: Date: Tue, 2 Apr 2024 23:06:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.111.82] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm500010.china.huawei.com (7.192.105.118) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024/4/2 23:00, H.J. Lu wrote: >>> >> >> Maybe. However, the glibc code may reference null pointers, >> which should be fixed. > > Not if a null pointer should never happen. > If the fatal_error(0, NULL, NULL, NULL, "invalid mode parameter") code in the _dl_signal_error function will never be executed, delete the redundant code. If it is possible, even if the possibility is very low, it should be fixed.