From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) by sourceware.org (Postfix) with ESMTPS id 529C63888C7F for ; Fri, 18 Mar 2022 16:57:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 529C63888C7F Received: by mail-oi1-x22d.google.com with SMTP id e4so6311152oif.2 for ; Fri, 18 Mar 2022 09:57:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=Wv29g57ScBuwhkQNUb2ZdP3gDz+N/IIB/JLKbyAHFls=; b=bKPtg+ZUYKqlT08tA0sNSmT73ql7OR3klz0uamb2KHgZl6aMjlLfaE7fnl2GSK6AO2 Y7GbzOZNFxOY8ydF6JD/EvRI0XBGtkK+wZCW4gujhBC19CxvjSvc3n8hvB+wGIK+Q0Sy KSz1Om0jAudp9gDukcJMoxAq5bCgtKquVvOWbscNbQiv3aaLxRTMDAE0psnFbQk35Lpy 0ZBrCRV8r/UkacDp0Ou5tAQbr8EiM8Pqihu2Kcvro+fEA/JMp63+fSA6sziY8MSoUDcz CHbD1sT4ynGqU6ufhqcVQDQ1+Al7q8NZMFVLS85v87AUkxT6zebMFZkz7gjJxqjXs+Um L49w== X-Gm-Message-State: AOAM530YjEO+XP1QTNWdKZCnwiL491ZT/l+ucXH+rAqL4YdaxcaVZKtM gp4TSzDBHqfk7FzhBAIhYVznTA== X-Google-Smtp-Source: ABdhPJz45Q0983RbpDwDYeHQYmyBeMnG13Prlxqbp/w/DeEIvaNC5TQM+RT81udtS9p3jkOMgpFWYQ== X-Received: by 2002:aca:d12:0:b0:2ee:f684:bd4b with SMTP id 18-20020aca0d12000000b002eef684bd4bmr6236983oin.128.1647622622508; Fri, 18 Mar 2022 09:57:02 -0700 (PDT) Received: from ?IPV6:2804:431:c7ca:99a3:99e2:1060:da92:ae49? ([2804:431:c7ca:99a3:99e2:1060:da92:ae49]) by smtp.gmail.com with ESMTPSA id bg14-20020a056820080e00b0031d1cf9aef6sm3900157oob.48.2022.03.18.09.57.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Mar 2022 09:57:01 -0700 (PDT) Message-ID: Date: Fri, 18 Mar 2022 13:56:58 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] scripts/dso-ordering-test.py: Fix C&P error in * callrefs processing Content-Language: en-US To: Florian Weimer , libc-alpha@sourceware.org References: <877d9377an.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella In-Reply-To: <877d9377an.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2022 16:57:04 -0000 On 09/03/2022 07:24, Florian Weimer via Libc-alpha wrote: > The elf/dso-sort-tests-src subdirectory is not changed by this commit, > so it seems that the cut-and-paste error was not material. > > This was reported by some downstream static analysis tool. LGTM, thanks. Reviewed-by: Adhemerval Zanella > > --- > scripts/dso-ordering-test.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/scripts/dso-ordering-test.py b/scripts/dso-ordering-test.py > index 0b526aff45..2dd6bfda18 100644 > --- a/scripts/dso-ordering-test.py > +++ b/scripts/dso-ordering-test.py > @@ -551,17 +551,17 @@ def process_testcase(t): > if obj in t.deps: > deps = t.deps[obj] > if '*' in deps: > - t.deps[obj].remove('*') > + deps.remove('*') > t.add_deps([obj], non_dep_tgt_objs) > if obj in t.callrefs: > deps = t.callrefs[obj] > if '*' in deps: > - t.deps[obj].remove('*') > + deps.remove('*') > t.add_callrefs([obj], non_dep_tgt_objs) > if "#" in t.deps: > deps = t.deps["#"] > if '*' in deps: > - t.deps["#"].remove('*') > + deps.remove('*') > t.add_deps(["#"], non_dep_tgt_objs) > > # If no main program was specified in dependency description, make a >