From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bat.birch.relay.mailchannels.net (bat.birch.relay.mailchannels.net [23.83.209.13]) by sourceware.org (Postfix) with ESMTPS id 2A158386F805 for ; Fri, 8 Jan 2021 13:35:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2A158386F805 X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id C254C1E18E8; Fri, 8 Jan 2021 13:35:17 +0000 (UTC) Received: from pdx1-sub0-mail-a10.g.dreamhost.com (100-105-161-17.trex.outbound.svc.cluster.local [100.105.161.17]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id E87071E08E7; Fri, 8 Jan 2021 13:35:11 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a10.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.11); Fri, 08 Jan 2021 13:35:17 +0000 X-MC-Relay: Junk X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Desert-Juvenile: 12caa53a6288ee9d_1610112912171_2712439470 X-MC-Loop-Signature: 1610112912171:1739460152 X-MC-Ingress-Time: 1610112912170 Received: from pdx1-sub0-mail-a10.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a10.g.dreamhost.com (Postfix) with ESMTP id A2BC87F012; Fri, 8 Jan 2021 05:35:11 -0800 (PST) Received: from [192.168.86.152] (unknown [103.199.172.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a10.g.dreamhost.com (Postfix) with ESMTPSA id 026207ED66; Fri, 8 Jan 2021 05:35:09 -0800 (PST) Subject: Re: [PATCH v3] addmntent: Remove unbounded alloca usage from getmntent [BZ#27083] To: Stefan Liebler , libc-alpha@sourceware.org References: <20201222115140.2055339-1-siddhesh@sourceware.org> <87ft3xubvx.fsf@oldenburg2.str.redhat.com> <3a491561-462e-9588-c86e-7460507f9dab@linux.ibm.com> X-DH-BACKEND: pdx1-sub0-mail-a10 From: Siddhesh Poyarekar Message-ID: Date: Fri, 8 Jan 2021 19:04:45 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <3a491561-462e-9588-c86e-7460507f9dab@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3483.6 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_ABUSEAT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, RCVD_IN_SBL_CSS, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jan 2021 13:35:21 -0000 On 1/8/21 5:39 PM, Stefan Liebler wrote: > starting with this patch, I've observed lots of linknamespace errors if > build with -Os: > FAIL: conform/POSIX/semaphore.h/linknamespace > FAIL: conform/POSIX/sys/mman.h/linknamespace > FAIL: conform/POSIX/unistd.h/linknamespace > FAIL: conform/POSIX2008/semaphore.h/linknamespace > FAIL: conform/POSIX2008/sys/mman.h/linknamespace > FAIL: conform/POSIX2008/unistd.h/linknamespace > FAIL: conform/UNIX98/semaphore.h/linknamespace > FAIL: conform/UNIX98/sys/mman.h/linknamespace > FAIL: conform/UNIX98/unistd.h/linknamespace > FAIL: conform/XOPEN2K/semaphore.h/linknamespace > FAIL: conform/XOPEN2K/sys/mman.h/linknamespace > FAIL: conform/XOPEN2K/unistd.h/linknamespace > FAIL: conform/XOPEN2K8/semaphore.h/linknamespace > FAIL: conform/XOPEN2K8/sys/mman.h/linknamespace > FAIL: conform/XOPEN2K8/unistd.h/linknamespace > FAIL: conform/XPG4/unistd.h/linknamespace > FAIL: conform/XPG42/unistd.h/linknamespace > > E.g.: > conform/POSIX/semaphore.h/linknamespace.out > [initial] sem_open -> [libpthread.a(sem_open.o)] __shm_directory -> > [libpthread.a(shm-directory.o)] __endmntent -> [libc.a(mntent_r.o)] > fputc_unlocked > > Can you please have a look? Hmm, I guess fputc_unlocked doesn't get inlined with -Os. I'll take a look. Siddhesh