* [PATCH] Extended Char Intro: Use getwc in example (Bug 25626)
@ 2020-03-05 2:26 Carlos O'Donell
2020-03-05 6:32 ` Florian Weimer
0 siblings, 1 reply; 3+ messages in thread
From: Carlos O'Donell @ 2020-03-05 2:26 UTC (permalink / raw)
To: libc-alpha
Tested by building the pdf with make pdf and reading the
section to ensure it makes sense.
OK for master?
8< --- 8< --- 8<
In the "Extended Char Intro" the example incorrectly uses a function
called wgetc which doesn't exist. The example is corrected to use
getwc, which is correct for the use in this case.
Reported-by: Toomas Rosin <toomas@rosin.ee>
---
manual/charset.texi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/manual/charset.texi b/manual/charset.texi
index f6a980f6cb..9fd0166115 100644
--- a/manual/charset.texi
+++ b/manual/charset.texi
@@ -186,7 +186,7 @@ are used:
@{
wint_t c;
@dots{}
- while ((c = wgetc (fp)) != WEOF)
+ while ((c = getwc (fp)) != WEOF)
@dots{}
@}
@end smallexample
--
2.21.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Extended Char Intro: Use getwc in example (Bug 25626)
2020-03-05 2:26 [PATCH] Extended Char Intro: Use getwc in example (Bug 25626) Carlos O'Donell
@ 2020-03-05 6:32 ` Florian Weimer
2020-03-21 2:47 ` Carlos O'Donell
0 siblings, 1 reply; 3+ messages in thread
From: Florian Weimer @ 2020-03-05 6:32 UTC (permalink / raw)
To: Carlos O'Donell; +Cc: libc-alpha
* Carlos O'Donell:
> diff --git a/manual/charset.texi b/manual/charset.texi
> index f6a980f6cb..9fd0166115 100644
> --- a/manual/charset.texi
> +++ b/manual/charset.texi
> @@ -186,7 +186,7 @@ are used:
> @{
> wint_t c;
> @dots{}
> - while ((c = wgetc (fp)) != WEOF)
> + while ((c = getwc (fp)) != WEOF)
> @dots{}
> @}
> @end smallexample
Okay.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Extended Char Intro: Use getwc in example (Bug 25626)
2020-03-05 6:32 ` Florian Weimer
@ 2020-03-21 2:47 ` Carlos O'Donell
0 siblings, 0 replies; 3+ messages in thread
From: Carlos O'Donell @ 2020-03-21 2:47 UTC (permalink / raw)
To: Florian Weimer; +Cc: libc-alpha
On 3/5/20 1:30 AM, Florian Weimer wrote:
> * Carlos O'Donell:
>
>> diff --git a/manual/charset.texi b/manual/charset.texi
>> index f6a980f6cb..9fd0166115 100644
>> --- a/manual/charset.texi
>> +++ b/manual/charset.texi
>> @@ -186,7 +186,7 @@ are used:
>> @{
>> wint_t c;
>> @dots{}
>> - while ((c = wgetc (fp)) != WEOF)
>> + while ((c = getwc (fp)) != WEOF)
>> @dots{}
>> @}
>> @end smallexample
>
> Okay.
>
Pushed.
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-21 2:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-05 2:26 [PATCH] Extended Char Intro: Use getwc in example (Bug 25626) Carlos O'Donell
2020-03-05 6:32 ` Florian Weimer
2020-03-21 2:47 ` Carlos O'Donell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).