From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf33.google.com (mail-qv1-xf33.google.com [IPv6:2607:f8b0:4864:20::f33]) by sourceware.org (Postfix) with ESMTPS id D03443858025 for ; Fri, 5 Mar 2021 14:17:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D03443858025 Received: by mail-qv1-xf33.google.com with SMTP id cw15so1006058qvb.11 for ; Fri, 05 Mar 2021 06:17:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Z9Ub1lajq74ZrO3cmdTYWVnUl8+2n4INX54FQoW+n+g=; b=KkWX8Ad4hib8VgHpgRarm0+2iRYlwxNEqUrNB2ha326PCw+hdZW7mami7/g63Yngrw ROBsh1hyf5XZyg+8NhBiOgp9k8XyNoBz+bfNvHnUSBVKqtH5XHtWXJ/SrROliKo9iTdg cI8OXcmLtCruoEKOjzmG1z69ev28GZWh6GfesmYGyRDDnWsHWrJ4TWFyjXXWNiR24wsL REvXIkHvFE20p2TZSDaO6EXThP8QpjgX05gEPHQ8qBhseWwL8pH54qQ7UbXMLSFPHIX0 npmDl2bZH5B9LxNgFdXYXbiox6XNHvQmnDeUM2VMKM6uqVceyhjHG9H1Urh9qBH3y5R1 +hYQ== X-Gm-Message-State: AOAM533mdeH/mAaJXCWBEetfxgi/hLhHVxhEo5qc4GvfOJhRj3sAQAn4 Qzw6AzmxtMQZcON1IPWo/LbwGY88IQznAw== X-Google-Smtp-Source: ABdhPJwBoRrdAhngl3wVDriZCa4srDttgDIflJ163snoj6jCDehw7QWKpOWMwxgi1L8GVlabl1zQJg== X-Received: by 2002:a0c:b66c:: with SMTP id q44mr9288446qvf.3.1614953861240; Fri, 05 Mar 2021 06:17:41 -0800 (PST) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id u35sm1995870qtb.18.2021.03.05.06.17.40 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Mar 2021 06:17:40 -0800 (PST) Subject: Re: [PATCH] posix: tst-spawn4-compat can be a regular test To: libc-alpha@sourceware.org References: <878s71g3mt.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Message-ID: Date: Fri, 5 Mar 2021 11:17:38 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <878s71g3mt.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Mar 2021 14:17:43 -0000 On 05/03/2021 09:56, Florian Weimer via Libc-alpha wrote: > compat_symbol_reference now works for non-internal tests, too. > Also stop building and running the tests on those architectures > that lack the test symbol versions. LGTM, thanks. Reviewed-by: Adhemerval Zanella > > --- > posix/Makefile | 9 +++++++-- > posix/tst-spawn4-compat.c | 8 -------- > 2 files changed, 7 insertions(+), 10 deletions(-) > > diff --git a/posix/Makefile b/posix/Makefile > index 2ee5bb6e1d..305ec757cd 100644 > --- a/posix/Makefile > +++ b/posix/Makefile > @@ -110,9 +110,14 @@ ifeq ($(have-GLIBC_2.26)$(build-shared),yesyes) > tests += tst-glob_lstat_compat > endif > > +# Test for the posix_spawn, posix_spawnp symbol versions replaced in > +# glibc 2.15. > +ifeq ($(have-GLIBC_2.14)$(build-shared),yesyes) > +tests += tst-spawn4-compat > +endif > + > tests-internal := bug-regex5 bug-regex20 bug-regex33 \ > - tst-rfc3484 tst-rfc3484-2 tst-rfc3484-3 \ > - tst-spawn4-compat > + tst-rfc3484 tst-rfc3484-2 tst-rfc3484-3 > tests-container := bug-ga2 > xtests := tst-getaddrinfo4 tst-getaddrinfo5 tst-sched_rr_get_interval > ifeq (yes,$(build-shared)) Ok. > diff --git a/posix/tst-spawn4-compat.c b/posix/tst-spawn4-compat.c > index 77f6ed6c22..30ba0677ba 100644 > --- a/posix/tst-spawn4-compat.c > +++ b/posix/tst-spawn4-compat.c > @@ -27,7 +27,6 @@ > #include > > #include > -#if TEST_COMPAT (libc, GLIBC_2_0, GLIBC_2_15) > > compat_symbol_reference (libc, posix_spawn, posix_spawn, GLIBC_2_2); > compat_symbol_reference (libc, posix_spawnp, posix_spawnp, GLIBC_2_2); > @@ -66,12 +65,5 @@ do_test (void) > > return 0; > } > -#else > -static int > -do_test (void) > -{ > - return 77; > -} > -#endif > > #include > Ok.