From: Carlos O'Donell <carlos@redhat.com>
To: DJ Delorie <dj@redhat.com>, Joseph Myers <joseph@codesourcery.com>
Cc: fweimer@redhat.com, libc-alpha@sourceware.org
Subject: Re: RFC V5 test-in-container
Date: Fri, 06 Jul 2018 12:36:00 -0000 [thread overview]
Message-ID: <ce2775cb-c70b-9298-e22b-7e1918794bf9@redhat.com> (raw)
In-Reply-To: <xnefghey94.fsf@greed.delorie.com>
On 07/06/2018 01:20 AM, DJ Delorie wrote:
>
> Joseph Myers <joseph@codesourcery.com> writes:
>>> I can write a /bin/sh substitute
>>
>> I think that's the right thing to do.
>
> I tested by running all of posix/ and libio/ tests inside the container,
> decided to also add /bin/echo and /bin/true since they were (1) used,
> and (2) trivial. Let the slippery slope begin :-)
>
> Changes since V4:
>
> add shell-container, echo-container, true-container helper programs
>
> add $($*-ENV) to test-container rules
I don't think this is an "RFC" anymore :-)
I think we should consider this a full [PATCH].
You've done way more work than anyone ever does in an RFC!
Thank you for this.
--
Cheers,
Carlos.
next prev parent reply other threads:[~2018-07-06 12:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 23:05 RFC V3 [1/2] test-in-container DJ Delorie
2018-06-25 15:01 ` Florian Weimer
2018-06-25 21:49 ` DJ Delorie
2018-06-26 11:43 ` Florian Weimer
2018-06-29 1:57 ` RFC V4 test-in-container DJ Delorie
2018-06-29 16:05 ` Joseph Myers
2018-06-29 16:16 ` DJ Delorie
2018-06-29 17:43 ` Joseph Myers
2018-07-06 5:20 ` RFC V5 test-in-container DJ Delorie
2018-07-06 12:36 ` Carlos O'Donell [this message]
2018-06-25 15:17 ` RFC V3 [1/2] test-in-container Florian Weimer
2018-06-25 22:58 ` DJ Delorie
2018-06-25 23:09 ` Florian Weimer
2018-06-26 1:57 ` DJ Delorie
2018-06-26 12:28 ` Florian Weimer
2018-06-26 12:56 ` Florian Weimer
2018-06-26 12:57 ` Florian Weimer
2018-06-28 20:35 ` DJ Delorie
2018-06-26 13:00 ` Florian Weimer
2018-06-26 13:04 ` Florian Weimer
2018-06-28 21:07 ` DJ Delorie
2018-06-29 5:01 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce2775cb-c70b-9298-e22b-7e1918794bf9@redhat.com \
--to=carlos@redhat.com \
--cc=dj@redhat.com \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).