From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id D52073858410 for ; Tue, 18 Apr 2023 22:13:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D52073858410 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0353726.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33ILWLb5029960 for ; Tue, 18 Apr 2023 22:13:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=k/uzVEtolZYJweHG09VZ+c3vRb9LKgK8och3byZQJYQ=; b=jGUkNhKYitGj2A06UqtPFOmvag/4gb/b1nm1CmEYbssJ3rugYi46bebqzjMrvTRFB+4C x9lkTN1a4M8GkGrTez6qc6lk6+byBjcbo4FiPJoghappM9LwSZQyiaORChcBXrcJSd3V PsGcthXatJ57LNesxHHZx29zVDHiQvc4Sznkqqfi4VSfBAM3K5Ri+jQ4F9y3wnsyFvEE gQFQZbvahDScjbsZPIjLogSmR3gxNnJjT2mQDTFZ3vlpqiJgmqvZ2bQtdYcrz4DNUYXx PVG5Jg/pIP1lwSTztomFnO/D3Eqlf7o23gojFkW/pHWV12Jjvz0e9UBk76tnWwxr7T4Y 9w== Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3q1pkwsx7u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 18 Apr 2023 22:13:21 +0000 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 33ILnXOe003689 for ; Tue, 18 Apr 2023 22:13:20 GMT Received: from smtprelay05.wdc07v.mail.ibm.com ([9.208.129.117]) by ppma01dal.us.ibm.com (PPS) with ESMTPS id 3pykj7yygg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 18 Apr 2023 22:13:20 +0000 Received: from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com [10.241.53.102]) by smtprelay05.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 33IMDIuv20841154 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 18 Apr 2023 22:13:18 GMT Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 62F2E5803F; Tue, 18 Apr 2023 22:13:18 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4AD3958060; Tue, 18 Apr 2023 22:13:18 +0000 (GMT) Received: from [9.163.39.30] (unknown [9.163.39.30]) by smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTP; Tue, 18 Apr 2023 22:13:18 +0000 (GMT) Message-ID: Date: Tue, 18 Apr 2023 17:13:18 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v6] Added Redirects to longdouble error functions [BZ #29033] Content-Language: en-US To: Sachin Monga , libc-alpha@sourceware.org References: <20230417110457.2894647-1-smonga@linux.ibm.com> <20230417110457.2894647-2-smonga@linux.ibm.com> From: Paul E Murphy In-Reply-To: <20230417110457.2894647-2-smonga@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: pmnQd0QZJ5WDAFiQYOwedri8gwXjd_uX X-Proofpoint-ORIG-GUID: pmnQd0QZJ5WDAFiQYOwedri8gwXjd_uX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-18_15,2023-04-18_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 priorityscore=1501 mlxlogscore=999 bulkscore=0 mlxscore=0 spamscore=0 impostorscore=0 malwarescore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304180184 X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/17/23 6:04 AM, Sachin Monga via Libc-alpha wrote: > This patch redirects the error functions to the appropriate > longdouble variants which enables the compiler to optimize > for the abi ieeelongdouble. > > Signed-off-by: Sachin Monga > diff --git a/misc/tst-ldbl-errorfptr.c b/misc/tst-ldbl-errorfptr.c > new file mode 100644 > index 0000000000..e11575b6a5 > --- /dev/null > +++ b/misc/tst-ldbl-errorfptr.c ... > +#define NLDBL_SYMBOL2(alias) __ASMNAME (#alias) > +#define NLDBL_SYMBOL(alias) NLDBL_SYMBOL2 (__nldbl_##alias) > +#define IEEE_LONG_DOUBLE(alias) __ASMNAME ("__" #alias "ieee128") > +#define NO_LONG_DOUBLE(alias) NLDBL_SYMBOL (alias) > +#define DEFAULT_SYMBOL(alias) NLDBL_SYMBOL2 (alias) I think the above can be further simplified (see comment below). > +#if __LDOUBLE_REDIRECTS_TO_FLOAT128_ABI == 1 > + error_sym = (char *) IEEE_LONG_DOUBLE(error); > + error_sym_at_line = (char *) IEEE_LONG_DOUBLE(error_at_line); > +#elif defined __LONG_DOUBLE_MATH_OPTIONAL && defined __NO_LONG_DOUBLE_MATH > + error_sym = (char *) NO_LONG_DOUBLE(error); > + error_sym_at_line = (char *) NO_LONG_DOUBLE(error_at_line); > +#else > + error_sym = (char *) DEFAULT_SYMBOL(error); > + error_sym_at_line = (char *) DEFAULT_SYMBOL(error_at_line); > +#endif Can the if/elif/else be consolidated into one? I think a more simple macro can be used to configure the expected names of the potentially redirected function. e.x #if redirect_to_f128 # define LDBL_NAME(x) "__" #x "ieee128" #else redirect_to_double # define LDBL_NAME(x) "__nldbl_" #x #else # define LDBL_NAME(x) #x #endif Otherwise, this LGTM.