From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.cs.ucla.edu (mail.cs.ucla.edu [131.179.128.66]) by sourceware.org (Postfix) with ESMTPS id F3DA33858D37 for ; Thu, 31 Aug 2023 20:21:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F3DA33858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=cs.ucla.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cs.ucla.edu Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 71D593C011BD6; Thu, 31 Aug 2023 13:21:31 -0700 (PDT) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id M6Ku0PT0u5AR; Thu, 31 Aug 2023 13:21:31 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 362683C011BD7; Thu, 31 Aug 2023 13:21:31 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 362683C011BD7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1693513291; bh=sOtYgJ9KGpmMeZSKDv/gJIJ3LEOF2KO+mc1NDHPDo7g=; h=Message-ID:Date:MIME-Version:To:From; b=IAA8tIFfDXJ6d5HIUGqhceX3PlzB1eBucG4M1nn2/VYNTTPLkbXmj8GdjYTnQsIRP /l3Wq6B9ylHEI1/RuKqGT9VxPcT/UNhtANGj7LAO7L3G/b7wDz7b26xd94OX54QnOC O6LbU4x+Ns0aWg+OWBxj8pBOflI/jlIkHqMEbnH14vkIhC+3AR0wEsDGk9h5pjUfxj oV8LPMvRkwdQi50aj4z7KmqmqU6Qt80Dv4JncQxvse89ET3GOQymvtj9y2b53GvRmO jUQVHj+izn/AsGmANG0iqMOCDJQ5lvMD7cDj1kTCkP3m8lVlBWJzgoNddSeYxhx82F gFzZgd9R2Ec8A== X-Virus-Scanned: amavisd-new at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ElmWn-eT0mJ5; Thu, 31 Aug 2023 13:21:31 -0700 (PDT) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id 118103C011BD5; Thu, 31 Aug 2023 13:21:31 -0700 (PDT) Message-ID: Date: Thu, 31 Aug 2023 13:21:30 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: Adhemerval Zanella , libc-alpha@sourceware.org References: <20230810135411.1000205-1-adhemerval.zanella@linaro.org> From: Paul Eggert Organization: UCLA Computer Science Department Subject: Re: [PATCH v2] linux: Make fdopendir fail with O_PATH (BZ 30373) In-Reply-To: <20230810135411.1000205-1-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-08-10 06:54, Adhemerval Zanella via Libc-alpha wrote: > + /* Fail early for descriptors opened with O_PATH. */ > + if (__glibc_unlikely ((flags & O_PATH) == O_PATH)) > + { > + __set_errno (EBADF); > + return NULL; > + } Shouldn't this be (flags & O_PATH), not ((flags & O_PATH) == O_PATH)? The latter suggests more complexity than there really is.