From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zimbra.cs.ucla.edu (zimbra.cs.ucla.edu [131.179.128.68]) by sourceware.org (Postfix) with ESMTPS id 83F4B385782D for ; Wed, 20 Jan 2021 17:46:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 83F4B385782D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=cs.ucla.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eggert@cs.ucla.edu Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 0DC211600E2; Wed, 20 Jan 2021 09:46:05 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id dvS2nIY8qKgq; Wed, 20 Jan 2021 09:46:04 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 479ED160108; Wed, 20 Jan 2021 09:46:04 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id XprZQ1hqg-Gw; Wed, 20 Jan 2021 09:46:04 -0800 (PST) Received: from [192.168.1.9] (cpe-23-243-218-95.socal.res.rr.com [23.243.218.95]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 169F71600E2; Wed, 20 Jan 2021 09:46:04 -0800 (PST) Subject: Re: [PATCH 1/5] posix: Sync regex code with gnulib To: Adhemerval Zanella Cc: Vaseeharan Vinayagamoorthy , "libc-alpha@sourceware.org" , bug-gnulib@gnu.org References: <20201230201507.2755086-1-adhemerval.zanella@linaro.org> <909632B5-141E-4567-8E62-3DAF91CB8E33@arm.com> <74ac97a1-2186-1937-4595-ab7409d663d0@linaro.org> <2108975.lN1YhbmyTB@omega> <05f5e913-f1d1-b2f9-beb7-f226588733c0@cs.ucla.edu> <10cb3123-40a4-931f-c658-99382367db6b@linaro.org> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: Date: Wed, 20 Jan 2021 09:46:03 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <10cb3123-40a4-931f-c658-99382367db6b@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jan 2021 17:46:08 -0000 On 1/20/21 3:27 AM, Adhemerval Zanella wrote: >> #if defined __STDC_VERSION__ && 201710L < __STDC_VERSION__ >> # define __attribute_fallthrough__ [[__fallthrough__]] >> #elif __GNUC_PREREQ (7, 0) || __glibc_has_attribute (__fallthrough__) >> # define __attribute_fallthrough__ __attribute__ ((__fallthrough__)) >> #else >> # define __attribute_fallthrough__ ((void) 0) >> #endif > Yes, for 2.34 I will send some patches to sync the remaining gnulib > files and document from our part the shared files. On thinking about it more (for 2.34), I find that I would prefer the current Gnulib practice of using 'FALLTHROUGH;' to using '__attribute_fallthrough__;' in code, and so suggest Gnulib's approach of having an attribute.h file (purely for internal glibc use) that has "#define FALLTHROUGH __attribute__ (__fallthrough__)' etc.