Re: [PATCH v3 04/18] Add string vectorized find and detection functions

[Adhemerval Zanella <adhemerval.zanella@linaro.org>]

On 11/01/2018 11:44, Luis Machado wrote:
> Some quick typos i noticed while skimming through it.
> 
> On 01/10/2018 10:47 AM, Adhemerval Zanella wrote:
>> +/* If compiler supports __builtin_ctz{l} without any external depedencies
> 
> typo... dependencies
> 
> More cases of this.
> 
>> diff --git a/sysdeps/generic/string-extbyte.h b/sysdeps/generic/string-extbyte.h
>> new file mode 100644
>> index 0000000..69a78ce
>> --- /dev/null
>> +++ b/sysdeps/generic/string-extbyte.h
>> @@ -0,0 +1,35 @@
>> +/* Extract by from memory word.  Generic C version.
> 
> Extract byte?
> 
>> diff --git a/sysdeps/generic/string-fzi.h b/sysdeps/generic/string-fzi.h
>> new file mode 100644
>> index 0000000..57101f2
>> --- /dev/null
>> +++ b/sysdeps/generic/string-fzi.h
>> @@ -0,0 +1,215 @@
>> +/* Zero byte detection; indexes.  Generic C version.
>> +   Copyright (C) 2018 Free Software Foundation, Inc.
>> +   This file is part of the GNU C Library.
>> +
>> +   The GNU C Library is free software; you can redistribute it and/or
>> +   modify it under the terms of the GNU Lesser General Public
>> +   License as published by the Free Software Foundation; either
>> +   version 2.1 of the License, or (at your option) any later version.
>> +
>> +   The GNU C Library is distributed in the hope that it will be useful,
>> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
>> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>> +   Lesser General Public License for more details.
>> +
>> +   You should have received a copy of the GNU Lesser General Public
>> +   License along with the GNU C Library; if not, see
>> +   <http://www.gnu.org/licenses/>.  */
>> +
>> +#ifndef STRING_FZI_H
>> +#define STRING_FZI_H 1
>> +
>> +#include <limits.h>
>> +#include <endian.h>
>> +#include <string-fza.h>
>> +
>> +/* An improved bitscan routine, multiplying the De Bruijn sequence with a
>> +   0-1 mask separated by the least significant one bit of a scanned integer
>> +   or bitboard [1].
>> +
>> +   [1] https://chessprogramming.wikispaces.com/Kim+Walisch  */
>> +
>> +static inline unsigned
>> +index_access (const op_t i)
>> +{
>> +  static const char index[] =
>> +  {
>> +# if __WORDSIZE == 64
>> +     0, 47,  1, 56, 48, 27,  2, 60,
>> +    57, 49, 41, 37, 28, 16,  3, 61,
>> +    54, 58, 35, 52, 50, 42, 21, 44,
>> +    38, 32, 29, 23, 17, 11,  4, 62,
>> +    46, 55, 26, 59, 40, 36, 15, 53,
>> +    34, 51, 20, 43, 31, 22, 10, 45,
>> +    25, 39, 14, 33, 19, 30,  9, 24,
>> +    13, 18,  8, 12,  7,  6,  5, 63
>> +# else
>> +     0,  9,  1, 10, 13, 21,  2, 29,
>> +    11, 14, 16, 18, 22, 25,  3, 30,
>> +     8, 12, 20, 28, 15, 17, 24,  7,
>> +    19, 27, 23,  6, 26,  5,  4, 31
>> +# endif
>> +  };
>> +  return index[i];
>> +}
>> +
>> +/* For architecture which only provides __builtin_clz{l} (HAVE_BUILTIN_CLZ)
> 
> For architectures?

Thanks, I fixed all locally.