From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Joseph Myers <joseph@codesourcery.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v4 2/4] Add C11 threads support
Date: Wed, 10 May 2017 20:25:00 -0000 [thread overview]
Message-ID: <cf3451de-f467-fc2a-43a8-3bf8889bf31a@linaro.org> (raw)
In-Reply-To: <alpine.DEB.2.20.1705102021120.8589@digraph.polyomino.org.uk>
On 10/05/2017 17:22, Joseph Myers wrote:
> On Wed, 10 May 2017, Adhemerval Zanella wrote:
>
>> diff --git a/conform/Makefile b/conform/Makefile
>> index 63556b5..a79415f 100644
>> --- a/conform/Makefile
>> +++ b/conform/Makefile
>> @@ -34,9 +34,9 @@ conformtest-headers-ISO := assert.h ctype.h errno.h float.h limits.h locale.h \
>> conformtest-headers-ISO99 := $(conformtest-headers-ISO) complex.h fenv.h \
>> inttypes.h iso646.h stdbool.h stdint.h tgmath.h \
>> wchar.h wctype.h
>> -# Missing ISO11 expectations for: stdatomic.h threads.h.
>> +# Missing ISO11 expectations for: stdatomic.h
>> conformtest-headers-ISO11 := $(conformtest-headers-ISO99) stdalign.h \
>> - stdnoreturn.h uchar.h
>> + stdnoreturn.h uchar.h threads.h
>
> These header lists are meant to be alphabetical, so threads.h before
> uchar.h.
Ack.
>
>> +macro TSS_DTOR_ITERATIONS
>
> Use macro-int-constant, since C11 says this is an integer constant
> expression.
>
Ack, I will change them locally.
next prev parent reply other threads:[~2017-05-10 20:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 18:41 [PATCH v4 0/4] Add support for ISO C11 threads.h Adhemerval Zanella
2017-05-10 18:41 ` [PATCH v4 1/4] Clean pthread functions namespaces for C11 threads Adhemerval Zanella
2017-05-10 18:41 ` [PATCH v4 3/4] Add test cases for ISO " Adhemerval Zanella
2017-05-10 18:41 ` [PATCH v4 2/4] Add C11 threads support Adhemerval Zanella
2017-05-10 20:22 ` Joseph Myers
2017-05-10 20:25 ` Adhemerval Zanella [this message]
2017-05-10 18:41 ` [PATCH v4 4/4] Add manual documentation for threads.h Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf3451de-f467-fc2a-43a8-3bf8889bf31a@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).