From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from black.elm.relay.mailchannels.net (black.elm.relay.mailchannels.net [23.83.212.19]) by sourceware.org (Postfix) with ESMTPS id 56BED3857817 for ; Wed, 10 Mar 2021 09:57:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 56BED3857817 X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id DAC2E701853; Wed, 10 Mar 2021 09:57:16 +0000 (UTC) Received: from pdx1-sub0-mail-a30.g.dreamhost.com (100-96-13-44.trex.outbound.svc.cluster.local [100.96.13.44]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 7BB92702829; Wed, 10 Mar 2021 09:57:16 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a30.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.96.13.44 (trex/6.0.2); Wed, 10 Mar 2021 09:57:16 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Thoughtful-Abiding: 0dab001528d08933_1615370236741_933956620 X-MC-Loop-Signature: 1615370236741:3025692302 X-MC-Ingress-Time: 1615370236741 Received: from pdx1-sub0-mail-a30.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a30.g.dreamhost.com (Postfix) with ESMTP id 3C98D7E6B7; Wed, 10 Mar 2021 01:57:16 -0800 (PST) Received: from [192.168.1.111] (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a30.g.dreamhost.com (Postfix) with ESMTPSA id 1431F7E6BA; Wed, 10 Mar 2021 01:57:14 -0800 (PST) Subject: Re: [PATCH 2/3] Disable stack protector for ifunc resolvers in tests To: Florian Weimer Cc: Siddhesh Poyarekar via Libc-alpha References: <20210309181259.2603144-1-siddhesh@sourceware.org> <20210309181259.2603144-3-siddhesh@sourceware.org> <875z1zwia5.fsf@oldenburg.str.redhat.com> <0276568c-7d8c-6f51-759a-2240596653f4@sourceware.org> <87blbruz2t.fsf@oldenburg.str.redhat.com> X-DH-BACKEND: pdx1-sub0-mail-a30 From: Siddhesh Poyarekar Message-ID: Date: Wed, 10 Mar 2021 15:27:10 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <87blbruz2t.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3487.0 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Mar 2021 09:57:19 -0000 On 3/10/21 3:09 PM, Florian Weimer via Libc-alpha wrote: > * Siddhesh Poyarekar: > >> On 3/10/21 1:29 PM, Florian Weimer via Libc-alpha wrote: >>> * Siddhesh Poyarekar via Libc-alpha: >>> >>>> IFUNC resolvers get called too early for stack protector to be useful, >>>> so fix the elf tests to disable stack protector for the resolver >>>> functions. This fixes test failures in the static tests on x86_64. >>> With -fstack-protector-all, presumably. Does this need a bug in >>> Bugzilla? >> >> I started to file it and found there already was a report[1] and a >> patch that fixes it. I'll remove the overlapping hunk from my patch >> and credit David with it and close that bug once this goes in. > > Okay, please mention the bug number in the commit message then. > (I assume there's a bug for it, [1] is dangling.) Hah, I was just seeing if you were paying attention ;) Siddhesh [1] https://sourceware.org/bugzilla/show_bug.cgi?id=25680