From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x932.google.com (mail-ua1-x932.google.com [IPv6:2607:f8b0:4864:20::932]) by sourceware.org (Postfix) with ESMTPS id 54CAF3857C5D for ; Mon, 15 Nov 2021 17:04:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 54CAF3857C5D Received: by mail-ua1-x932.google.com with SMTP id t13so36319485uad.9 for ; Mon, 15 Nov 2021 09:04:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=hzfepIZKkbZTfPclcgqypqaxlL+PIg+Sj+f9cTrtBdc=; b=WVy9IMFh6LIoM9kw90IPX6gRQp/QkBCdw+GuxRX++/RRAui4ZZ4leFlCc4CNSHAdD5 z8cQaBDipiO3H85sAIKbkMllMEwqCcvthFbtFbnwDk1Uh8LvhGp7UEeg4aCPGoCvg8NJ m5aWnYrp3uzeLMM3PCNEVqsQW0ez08q0u5Y6R//aROcw9NRgpfqsW1aKZuLW+vIJM1Zc QczhWN9SuEIPBwSngQA0CsyFrtssiad7zncnVZNX4DECvzSJqS8NjGRycquEbO9KHOfI YuYqtTQW2ySjDhVVZ+86nU8DMffR4iCR2rkO8r2AwbvZywNIFbVCUFmmHN9qBVSzVGug alRw== X-Gm-Message-State: AOAM532tUX/XiLBgra6qvuZnJkOVxeV9SxEYwLuCeaHNiUx2y9lRJYYX gTPXJ9EFpKHcwoVDzB2WH0lgalocNQ2kHw== X-Google-Smtp-Source: ABdhPJxZkHx3OEl3/oKKBo/zp/tLYdI3QMmaczNFhNjiLXq+enLiBuZX5Ufqp99/0AgJ2bPd7wujcw== X-Received: by 2002:a05:6102:3754:: with SMTP id u20mr43915755vst.60.1636995854930; Mon, 15 Nov 2021 09:04:14 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:66dc:13f5:e2fb:5a0d:90? ([2804:431:c7ca:66dc:13f5:e2fb:5a0d:90]) by smtp.gmail.com with ESMTPSA id 64sm9804128vsz.15.2021.11.15.09.04.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Nov 2021 09:04:14 -0800 (PST) Message-ID: Date: Mon, 15 Nov 2021 14:04:12 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [RFC v5 22/22] elf: Add SVE support for aarch64 rtld-audit Content-Language: en-US To: Florian Weimer Cc: libc-alpha@sourceware.org, John Mellor-Crummey , Ben Woodard References: <20211109183347.2943786-1-adhemerval.zanella@linaro.org> <20211109183347.2943786-23-adhemerval.zanella@linaro.org> <87ilx05d94.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella In-Reply-To: <87ilx05d94.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-13.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Nov 2021 17:04:17 -0000 On 10/11/2021 10:52, Florian Weimer wrote: > * Adhemerval Zanella: > >> diff --git a/sysdeps/aarch64/dl-trampoline.S b/sysdeps/aarch64/dl-trampoline.S >> index 0d540651d4..6025de64ee 100644 >> --- a/sysdeps/aarch64/dl-trampoline.S >> +++ b/sysdeps/aarch64/dl-trampoline.S >> @@ -205,6 +205,9 @@ _dl_runtime_profile: >> cfi_rel_offset (q6, OFFSET_RG + DL_OFFSET_RG_V0 + 32*3 + 0) >> cfi_rel_offset (q7, OFFSET_RG + DL_OFFSET_RG_V0 + 32*3 + 16) >> >> + strb wzr, [x29, #OFFSET_RG + DL_OFFSET_RG_SVE] >> + strb wzr, [x29, #OFFSET_RV + DL_OFFSET_RV_SVE] >> + >> add x0, x29, #SF_SIZE + 16 >> ldr x1, [x29, #OFFSET_LR] >> stp x0, x1, [x29, #OFFSET_RG + DL_OFFSET_RG_SP] > > I think OFFSET_RG is only defined for !PROF, so this leads to a build > failure: > > […] /home/bmg/build/glibcs/aarch64-linux-gnu/glibc/elf/dl-trampoline.op > ../sysdeps/aarch64/dl-trampoline.S: Assembler messages: > ../sysdeps/aarch64/dl-trampoline.S:503: Error: undefined symbol OFFSET_RG used as an immediate value > ../sysdeps/aarch64/dl-trampoline.S:503: Error: undefined symbol OFFSET_RG used as an immediate value > ../sysdeps/aarch64/dl-trampoline.S:503: Error: undefined symbol OFFSET_RG used as an immediate value > ../sysdeps/aarch64/dl-trampoline.S:503: Error: undefined symbol OFFSET_RG used as an immediate value > ../sysdeps/aarch64/dl-trampoline.S:503: Error: undefined symbol OFFSET_RG used as an immediate value > […] Thanks for catching it, in fact _dl_runtime_profile_sve should only be built for !PROF.