From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2d.google.com (mail-oa1-x2d.google.com [IPv6:2001:4860:4864:20::2d]) by sourceware.org (Postfix) with ESMTPS id CF6C23858D37 for ; Mon, 4 Apr 2022 22:00:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CF6C23858D37 Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-de48295467so12413191fac.2 for ; Mon, 04 Apr 2022 15:00:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=WFlAnCWiM3R2aiBQ8sHultyALQXvgu3KHadSRr6F2Xo=; b=w3t+BpqdybZIckdppnveaNtLmVlSxpnFf8onrhMHDvHBYtmuSWU+bTqcWsN2OGeKhm ukgxGexwov4Jxna4O7hC5y+RV7Fpu/XEmnrFt0umpkpEaOhx/8bg95aR/0XbNwy2F1tD 1nbwCwcGfhac6UfEFac+PiVXTIQ1YoiuiWSOtua2lkL/UdORJ14GmSQZ7NoVt5xhEe/4 /vnaVd5b9QWYLnFETNuai1LgSkKplinvy1q3cSUgNE4kmYp2xK6uK6yJ3QeTbW3ul2j9 3FeE4mVM2gVSYny8bbgtSobfOMi6znlp7z7zE4JCbSMZGa7JFEvnO3ah28B6am8rf78o MIVQ== X-Gm-Message-State: AOAM533g3XCSazIJUnrojo95VqxMHZt6Xhafc5nCYquGQXq0k4msZCIG QtMmSwYsx5HTYNNWm00hzhyI2I6uHYnUTg== X-Google-Smtp-Source: ABdhPJwZbQxwbI7CWkcRfDTzLfg2JZ8ecHPix8eAYwASorLNjwxM2kHqi0LOXkZHe1ZVBI60gMnQQA== X-Received: by 2002:a05:6870:b007:b0:e1:cb97:9171 with SMTP id y7-20020a056870b00700b000e1cb979171mr152439oae.207.1649109626128; Mon, 04 Apr 2022 15:00:26 -0700 (PDT) Received: from ?IPV6:2804:431:c7cb:a6c0:94cf:60bc:16d1:2727? ([2804:431:c7cb:a6c0:94cf:60bc:16d1:2727]) by smtp.gmail.com with ESMTPSA id v13-20020a4ae6cd000000b00328882a2388sm4349418oot.14.2022.04.04.15.00.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Apr 2022 15:00:25 -0700 (PDT) Message-ID: Date: Mon, 4 Apr 2022 19:00:22 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] math: Add math-use-builtins-fabs Content-Language: en-US To: Joseph Myers Cc: libc-alpha@sourceware.org References: <20220404205805.701759-1-adhemerval.zanella@linaro.org> From: Adhemerval Zanella In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Apr 2022 22:00:29 -0000 On 04/04/2022 18:30, Joseph Myers wrote: > On Mon, 4 Apr 2022, Adhemerval Zanella via Libc-alpha wrote: > >> Both float and double are assumed to be supported (since generic >> implementation uses it without a fallback), only long double and >> float128 are defined. > > The only case where built-in fabs (or copysign) may not work properly is > IBM long double in the soft-float case (see > sysdeps/powerpc/nofpu/Makefile). I'd expect the default to be that it > works with an override for long double fabs in that one soft-float case. I am adding a way to override float128 builtin support because I plan to support building glibc with clang, which does not support inline __builtin_fabsf128. I change the patch to assume _Float128 support, but set it on this patch makes the required further changes simpler. > >> On ia64 it also fixes: >> >> math/test-float64x-fabs >> math/test-ldouble-fabs > > If this is fixing a bug that was user-visible in a release, there should > be a corresponding report in Bugzilla. > Ack.