From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2b.google.com (mail-oa1-x2b.google.com [IPv6:2001:4860:4864:20::2b]) by sourceware.org (Postfix) with ESMTPS id 93155383D82E for ; Wed, 1 Jun 2022 18:35:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 93155383D82E Received: by mail-oa1-x2b.google.com with SMTP id 586e51a60fabf-f3381207a5so3859420fac.4 for ; Wed, 01 Jun 2022 11:35:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=CR6J4Q5KwyY+1Ox6mAph2mQoettat1PDkkv5534YF3A=; b=DPzpNg+w6NX8sV4dTcn4K9gQSmRpKjusipNWqq59DExW2Vii3Nb/QBdg4tzW7G1M0k v3CgVA+Kvn9taWMTpa5p7QnOMGaD4/xDX3X9r2MeWDWt8I712NjKOdHFCAcoijUEhme0 HYSllSp9GZ0uNjPXmHYD/Gc07PBHWOGw+SyA4jMu8rrGNUSTKAqZqtlzmav8D5rDFkYT n0hGJ7GKjpBr7cThc8ljSRSVrzjDO4MuMinpaxVy1PjzMFAocZyEMX/w+ekUZ0abFXRx BGipjBu3t3b+0YUgCZTguKLq6fBtGcQYueCO2YQTOdQDtYeyixMHaIXW01ZEtaCOGnTX +PcA== X-Gm-Message-State: AOAM532hrRY7o44ExDN4EIAWDhEFZderKvf80vrNDiVEFFlD1Mpabu7n zCz9HxdDP2O/PB7zCD9t/o/eTA== X-Google-Smtp-Source: ABdhPJyqUH1PzaTV6eb5TJYFEOhTwFc626IuOWMT0VhzjyaEXrQpZfTDdeD8hWCpsFqiE8/9ttkcPQ== X-Received: by 2002:a05:6870:d392:b0:e2:aa54:9601 with SMTP id k18-20020a056870d39200b000e2aa549601mr18202527oag.184.1654108526190; Wed, 01 Jun 2022 11:35:26 -0700 (PDT) Received: from ?IPV6:2804:431:c7ca:e39c:a183:7f80:9e50:177b? ([2804:431:c7ca:e39c:a183:7f80:9e50:177b]) by smtp.gmail.com with ESMTPSA id a10-20020a056808128a00b00325cda1ff8dsm1351235oiw.12.2022.06.01.11.35.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jun 2022 11:35:25 -0700 (PDT) Message-ID: Date: Wed, 1 Jun 2022 15:35:22 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2 07/15] linux: Add process_mrelease Content-Language: en-US To: Carlos O'Donell , libc-alpha@sourceware.org References: <20220207174431.360355-1-adhemerval.zanella@linaro.org> <20220207174431.360355-8-adhemerval.zanella@linaro.org> From: Adhemerval Zanella In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jun 2022 18:35:32 -0000 On 31/05/2022 19:12, Carlos O'Donell wrote: > On 2/7/22 12:44, Adhemerval Zanella via Libc-alpha wrote: >> It was added on Linux 5.15 (884a7e5964e06ed93c7771c0d7cf19c09a8946f1) >> to allow release the memory of a dying process from the context of the >> caller. > > As requested for patch 6, if you can split 6 and 7 out we can review them as a set. > > Suggest: > > Added in Linux 5.15 (884a7e5964e06ed93c7771c0d7cf19c09a8946f1), the new syscalls > allows a caller to free the memory of a dying target process. Ack. > >> --- >> NEWS | 3 + >> sysdeps/unix/sysv/linux/Makefile | 1 + >> sysdeps/unix/sysv/linux/Versions | 1 + >> sysdeps/unix/sysv/linux/aarch64/libc.abilist | 1 + >> sysdeps/unix/sysv/linux/alpha/libc.abilist | 1 + >> sysdeps/unix/sysv/linux/arc/libc.abilist | 1 + >> sysdeps/unix/sysv/linux/arm/be/libc.abilist | 1 + >> sysdeps/unix/sysv/linux/arm/le/libc.abilist | 1 + >> sysdeps/unix/sysv/linux/bits/mman_ext.h | 2 + >> sysdeps/unix/sysv/linux/csky/libc.abilist | 1 + >> sysdeps/unix/sysv/linux/hppa/libc.abilist | 1 + >> sysdeps/unix/sysv/linux/i386/libc.abilist | 1 + >> sysdeps/unix/sysv/linux/ia64/libc.abilist | 1 + >> .../sysv/linux/m68k/coldfire/libc.abilist | 1 + >> .../unix/sysv/linux/m68k/m680x0/libc.abilist | 1 + >> .../sysv/linux/microblaze/be/libc.abilist | 1 + >> .../sysv/linux/microblaze/le/libc.abilist | 1 + >> .../sysv/linux/mips/mips32/fpu/libc.abilist | 1 + >> .../sysv/linux/mips/mips32/nofpu/libc.abilist | 1 + >> .../sysv/linux/mips/mips64/n32/libc.abilist | 1 + >> .../sysv/linux/mips/mips64/n64/libc.abilist | 1 + >> sysdeps/unix/sysv/linux/nios2/libc.abilist | 1 + >> sysdeps/unix/sysv/linux/or1k/libc.abilist | 1 + >> .../linux/powerpc/powerpc32/fpu/libc.abilist | 1 + >> .../powerpc/powerpc32/nofpu/libc.abilist | 1 + >> .../linux/powerpc/powerpc64/be/libc.abilist | 1 + >> .../linux/powerpc/powerpc64/le/libc.abilist | 1 + >> .../unix/sysv/linux/riscv/rv32/libc.abilist | 1 + >> .../unix/sysv/linux/riscv/rv64/libc.abilist | 1 + >> .../unix/sysv/linux/s390/s390-32/libc.abilist | 1 + >> .../unix/sysv/linux/s390/s390-64/libc.abilist | 1 + >> sysdeps/unix/sysv/linux/sh/be/libc.abilist | 1 + >> sysdeps/unix/sysv/linux/sh/le/libc.abilist | 1 + >> .../sysv/linux/sparc/sparc32/libc.abilist | 1 + >> .../sysv/linux/sparc/sparc64/libc.abilist | 1 + >> sysdeps/unix/sysv/linux/syscalls.list | 1 + >> .../unix/sysv/linux/tst-process_mrelease.c | 72 +++++++++++++++++++ >> .../unix/sysv/linux/x86_64/64/libc.abilist | 1 + >> .../unix/sysv/linux/x86_64/x32/libc.abilist | 1 + >> 39 files changed, 113 insertions(+) >> create mode 100644 sysdeps/unix/sysv/linux/tst-process_mrelease.c >> >> diff --git a/NEWS b/NEWS >> index 47cab5d5c1..7893643f83 100644 >> --- a/NEWS >> +++ b/NEWS >> @@ -16,6 +16,9 @@ Major new features: >> * On Linux, the process_madvise has been added. It is has the same >> functionality as madvise but using a pidfd of the target process. >> >> +* On Linux, the process_mrelease has been added. It allows release the >> + memory of a dying process from the context of the caller. > > Suggest: > > ... > It allows a caller to release the memory of a dying process. The release of the memory > is carried out in the context of the caller, using the caller's CPU affinity, and > priority with CPU usage accounted to the caller. > Ack. > >> + >> Deprecated and removed features, and other changes affecting compatibility: >> >> [Add deprecations, removals and changes affecting compatibility here] >> diff --git a/sysdeps/unix/sysv/linux/Makefile b/sysdeps/unix/sysv/linux/Makefile >> index 2c7c425ab7..a4faa4a415 100644 >> --- a/sysdeps/unix/sysv/linux/Makefile >> +++ b/sysdeps/unix/sysv/linux/Makefile >> @@ -128,6 +128,7 @@ tests += tst-clone tst-clone2 tst-clone3 tst-fanotify tst-personality \ >> tst-scm_rights \ >> tst-epoll \ >> tst-pidfd \ >> + tst-process_mrelease \ > > OK. > >> # tests >> >> # process_madvise requires CAP_SYS_ADMIN. >> diff --git a/sysdeps/unix/sysv/linux/Versions b/sysdeps/unix/sysv/linux/Versions >> index c13a3c4fe7..66a995d3dc 100644 >> --- a/sysdeps/unix/sysv/linux/Versions >> +++ b/sysdeps/unix/sysv/linux/Versions >> @@ -304,6 +304,7 @@ libc { >> pidfd_getfd; >> pidfd_send_signal; >> process_madvise; >> + process_mrelease; > > OK. > >> } >> GLIBC_PRIVATE { >> # functions used in other libraries >> diff --git a/sysdeps/unix/sysv/linux/aarch64/libc.abilist b/sysdeps/unix/sysv/linux/aarch64/libc.abilist >> index 4d8e64ce04..027a1cf531 100644 >> --- a/sysdeps/unix/sysv/linux/aarch64/libc.abilist >> +++ b/sysdeps/unix/sysv/linux/aarch64/libc.abilist >> @@ -2620,3 +2620,4 @@ GLIBC_2.36 pidfd_getfd F >> GLIBC_2.36 pidfd_open F >> GLIBC_2.36 pidfd_send_signal F >> GLIBC_2.36 process_madvise F >> +GLIBC_2.36 process_mrelease F >> diff --git a/sysdeps/unix/sysv/linux/alpha/libc.abilist b/sysdeps/unix/sysv/linux/alpha/libc.abilist >> index 36f3129257..703fcf5deb 100644 >> --- a/sysdeps/unix/sysv/linux/alpha/libc.abilist >> +++ b/sysdeps/unix/sysv/linux/alpha/libc.abilist >> @@ -2717,6 +2717,7 @@ GLIBC_2.36 pidfd_getfd F >> GLIBC_2.36 pidfd_open F >> GLIBC_2.36 pidfd_send_signal F >> GLIBC_2.36 process_madvise F >> +GLIBC_2.36 process_mrelease F >> GLIBC_2.4 _IO_fprintf F >> GLIBC_2.4 _IO_printf F >> GLIBC_2.4 _IO_sprintf F >> diff --git a/sysdeps/unix/sysv/linux/arc/libc.abilist b/sysdeps/unix/sysv/linux/arc/libc.abilist >> index 2a1e346d4b..28c52dcbac 100644 >> --- a/sysdeps/unix/sysv/linux/arc/libc.abilist >> +++ b/sysdeps/unix/sysv/linux/arc/libc.abilist >> @@ -2381,3 +2381,4 @@ GLIBC_2.36 pidfd_getfd F >> GLIBC_2.36 pidfd_open F >> GLIBC_2.36 pidfd_send_signal F >> GLIBC_2.36 process_madvise F >> +GLIBC_2.36 process_mrelease F >> diff --git a/sysdeps/unix/sysv/linux/arm/be/libc.abilist b/sysdeps/unix/sysv/linux/arm/be/libc.abilist >> index 25de8a018c..c3adade814 100644 >> --- a/sysdeps/unix/sysv/linux/arm/be/libc.abilist >> +++ b/sysdeps/unix/sysv/linux/arm/be/libc.abilist >> @@ -500,6 +500,7 @@ GLIBC_2.36 pidfd_getfd F >> GLIBC_2.36 pidfd_open F >> GLIBC_2.36 pidfd_send_signal F >> GLIBC_2.36 process_madvise F >> +GLIBC_2.36 process_mrelease F >> GLIBC_2.4 _Exit F >> GLIBC_2.4 _IO_2_1_stderr_ D 0xa0 >> GLIBC_2.4 _IO_2_1_stdin_ D 0xa0 >> diff --git a/sysdeps/unix/sysv/linux/arm/le/libc.abilist b/sysdeps/unix/sysv/linux/arm/le/libc.abilist >> index e9cf9b1593..33a90a248e 100644 >> --- a/sysdeps/unix/sysv/linux/arm/le/libc.abilist >> +++ b/sysdeps/unix/sysv/linux/arm/le/libc.abilist >> @@ -497,6 +497,7 @@ GLIBC_2.36 pidfd_getfd F >> GLIBC_2.36 pidfd_open F >> GLIBC_2.36 pidfd_send_signal F >> GLIBC_2.36 process_madvise F >> +GLIBC_2.36 process_mrelease F >> GLIBC_2.4 _Exit F >> GLIBC_2.4 _IO_2_1_stderr_ D 0xa0 >> GLIBC_2.4 _IO_2_1_stdin_ D 0xa0 >> diff --git a/sysdeps/unix/sysv/linux/bits/mman_ext.h b/sysdeps/unix/sysv/linux/bits/mman_ext.h >> index 20960e7df5..97234a7adf 100644 >> --- a/sysdeps/unix/sysv/linux/bits/mman_ext.h >> +++ b/sysdeps/unix/sysv/linux/bits/mman_ext.h >> @@ -30,4 +30,6 @@ extern __ssize_t process_madvise (int __pid_fd, const struct iovec* __iov, >> unsigned __flags) >> __THROW; >> >> +extern int process_mrelease (int pidfd, unsigned int flags) __THROW; > > OK. > >> + >> #endif /* __USE_GNU */ >> diff --git a/sysdeps/unix/sysv/linux/csky/libc.abilist b/sysdeps/unix/sysv/linux/csky/libc.abilist >> index 66c2f28c43..23a00cfc0b 100644 >> --- a/sysdeps/unix/sysv/linux/csky/libc.abilist >> +++ b/sysdeps/unix/sysv/linux/csky/libc.abilist >> @@ -2656,3 +2656,4 @@ GLIBC_2.36 pidfd_getfd F >> GLIBC_2.36 pidfd_open F >> GLIBC_2.36 pidfd_send_signal F >> GLIBC_2.36 process_madvise F >> +GLIBC_2.36 process_mrelease F >> diff --git a/sysdeps/unix/sysv/linux/hppa/libc.abilist b/sysdeps/unix/sysv/linux/hppa/libc.abilist >> index 527880dc06..93e1068208 100644 >> --- a/sysdeps/unix/sysv/linux/hppa/libc.abilist >> +++ b/sysdeps/unix/sysv/linux/hppa/libc.abilist >> @@ -2605,6 +2605,7 @@ GLIBC_2.36 pidfd_getfd F >> GLIBC_2.36 pidfd_open F >> GLIBC_2.36 pidfd_send_signal F >> GLIBC_2.36 process_madvise F >> +GLIBC_2.36 process_mrelease F >> GLIBC_2.4 __confstr_chk F >> GLIBC_2.4 __fgets_chk F >> GLIBC_2.4 __fgets_unlocked_chk F >> diff --git a/sysdeps/unix/sysv/linux/i386/libc.abilist b/sysdeps/unix/sysv/linux/i386/libc.abilist >> index 1497b8a2c3..356b05cae4 100644 >> --- a/sysdeps/unix/sysv/linux/i386/libc.abilist >> +++ b/sysdeps/unix/sysv/linux/i386/libc.abilist >> @@ -2789,6 +2789,7 @@ GLIBC_2.36 pidfd_getfd F >> GLIBC_2.36 pidfd_open F >> GLIBC_2.36 pidfd_send_signal F >> GLIBC_2.36 process_madvise F >> +GLIBC_2.36 process_mrelease F >> GLIBC_2.4 __confstr_chk F >> GLIBC_2.4 __fgets_chk F >> GLIBC_2.4 __fgets_unlocked_chk F >> diff --git a/sysdeps/unix/sysv/linux/ia64/libc.abilist b/sysdeps/unix/sysv/linux/ia64/libc.abilist >> index abe351d0b4..58e51aae4b 100644 >> --- a/sysdeps/unix/sysv/linux/ia64/libc.abilist >> +++ b/sysdeps/unix/sysv/linux/ia64/libc.abilist >> @@ -2555,6 +2555,7 @@ GLIBC_2.36 pidfd_getfd F >> GLIBC_2.36 pidfd_open F >> GLIBC_2.36 pidfd_send_signal F >> GLIBC_2.36 process_madvise F >> +GLIBC_2.36 process_mrelease F >> GLIBC_2.4 __confstr_chk F >> GLIBC_2.4 __fgets_chk F >> GLIBC_2.4 __fgets_unlocked_chk F >> diff --git a/sysdeps/unix/sysv/linux/m68k/coldfire/libc.abilist b/sysdeps/unix/sysv/linux/m68k/coldfire/libc.abilist >> index 130f7a6b04..ea4a19cbc2 100644 >> --- a/sysdeps/unix/sysv/linux/m68k/coldfire/libc.abilist >> +++ b/sysdeps/unix/sysv/linux/m68k/coldfire/libc.abilist >> @@ -501,6 +501,7 @@ GLIBC_2.36 pidfd_getfd F >> GLIBC_2.36 pidfd_open F >> GLIBC_2.36 pidfd_send_signal F >> GLIBC_2.36 process_madvise F >> +GLIBC_2.36 process_mrelease F >> GLIBC_2.4 _Exit F >> GLIBC_2.4 _IO_2_1_stderr_ D 0x98 >> GLIBC_2.4 _IO_2_1_stdin_ D 0x98 >> diff --git a/sysdeps/unix/sysv/linux/m68k/m680x0/libc.abilist b/sysdeps/unix/sysv/linux/m68k/m680x0/libc.abilist >> index cf59edb383..217717859c 100644 >> --- a/sysdeps/unix/sysv/linux/m68k/m680x0/libc.abilist >> +++ b/sysdeps/unix/sysv/linux/m68k/m680x0/libc.abilist >> @@ -2732,6 +2732,7 @@ GLIBC_2.36 pidfd_getfd F >> GLIBC_2.36 pidfd_open F >> GLIBC_2.36 pidfd_send_signal F >> GLIBC_2.36 process_madvise F >> +GLIBC_2.36 process_mrelease F >> GLIBC_2.4 __confstr_chk F >> GLIBC_2.4 __fgets_chk F >> GLIBC_2.4 __fgets_unlocked_chk F >> diff --git a/sysdeps/unix/sysv/linux/microblaze/be/libc.abilist b/sysdeps/unix/sysv/linux/microblaze/be/libc.abilist >> index f1b927d63d..0e373d5c89 100644 >> --- a/sysdeps/unix/sysv/linux/microblaze/be/libc.abilist >> +++ b/sysdeps/unix/sysv/linux/microblaze/be/libc.abilist >> @@ -2705,3 +2705,4 @@ GLIBC_2.36 pidfd_getfd F >> GLIBC_2.36 pidfd_open F >> GLIBC_2.36 pidfd_send_signal F >> GLIBC_2.36 process_madvise F >> +GLIBC_2.36 process_mrelease F >> diff --git a/sysdeps/unix/sysv/linux/microblaze/le/libc.abilist b/sysdeps/unix/sysv/linux/microblaze/le/libc.abilist >> index 9bb7c76f94..569d3e5556 100644 >> --- a/sysdeps/unix/sysv/linux/microblaze/le/libc.abilist >> +++ b/sysdeps/unix/sysv/linux/microblaze/le/libc.abilist >> @@ -2702,3 +2702,4 @@ GLIBC_2.36 pidfd_getfd F >> GLIBC_2.36 pidfd_open F >> GLIBC_2.36 pidfd_send_signal F >> GLIBC_2.36 process_madvise F >> +GLIBC_2.36 process_mrelease F >> diff --git a/sysdeps/unix/sysv/linux/mips/mips32/fpu/libc.abilist b/sysdeps/unix/sysv/linux/mips/mips32/fpu/libc.abilist >> index 03e7820eea..7ccc7f93eb 100644 >> --- a/sysdeps/unix/sysv/linux/mips/mips32/fpu/libc.abilist >> +++ b/sysdeps/unix/sysv/linux/mips/mips32/fpu/libc.abilist >> @@ -2697,6 +2697,7 @@ GLIBC_2.36 pidfd_getfd F >> GLIBC_2.36 pidfd_open F >> GLIBC_2.36 pidfd_send_signal F >> GLIBC_2.36 process_madvise F >> +GLIBC_2.36 process_mrelease F >> GLIBC_2.4 __confstr_chk F >> GLIBC_2.4 __fgets_chk F >> GLIBC_2.4 __fgets_unlocked_chk F >> diff --git a/sysdeps/unix/sysv/linux/mips/mips32/nofpu/libc.abilist b/sysdeps/unix/sysv/linux/mips/mips32/nofpu/libc.abilist >> index 3d70dc1140..d197f0bd5d 100644 >> --- a/sysdeps/unix/sysv/linux/mips/mips32/nofpu/libc.abilist >> +++ b/sysdeps/unix/sysv/linux/mips/mips32/nofpu/libc.abilist >> @@ -2695,6 +2695,7 @@ GLIBC_2.36 pidfd_getfd F >> GLIBC_2.36 pidfd_open F >> GLIBC_2.36 pidfd_send_signal F >> GLIBC_2.36 process_madvise F >> +GLIBC_2.36 process_mrelease F >> GLIBC_2.4 __confstr_chk F >> GLIBC_2.4 __fgets_chk F >> GLIBC_2.4 __fgets_unlocked_chk F >> diff --git a/sysdeps/unix/sysv/linux/mips/mips64/n32/libc.abilist b/sysdeps/unix/sysv/linux/mips/mips64/n32/libc.abilist >> index 5498e2ee30..4a8e857e53 100644 >> --- a/sysdeps/unix/sysv/linux/mips/mips64/n32/libc.abilist >> +++ b/sysdeps/unix/sysv/linux/mips/mips64/n32/libc.abilist >> @@ -2703,6 +2703,7 @@ GLIBC_2.36 pidfd_getfd F >> GLIBC_2.36 pidfd_open F >> GLIBC_2.36 pidfd_send_signal F >> GLIBC_2.36 process_madvise F >> +GLIBC_2.36 process_mrelease F >> GLIBC_2.4 __confstr_chk F >> GLIBC_2.4 __fgets_chk F >> GLIBC_2.4 __fgets_unlocked_chk F >> diff --git a/sysdeps/unix/sysv/linux/mips/mips64/n64/libc.abilist b/sysdeps/unix/sysv/linux/mips/mips64/n64/libc.abilist >> index dbebed5d36..e0a170c030 100644 >> --- a/sysdeps/unix/sysv/linux/mips/mips64/n64/libc.abilist >> +++ b/sysdeps/unix/sysv/linux/mips/mips64/n64/libc.abilist >> @@ -2606,6 +2606,7 @@ GLIBC_2.36 pidfd_getfd F >> GLIBC_2.36 pidfd_open F >> GLIBC_2.36 pidfd_send_signal F >> GLIBC_2.36 process_madvise F >> +GLIBC_2.36 process_mrelease F >> GLIBC_2.4 __confstr_chk F >> GLIBC_2.4 __fgets_chk F >> GLIBC_2.4 __fgets_unlocked_chk F >> diff --git a/sysdeps/unix/sysv/linux/nios2/libc.abilist b/sysdeps/unix/sysv/linux/nios2/libc.abilist >> index a0bfa86068..6f809245c9 100644 >> --- a/sysdeps/unix/sysv/linux/nios2/libc.abilist >> +++ b/sysdeps/unix/sysv/linux/nios2/libc.abilist >> @@ -2744,3 +2744,4 @@ GLIBC_2.36 pidfd_getfd F >> GLIBC_2.36 pidfd_open F >> GLIBC_2.36 pidfd_send_signal F >> GLIBC_2.36 process_madvise F >> +GLIBC_2.36 process_mrelease F >> diff --git a/sysdeps/unix/sysv/linux/or1k/libc.abilist b/sysdeps/unix/sysv/linux/or1k/libc.abilist >> index 7d09a03d0e..1fc9e27c27 100644 >> --- a/sysdeps/unix/sysv/linux/or1k/libc.abilist >> +++ b/sysdeps/unix/sysv/linux/or1k/libc.abilist >> @@ -2127,3 +2127,4 @@ GLIBC_2.36 pidfd_getfd F >> GLIBC_2.36 pidfd_open F >> GLIBC_2.36 pidfd_send_signal F >> GLIBC_2.36 process_madvise F >> +GLIBC_2.36 process_mrelease F >> diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc32/fpu/libc.abilist b/sysdeps/unix/sysv/linux/powerpc/powerpc32/fpu/libc.abilist >> index db8fc28e75..01ba1dd9ec 100644 >> --- a/sysdeps/unix/sysv/linux/powerpc/powerpc32/fpu/libc.abilist >> +++ b/sysdeps/unix/sysv/linux/powerpc/powerpc32/fpu/libc.abilist >> @@ -2759,6 +2759,7 @@ GLIBC_2.36 pidfd_getfd F >> GLIBC_2.36 pidfd_open F >> GLIBC_2.36 pidfd_send_signal F >> GLIBC_2.36 process_madvise F >> +GLIBC_2.36 process_mrelease F >> GLIBC_2.4 _IO_fprintf F >> GLIBC_2.4 _IO_printf F >> GLIBC_2.4 _IO_sprintf F >> diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/libc.abilist b/sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/libc.abilist >> index e6cbb83b26..263231a396 100644 >> --- a/sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/libc.abilist >> +++ b/sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/libc.abilist >> @@ -2792,6 +2792,7 @@ GLIBC_2.36 pidfd_getfd F >> GLIBC_2.36 pidfd_open F >> GLIBC_2.36 pidfd_send_signal F >> GLIBC_2.36 process_madvise F >> +GLIBC_2.36 process_mrelease F >> GLIBC_2.4 _IO_fprintf F >> GLIBC_2.4 _IO_printf F >> GLIBC_2.4 _IO_sprintf F >> diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc64/be/libc.abilist b/sysdeps/unix/sysv/linux/powerpc/powerpc64/be/libc.abilist >> index 162241fc68..2c3c3af8fb 100644 >> --- a/sysdeps/unix/sysv/linux/powerpc/powerpc64/be/libc.abilist >> +++ b/sysdeps/unix/sysv/linux/powerpc/powerpc64/be/libc.abilist >> @@ -2514,6 +2514,7 @@ GLIBC_2.36 pidfd_getfd F >> GLIBC_2.36 pidfd_open F >> GLIBC_2.36 pidfd_send_signal F >> GLIBC_2.36 process_madvise F >> +GLIBC_2.36 process_mrelease F >> GLIBC_2.4 _IO_fprintf F >> GLIBC_2.4 _IO_printf F >> GLIBC_2.4 _IO_sprintf F >> diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc64/le/libc.abilist b/sysdeps/unix/sysv/linux/powerpc/powerpc64/le/libc.abilist >> index 2845ee2015..4138874b38 100644 >> --- a/sysdeps/unix/sysv/linux/powerpc/powerpc64/le/libc.abilist >> +++ b/sysdeps/unix/sysv/linux/powerpc/powerpc64/le/libc.abilist >> @@ -2816,3 +2816,4 @@ GLIBC_2.36 pidfd_getfd F >> GLIBC_2.36 pidfd_open F >> GLIBC_2.36 pidfd_send_signal F >> GLIBC_2.36 process_madvise F >> +GLIBC_2.36 process_mrelease F >> diff --git a/sysdeps/unix/sysv/linux/riscv/rv32/libc.abilist b/sysdeps/unix/sysv/linux/riscv/rv32/libc.abilist >> index 277f6fbe95..5feae3245f 100644 >> --- a/sysdeps/unix/sysv/linux/riscv/rv32/libc.abilist >> +++ b/sysdeps/unix/sysv/linux/riscv/rv32/libc.abilist >> @@ -2383,3 +2383,4 @@ GLIBC_2.36 pidfd_getfd F >> GLIBC_2.36 pidfd_open F >> GLIBC_2.36 pidfd_send_signal F >> GLIBC_2.36 process_madvise F >> +GLIBC_2.36 process_mrelease F >> diff --git a/sysdeps/unix/sysv/linux/riscv/rv64/libc.abilist b/sysdeps/unix/sysv/linux/riscv/rv64/libc.abilist >> index 6f2a4d4504..3e6a4ae5ec 100644 >> --- a/sysdeps/unix/sysv/linux/riscv/rv64/libc.abilist >> +++ b/sysdeps/unix/sysv/linux/riscv/rv64/libc.abilist >> @@ -2583,3 +2583,4 @@ GLIBC_2.36 pidfd_getfd F >> GLIBC_2.36 pidfd_open F >> GLIBC_2.36 pidfd_send_signal F >> GLIBC_2.36 process_madvise F >> +GLIBC_2.36 process_mrelease F >> diff --git a/sysdeps/unix/sysv/linux/s390/s390-32/libc.abilist b/sysdeps/unix/sysv/linux/s390/s390-32/libc.abilist >> index bfb317488d..93c7b79b51 100644 >> --- a/sysdeps/unix/sysv/linux/s390/s390-32/libc.abilist >> +++ b/sysdeps/unix/sysv/linux/s390/s390-32/libc.abilist >> @@ -2757,6 +2757,7 @@ GLIBC_2.36 pidfd_getfd F >> GLIBC_2.36 pidfd_open F >> GLIBC_2.36 pidfd_send_signal F >> GLIBC_2.36 process_madvise F >> +GLIBC_2.36 process_mrelease F >> GLIBC_2.4 _IO_fprintf F >> GLIBC_2.4 _IO_printf F >> GLIBC_2.4 _IO_sprintf F >> diff --git a/sysdeps/unix/sysv/linux/s390/s390-64/libc.abilist b/sysdeps/unix/sysv/linux/s390/s390-64/libc.abilist >> index beef516979..b663fabeba 100644 >> --- a/sysdeps/unix/sysv/linux/s390/s390-64/libc.abilist >> +++ b/sysdeps/unix/sysv/linux/s390/s390-64/libc.abilist >> @@ -2551,6 +2551,7 @@ GLIBC_2.36 pidfd_getfd F >> GLIBC_2.36 pidfd_open F >> GLIBC_2.36 pidfd_send_signal F >> GLIBC_2.36 process_madvise F >> +GLIBC_2.36 process_mrelease F >> GLIBC_2.4 _IO_fprintf F >> GLIBC_2.4 _IO_printf F >> GLIBC_2.4 _IO_sprintf F >> diff --git a/sysdeps/unix/sysv/linux/sh/be/libc.abilist b/sysdeps/unix/sysv/linux/sh/be/libc.abilist >> index c326c9320a..abebf77944 100644 >> --- a/sysdeps/unix/sysv/linux/sh/be/libc.abilist >> +++ b/sysdeps/unix/sysv/linux/sh/be/libc.abilist >> @@ -2612,6 +2612,7 @@ GLIBC_2.36 pidfd_getfd F >> GLIBC_2.36 pidfd_open F >> GLIBC_2.36 pidfd_send_signal F >> GLIBC_2.36 process_madvise F >> +GLIBC_2.36 process_mrelease F >> GLIBC_2.4 __confstr_chk F >> GLIBC_2.4 __fgets_chk F >> GLIBC_2.4 __fgets_unlocked_chk F >> diff --git a/sysdeps/unix/sysv/linux/sh/le/libc.abilist b/sysdeps/unix/sysv/linux/sh/le/libc.abilist >> index 704f489a8e..afd8a42895 100644 >> --- a/sysdeps/unix/sysv/linux/sh/le/libc.abilist >> +++ b/sysdeps/unix/sysv/linux/sh/le/libc.abilist >> @@ -2609,6 +2609,7 @@ GLIBC_2.36 pidfd_getfd F >> GLIBC_2.36 pidfd_open F >> GLIBC_2.36 pidfd_send_signal F >> GLIBC_2.36 process_madvise F >> +GLIBC_2.36 process_mrelease F >> GLIBC_2.4 __confstr_chk F >> GLIBC_2.4 __fgets_chk F >> GLIBC_2.4 __fgets_unlocked_chk F >> diff --git a/sysdeps/unix/sysv/linux/sparc/sparc32/libc.abilist b/sysdeps/unix/sysv/linux/sparc/sparc32/libc.abilist >> index b9e8a34153..56feda817d 100644 >> --- a/sysdeps/unix/sysv/linux/sparc/sparc32/libc.abilist >> +++ b/sysdeps/unix/sysv/linux/sparc/sparc32/libc.abilist >> @@ -2752,6 +2752,7 @@ GLIBC_2.36 pidfd_getfd F >> GLIBC_2.36 pidfd_open F >> GLIBC_2.36 pidfd_send_signal F >> GLIBC_2.36 process_madvise F >> +GLIBC_2.36 process_mrelease F >> GLIBC_2.4 _IO_fprintf F >> GLIBC_2.4 _IO_printf F >> GLIBC_2.4 _IO_sprintf F >> diff --git a/sysdeps/unix/sysv/linux/sparc/sparc64/libc.abilist b/sysdeps/unix/sysv/linux/sparc/sparc64/libc.abilist >> index e921a8dd76..00cc5b24d1 100644 >> --- a/sysdeps/unix/sysv/linux/sparc/sparc64/libc.abilist >> +++ b/sysdeps/unix/sysv/linux/sparc/sparc64/libc.abilist >> @@ -2578,6 +2578,7 @@ GLIBC_2.36 pidfd_getfd F >> GLIBC_2.36 pidfd_open F >> GLIBC_2.36 pidfd_send_signal F >> GLIBC_2.36 process_madvise F >> +GLIBC_2.36 process_mrelease F >> GLIBC_2.4 __confstr_chk F >> GLIBC_2.4 __fgets_chk F >> GLIBC_2.4 __fgets_unlocked_chk F >> diff --git a/sysdeps/unix/sysv/linux/syscalls.list b/sysdeps/unix/sysv/linux/syscalls.list >> index 6942a16d0c..289a2c820a 100644 >> --- a/sysdeps/unix/sysv/linux/syscalls.list >> +++ b/sysdeps/unix/sysv/linux/syscalls.list >> @@ -44,6 +44,7 @@ pidfd_getfd EXTRA pidfd_getfd i:iiU pidfd_getfd >> pivot_root EXTRA pivot_root i:ss pivot_root >> pidfd_send_signal EXTRA pidfd_send_signal i:iiPU pidfd_send_signal >> process_madvise EXTRA process_madvise i:iPiiU process_madvise >> +process_mrelease EXTRA process_mrelease i:iU process_mrelease > > OK. > >> query_module EXTRA query_module i:sipip __compat_query_module query_module@GLIBC_2.0:GLIBC_2.23 >> quotactl EXTRA quotactl i:isip quotactl >> remap_file_pages - remap_file_pages i:pUiUi __remap_file_pages remap_file_pages >> diff --git a/sysdeps/unix/sysv/linux/tst-process_mrelease.c b/sysdeps/unix/sysv/linux/tst-process_mrelease.c >> new file mode 100644 >> index 0000000000..eadb7fc73b >> --- /dev/null >> +++ b/sysdeps/unix/sysv/linux/tst-process_mrelease.c >> @@ -0,0 +1,72 @@ >> +/* Basic tests for Linux process_mrelease. >> + Copyright (C) 2022 Free Software Foundation, Inc. >> + This file is part of the GNU C Library. >> + >> + The GNU C Library is free software; you can redistribute it and/or >> + modify it under the terms of the GNU Lesser General Public >> + License as published by the Free Software Foundation; either >> + version 2.1 of the License, or (at your option) any later version. >> + >> + The GNU C Library is distributed in the hope that it will be useful, >> + but WITHOUT ANY WARRANTY; without even the implied warranty of >> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >> + Lesser General Public License for more details. >> + >> + You should have received a copy of the GNU Lesser General Public >> + License along with the GNU C Library; if not, see >> + . */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +static void >> +subprocess (void) >> +{ >> + pause (); >> + _exit (0); >> +} >> + >> +static int >> +do_test (void) >> +{ >> + { >> + int r = process_mrelease (-1, 0); >> + TEST_COMPARE (r, -1); >> + if (errno == ENOSYS) >> + FAIL_UNSUPPORTED ("kernel does not support process_mrelease, " >> + "skipping test"); >> + TEST_COMPARE (errno, EBADF); >> + } >> + >> + pid_t pid = xfork (); >> + if (pid == 0) >> + subprocess (); >> + > > May we please tes process_mrelease returns EBADF for an invalid pidfd? It already does, at line 43 after the ENOSYS check. > >> + int pidfd = pidfd_open (pid, 0); >> + TEST_VERIFY (pidfd != -1); >> + >> + /* The syscall only succeedes if the target process is exiting and there >> + is no guarantee that calling if after pidfd_send_signal will not error >> + (since the process might already been reaped by OS). So just check if > > Suggest: > (since the process might have already been reaped by the OS). > Ack. >> + it does fail when the process is stll running. */ >> + TEST_COMPARE (process_mrelease (pidfd, 0), -1); >> + TEST_COMPARE (errno, EINVAL); > > OK. > >> + >> + TEST_COMPARE (pidfd_send_signal (pidfd, SIGKILL, NULL, 0), 0); >> + { >> + siginfo_t info; >> + int r = waitid (P_PIDFD, pidfd, &info, WEXITED); >> + TEST_COMPARE (r, 0); >> + TEST_COMPARE (info.si_status, SIGKILL); >> + TEST_COMPARE (info.si_code, CLD_KILLED); >> + } > > May we please test process_mrelease returns ESRCH for the now dead pidfd target? Ok, I will add a check for it. > > That covers the life-cycle parts of the API we can test. > >> + >> + return 0; >> +} >> + >> +#include >> diff --git a/sysdeps/unix/sysv/linux/x86_64/64/libc.abilist b/sysdeps/unix/sysv/linux/x86_64/64/libc.abilist >> index 8948dc2705..4e729bdf56 100644 >> --- a/sysdeps/unix/sysv/linux/x86_64/64/libc.abilist >> +++ b/sysdeps/unix/sysv/linux/x86_64/64/libc.abilist >> @@ -2529,6 +2529,7 @@ GLIBC_2.36 pidfd_getfd F >> GLIBC_2.36 pidfd_open F >> GLIBC_2.36 pidfd_send_signal F >> GLIBC_2.36 process_madvise F >> +GLIBC_2.36 process_mrelease F >> GLIBC_2.4 __confstr_chk F >> GLIBC_2.4 __fgets_chk F >> GLIBC_2.4 __fgets_unlocked_chk F >> diff --git a/sysdeps/unix/sysv/linux/x86_64/x32/libc.abilist b/sysdeps/unix/sysv/linux/x86_64/x32/libc.abilist >> index 0988804f24..b5d7b9f1ed 100644 >> --- a/sysdeps/unix/sysv/linux/x86_64/x32/libc.abilist >> +++ b/sysdeps/unix/sysv/linux/x86_64/x32/libc.abilist >> @@ -2635,3 +2635,4 @@ GLIBC_2.36 pidfd_getfd F >> GLIBC_2.36 pidfd_open F >> GLIBC_2.36 pidfd_send_signal F >> GLIBC_2.36 process_madvise F >> +GLIBC_2.36 process_mrelease F > >