From: Szabolcs Nagy <szabolcs.nagy@arm.com>
To: libc-alpha@sourceware.org
Subject: [PATCH v4 00/10] fix ifunc with static pie [BZ #27072]
Date: Mon, 18 Jan 2021 16:22:43 +0000 [thread overview]
Message-ID: <cover.1610986541.git.szabolcs.nagy@arm.com> (raw)
v4:
- added patches from H.J.Lu:
- x86: fix libmvec tests
- x86: fix syscalls in libc_enable_secure
- x86: avoid relative reloc for _dl_sysinfo
- x86: add ifunc test
- i386 cannot mark all symbols hidden, so use fine grain
marking in files that participate in early code before
static pie self relocation.
- the patch that makes all libc symbols hidden is still
included: it is now only an optimization for non-i386
targets.
v3:
- refactor tunables: move internals out of dl-tunables.h
- use generated max string length in the tunables list
instead of magic values.
v2:
- check PI_STATIC_AND_HIDDEN for --enable-static-pie
- change string buffer sizes in the tunables
- fix env_alias == NULL logic in __tunables_init
- move __ehdr_start processing after self relocation
force pushed into nsz/bug27072 branch.
Issues that are not addressed:
- tunables try to allocate memory even with non-suid exe.
allocation is only needed for rewriting the GLIBC_TUNABLES
env var. (i think a case can be made that if anything there
is TUNABLE_SECLEVEL_SXID_ERASE then this env var would be
simply dropped, that would simplify this significantly).
- __sbrk only needs the hidden visibility magic because of
tunables, ideally we would not do allocations before self
relocation.
- tunable list data structure is not optimized for compactness.
- all symbols are forced hidden in libc.a, but i think lib*.a
should do the same. (other than lib*_nonshared.a)
- i386 introduced a fair bit of complications: may be avoiding
relative relocs is too much to ask for and relocations should
be done in two steps after all: relative first, then irelative
when tunable etc are set up.
H.J. Lu (4):
libmvec: Add extra-test-objs to test-extras
elf: Avoid RELATIVE relocation for _dl_sysinfo
Use <startup.h> in __libc_init_secure
x86: Check ifunc resolver with CPU_FEATURE_USABLE [BZ #27072]
Szabolcs Nagy (6):
configure: Require PI_STATIC_AND_HIDDEN for static pie
elf: Make the tunable struct definition internal only
elf: Avoid RELATIVE relocs in __tunables_init
Use hidden visibility for early static PIE code
csu: Move static pie self relocation later [BZ #27072]
Make libc symbols hidden in static PIE
configure | 14 +++
configure.ac | 5 +
csu/libc-start.c | 48 +++++---
elf/dl-reloc-static-pie.c | 2 +
elf/dl-support.c | 18 ++-
elf/dl-tunable-types.h | 42 +++++--
elf/dl-tunables.c | 6 +-
elf/dl-tunables.h | 35 ++----
elf/enbl-secure.c | 10 +-
include/libc-symbols.h | 9 +-
misc/sbrk.c | 4 +
scripts/gen-tunables.awk | 16 ++-
sysdeps/generic/startup.h | 26 ++++
sysdeps/unix/sysv/linux/aarch64/libc-start.c | 5 +
sysdeps/unix/sysv/linux/i386/startup.h | 29 ++++-
sysdeps/x86/Makefile | 14 +++
sysdeps/x86/libc-start.c | 5 +
sysdeps/x86/tst-ifunc-isa-1-static.c | 1 +
sysdeps/x86/tst-ifunc-isa-1.c | 115 ++++++++++++++++++
sysdeps/x86/tst-ifunc-isa-2-static.c | 1 +
sysdeps/x86/tst-ifunc-isa-2.c | 119 +++++++++++++++++++
sysdeps/x86_64/fpu/Makefile | 8 ++
22 files changed, 465 insertions(+), 67 deletions(-)
create mode 100644 sysdeps/x86/tst-ifunc-isa-1-static.c
create mode 100644 sysdeps/x86/tst-ifunc-isa-1.c
create mode 100644 sysdeps/x86/tst-ifunc-isa-2-static.c
create mode 100644 sysdeps/x86/tst-ifunc-isa-2.c
--
2.17.1
next reply other threads:[~2021-01-18 16:23 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 16:22 Szabolcs Nagy [this message]
2021-01-18 16:23 ` [PATCH v4 01/10] configure: Require PI_STATIC_AND_HIDDEN for static pie Szabolcs Nagy
2021-01-18 16:23 ` [PATCH v4 02/10] libmvec: Add extra-test-objs to test-extras Szabolcs Nagy
2021-01-18 20:04 ` Adhemerval Zanella
2021-01-18 16:23 ` [PATCH v4 03/10] elf: Make the tunable struct definition internal only Szabolcs Nagy
2021-01-18 16:24 ` [PATCH v4 04/10] elf: Avoid RELATIVE relocs in __tunables_init Szabolcs Nagy
2021-01-18 16:24 ` [PATCH v4 05/10] Use hidden visibility for early static PIE code Szabolcs Nagy
2021-01-18 21:49 ` Adhemerval Zanella
2021-01-18 16:24 ` [PATCH v4 06/10] elf: Avoid RELATIVE relocation for _dl_sysinfo Szabolcs Nagy
2021-01-19 13:51 ` Adhemerval Zanella
2021-01-19 14:25 ` V2 " H.J. Lu
2021-01-19 14:35 ` Adhemerval Zanella
2021-01-18 16:25 ` [PATCH v4 07/10] Use <startup.h> in __libc_init_secure Szabolcs Nagy
2021-01-19 13:56 ` Adhemerval Zanella
2021-01-18 16:25 ` [PATCH v4 08/10] csu: Move static pie self relocation later [BZ #27072] Szabolcs Nagy
2021-01-19 14:07 ` Adhemerval Zanella
2021-01-19 14:35 ` Szabolcs Nagy
2021-01-19 14:36 ` Adhemerval Zanella
2021-01-19 14:48 ` H.J. Lu
2021-01-19 15:24 ` Szabolcs Nagy
2021-01-19 15:32 ` H.J. Lu
2021-01-19 16:47 ` H.J. Lu
2021-01-19 17:03 ` Szabolcs Nagy
2021-01-19 17:10 ` H.J. Lu
2021-01-19 17:25 ` Fāng-ruì Sòng
2021-01-19 17:33 ` H.J. Lu
2021-01-19 17:38 ` Fāng-ruì Sòng
2021-01-19 17:38 ` Szabolcs Nagy
2021-01-19 17:42 ` H.J. Lu
2021-01-19 17:47 ` Szabolcs Nagy
2021-01-19 17:53 ` H.J. Lu
2021-01-19 17:59 ` H.J. Lu
2021-01-18 16:25 ` [PATCH v4 09/10] x86: Check ifunc resolver with CPU_FEATURE_USABLE " Szabolcs Nagy
2021-01-19 14:11 ` Adhemerval Zanella
2021-01-19 14:37 ` V2 " H.J. Lu
2021-01-21 16:33 ` H.J. Lu
2021-01-18 16:26 ` [PATCH v4 10/10] Make libc symbols hidden in static PIE Szabolcs Nagy
2021-01-18 21:37 ` [PATCH v4 00/10] fix ifunc with static pie [BZ #27072] Adhemerval Zanella
2021-01-19 18:25 ` Szabolcs Nagy
2021-01-19 19:41 ` H.J. Lu
2021-01-19 20:16 ` Adhemerval Zanella
2021-01-19 21:38 ` H.J. Lu
2021-01-20 11:29 ` Adhemerval Zanella
2021-01-20 12:38 ` Szabolcs Nagy
2021-01-20 12:49 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1610986541.git.szabolcs.nagy@arm.com \
--to=szabolcs.nagy@arm.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).