From: Florian Weimer <fweimer@redhat.com>
To: libc-alpha@sourceware.org
Subject: [PATCH 0/3] Fix ESRCH issues in pthread_cancel, pthread_kill
Date: Tue, 17 Aug 2021 15:50:54 +0200 [thread overview]
Message-ID: <cover.1629208174.git.fweimer@redhat.com> (raw)
This mini-series came out of a downstream bug report:
glibc: pthread_cancel fails with ESRCH yet subsequent pthread_join passes
<https://bugzilla.redhat.com/show_bug.cgi?id=1994068>
Apparently the race is much easier to trigger due to the changes in
glibc 2.34.
Tested on i686-linux-gnu, x86_64-linux-gnu. Built with
build-many-glibcs.py.
Thanks,
Florian
Florian Weimer (3):
support: Add support_wait_for_thread_exit
nptl: pthread_kill, pthread_cancel should fail after exit (bug 19193)
nptl: Fix race between pthread_kill and thread exit (bug 12889)
nptl/allocatestack.c | 1 +
nptl/descr.h | 12 ++
nptl/pthread_cancel.c | 9 +-
nptl/pthread_create.c | 20 ++++
nptl/pthread_kill.c | 30 ++++-
support/Makefile | 3 +-
support/support.h | 4 +
support/support_wait_for_thread_exit.c | 67 +++++++++++
sysdeps/pthread/Makefile | 7 +-
sysdeps/pthread/tst-kill4.c | 90 --------------
sysdeps/pthread/tst-pthread_cancel-exited.c | 45 +++++++
.../pthread/tst-pthread_cancel-select-loop.c | 87 ++++++++++++++
sysdeps/pthread/tst-pthread_kill-exited.c | 46 ++++++++
sysdeps/pthread/tst-pthread_kill-exiting.c | 110 ++++++++++++++++++
14 files changed, 431 insertions(+), 100 deletions(-)
create mode 100644 support/support_wait_for_thread_exit.c
delete mode 100644 sysdeps/pthread/tst-kill4.c
create mode 100644 sysdeps/pthread/tst-pthread_cancel-exited.c
create mode 100644 sysdeps/pthread/tst-pthread_cancel-select-loop.c
create mode 100644 sysdeps/pthread/tst-pthread_kill-exited.c
create mode 100644 sysdeps/pthread/tst-pthread_kill-exiting.c
--
2.31.1
next reply other threads:[~2021-08-17 13:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 13:50 Florian Weimer [this message]
2021-08-17 13:50 ` [PATCH 1/3] support: Add support_wait_for_thread_exit Florian Weimer
2021-08-19 16:12 ` Adhemerval Zanella
2021-08-19 16:22 ` Florian Weimer
2021-08-17 13:51 ` [PATCH 2/3] nptl: pthread_kill, pthread_cancel should fail after exit (bug 19193) Florian Weimer
2021-08-17 13:51 ` [PATCH 3/3] nptl: Fix race between pthread_kill and thread exit (bug 12889) Florian Weimer
2021-08-19 16:12 ` Adhemerval Zanella
2021-08-19 16:37 ` Florian Weimer
2021-08-19 16:49 ` Adhemerval Zanella
2021-08-20 16:24 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1629208174.git.fweimer@redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).