public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: libc-alpha@sourceware.org
Subject: [PATCH v3 0/2] Predictable ELF destructor ordering (bug 30785)
Date: Tue, 22 Aug 2023 12:58:21 +0200	[thread overview]
Message-ID: <cover.1692701787.git.fweimer@redhat.com> (raw)

Since my original submission, we have recieved a report that is likely
due to the non-working force_first handling in _dl_sort_maps when it is
called from dlclose.  So I want to propose this for integration once
more.  The ISV has received a test build with a backport, and hopefully
we'll know soon if this patch fixes there issue.

In v3, I have fixed an oversight in auditor integration spotted by
Adhemerval.  Somehow it had made it past my tests.  I'm also deferring
the _dl_sort_maps change to a future cleanup, so there are just two
patches left.

Thanks,
Florian

Florian Weimer (2):
  elf: Do not run constructors for proxy objects
  elf: Always call destructors in reverse constructor order (bug 30785)

 elf/dl-close.c             | 113 ++++++++++++++++---------
 elf/dl-fini.c              | 168 ++++++++++++++++---------------------
 elf/dl-init.c              |  20 +++++
 elf/dso-sort-tests-1.def   |  19 ++---
 elf/tst-audit23.c          |  44 +++++-----
 include/link.h             |   4 +
 sysdeps/generic/ldsodefs.h |   4 +
 7 files changed, 202 insertions(+), 170 deletions(-)


base-commit: 8c4e46337f2ef324f5af9863a962f070fd796cc1
-- 
2.41.0


             reply	other threads:[~2023-08-22 10:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-22 10:58 Florian Weimer [this message]
2023-08-22 10:58 ` [PATCH v3 1/2] elf: Do not run constructors for proxy objects Florian Weimer
2023-08-22 11:14   ` Andreas Schwab
2023-08-22 11:25     ` Florian Weimer
2023-08-22 11:50       ` Andreas Schwab
2023-08-22 10:58 ` [PATCH v3 2/2] elf: Always call destructors in reverse constructor order (bug 30785) Florian Weimer
2023-09-01 17:59   ` DJ Delorie
2023-09-01 21:29     ` Florian Weimer
2023-08-23 10:04 ` [PATCH v3 0/2] Predictable ELF destructor ordering " Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1692701787.git.fweimer@redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).