From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by sourceware.org (Postfix) with ESMTPS id 11A24385772A for ; Wed, 7 Jun 2023 19:05:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 11A24385772A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=owlfolio.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=owlfolio.org Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 9FC193200495 for ; Wed, 7 Jun 2023 15:05:35 -0400 (EDT) Received: from imap45 ([10.202.2.95]) by compute1.internal (MEProxy); Wed, 07 Jun 2023 15:05:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=owlfolio.org; h= cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1686164735; x=1686251135; bh=X+ SGqE4HWe1Tt58Rja9ojSlUTnlqDUJGd7KE0EPf8Zo=; b=HITWZdK29Xtz9bzwcg e8/uFhp9X21dR3iE87kYW0OhipExQS8jL/o4C95+7vwnpTHm2/mGKsmZYvqDAhmN 9MfI5Qxksy7P3bLMFCB3y6pzb1isKGYoSNP6pFuEfoeuu4xZ3ajCpuCJurWfXzaJ lMFOm1engCP9HN4Rx1FALlDtAOHWZvlEeAVvvZ9xxOBNVVaa4FxpkTx8VAyEhzzV ZxNH5Ry7dSRukuoweZfGjNPE5gsN2X01u9bWxdiY40DMghdhRkUNdWygLEVKdYPr W7dMW/OHH8SxjcvLlVfs9KDG9Lt+n+ecC41H8q+QVTA0HulIxPeaCjNfCPc9ayRo cNrw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1686164735; x=1686251135; bh=X+SGqE4HWe1Tt 58Rja9ojSlUTnlqDUJGd7KE0EPf8Zo=; b=xntw5fYZSXwETvamtWnwp4/o8fSIc 5RspvftJicGVuSWOIelkLsKqZSKplO61bF3taucKItfBKASlbb55vNYElvlkgY4N Hpdzdzmu7W5/yh4f/Z+bG3f2IE2Ka6e+oo9p5nLea0rlbl3I9kk2Tj7eeDvlIWTz HdYxTNzr0nVYRPjVHvu8xftc0o+Ha7o//V6CgnxkcnHMpTUkrtw5ErXsygz5OseR EmOPn6ikQ1OP57Px2vArOpnpSn8yVXc+wUObltRkxRLSMZ2w7mcIwtRZNGf+rk8V NDccCKoVXXGsZ4DUuf9Qr8WII8JjrvO/MpNgThJtx18LX2IGyO0hlI68Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedtgedgudeffecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvufgtsehttdertderredtnecuhfhrohhmpedfkggr tghkucghvghinhgsvghrghdfuceoiigrtghksehofihlfhholhhiohdrohhrgheqnecugg ftrfgrthhtvghrnhephfeuhfevueffteffgfejtefgkeekheeftdeflefgheffffevheek leefgfehffdunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepiigrtghksehofihlfhholhhiohdrohhrgh X-ME-Proxy: Feedback-ID: i876146a2:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id DCBC82720080; Wed, 7 Jun 2023 15:05:34 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-447-ge2460e13b3-fm-20230525.001-ge2460e13 Mime-Version: 1.0 Message-Id: In-Reply-To: References: <20230601195817.3251303-1-josimmon@redhat.com> <87ttvmyr3q.fsf@oldenburg.str.redhat.com> <20230605133734.GU176347@oak> <20230605220239.GV176347@oak> Date: Wed, 07 Jun 2023 15:05:13 -0400 From: "Zack Weinberg" To: "GNU libc development" Subject: Re: [PATCH] grantpt: Get rid of alloca Content-Type: text/plain X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Jun 6, 2023, at 2:14 AM, Siddhesh Poyarekar wrote: ... >>>>> How did you test this? This code is only used on Hurd due to the >>>>> override in sysdeps/unix/sysv/linux/grantpt.c. >>>> >>>> The only testing I did was a 'make && make check' on x86_64 and >>>> i686 linux. >>> >>> You will need to build for i686-gnu (Hurd) to actually enable this >>> code. Which leads to another, which Siddheash has brough, which is >>> --enable-pt_chown does make sense to be provided as a configure >>> switch. > > Yeah I looked at the code again and perhaps it's something for Samuel > to think about. We don't seem to have target-specific configure > options, so it's a nop for Linux. pt_chown has been troublesome in the past (up to and including privilege escalation vulnerabilities) and, iirc, it's the only helper binary we build that needs to be setuid. It would be nice if we could get rid of it altogether. I believe the requirements for promoting the Linux- specific code to generic (or just all-GNU) are for the Hurd to implement a /dev/pts virtual file system that automatically adjusts the ownership and permissions of /dev/pts/NNN when someone opens /dev/ptmx, and additionally for it to add support for whichever of the TIOCSPTLCK, TIOCGPTLCK, and TIOCGPTPEER ioctls are not already implemented. zw