From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id B14BA3857C4D for ; Thu, 20 Aug 2020 21:49:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B14BA3857C4D Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-457-2-FtP018PH6e2CnN0E_JVg-1; Thu, 20 Aug 2020 17:49:27 -0400 X-MC-Unique: 2-FtP018PH6e2CnN0E_JVg-1 Received: by mail-qv1-f69.google.com with SMTP id v5so41853qvr.1 for ; Thu, 20 Aug 2020 14:49:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=GEZ21qd/FP9u6deXRugJiW2DAHk3ndTK0RM+pzGqiBM=; b=hFpHOpiLAXB3R30ZkqKqxrz2N0jC+ScJUbPg0MHJ0GaBmHFb3IijNASaptP2Ba2Hlf J9F6Zc3K2MInB0QDCAZ1rnlFPLWCAxKAIGjMJjUcuxCBdse2zDD0i6wCLq0nbcoC5VR5 OwwxGnzm5aMk75U/O84T61qOPhI/IWH03egnQy2nLgBXys483KdZmleXAbiNN9yvWytV hP8in9dX6D5pBQutEJKJuh7pFIdOKXY+IzJuUenVpEfr1fqK7AxUlGQWFqZ5CY1uX3rS faxFB0J0l3sbg38MUVdxQXXamtO2IXUNLnwML85Vbj5EMDh6dEKDWMnrTJO9d8JEEspM swPQ== X-Gm-Message-State: AOAM531UaQFWh7+icViFmoZpLfdlA0AoQDhOYs9QsY+wh6wyfaTPyqSa dLKke5coKhpLBxU1Crvu1RQ/yMoN1q3OfctTkFdZdYKS8jHCp5gtfs7fU0u6vXIkv9MkCPIdoXm vLshIVn40jEWxqEfo9hj/ X-Received: by 2002:ac8:470e:: with SMTP id f14mr589743qtp.380.1597960166339; Thu, 20 Aug 2020 14:49:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyvnh5Ve7PfT0PXxglL0Cf1Ter+du3eckA9BmARmXDCaDqlvO/bZwGeLLynM4swdIxQgnpCXQ== X-Received: by 2002:ac8:470e:: with SMTP id f14mr589733qtp.380.1597960166144; Thu, 20 Aug 2020 14:49:26 -0700 (PDT) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id z17sm3320513qkj.62.2020.08.20.14.49.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Aug 2020 14:49:25 -0700 (PDT) Subject: Re: [PATCH] S390: Sync HWCAP names with kernel by adding aliases [BZ #25971] To: Stefan Liebler , libc-alpha@sourceware.org References: <20200812142831.3694409-1-stli@linux.ibm.com> From: Carlos O'Donell Organization: Red Hat Message-ID: Date: Thu, 20 Aug 2020 17:49:24 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200812142831.3694409-1-stli@linux.ibm.com> Content-Language: en-US X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Aug 2020 21:49:29 -0000 On 8/12/20 10:28 AM, Stefan Liebler via Libc-alpha wrote: > Unfortunately some HWCAP names like HWCAP_S390_VX differs between > kernel (see /arch/s390/include/asm/elf.h) and glibc. > > Therefore, those HWCAP names from kernel are now introduced as alias > to the existing ones in glibc. > --- > sysdeps/s390/dl-procinfo.h | 3 +++ > sysdeps/unix/sysv/linux/s390/bits/hwcap.h | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/sysdeps/s390/dl-procinfo.h b/sysdeps/s390/dl-procinfo.h > index 0db4bc39c7..08eee109f7 100644 > --- a/sysdeps/s390/dl-procinfo.h > +++ b/sysdeps/s390/dl-procinfo.h > @@ -51,8 +51,11 @@ enum > HWCAP_S390_HIGH_GPRS = 1 << 9, > HWCAP_S390_TE = 1 << 10, > HWCAP_S390_VX = 1 << 11, > + HWCAP_S390_VXRS = HWCAP_S390_VX, > HWCAP_S390_VXD = 1 << 12, > + HWCAP_S390_VXRS_BCD = HWCAP_S390_VXD, > HWCAP_S390_VXE = 1 << 13, > + HWCAP_S390_VXRS_EXT = HWCAP_S390_VXE, > HWCAP_S390_GS = 1 << 14, > HWCAP_S390_VXRS_EXT2 = 1 << 15, > HWCAP_S390_VXRS_PDE = 1 << 16, > diff --git a/sysdeps/unix/sysv/linux/s390/bits/hwcap.h b/sysdeps/unix/sysv/linux/s390/bits/hwcap.h > index 6adbec018b..f2998ff131 100644 > --- a/sysdeps/unix/sysv/linux/s390/bits/hwcap.h > +++ b/sysdeps/unix/sysv/linux/s390/bits/hwcap.h > @@ -36,8 +36,11 @@ > #define HWCAP_S390_HIGH_GPRS 512 > #define HWCAP_S390_TE 1024 > #define HWCAP_S390_VX 2048 > +#define HWCAP_S390_VXRS HWCAP_S390_VX > #define HWCAP_S390_VXD 4096 > +#define HWCAP_S390_VXRS_BCD HWCAP_S390_VXD > #define HWCAP_S390_VXE 8192 > +#define HWCAP_S390_VXRS_EXT HWCAP_S390_VXE > #define HWCAP_S390_GS 16384 > #define HWCAP_S390_VXRS_EXT2 32768 > #define HWCAP_S390_VXRS_PDE 65536 > As the machine maintainer you should assume consensus and just commit this. I assume you know what you're doing synchronizing and matching these names. -- Cheers, Carlos.