From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: "H.J. Lu" <hjl.tools@gmail.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH] Fix elf: Do not duplicate the GLIBC_TUNABLES string
Date: Wed, 20 Dec 2023 09:28:44 -0300 [thread overview]
Message-ID: <d0760aaa-4127-4975-8651-e02f9a6aabc0@linaro.org> (raw)
In-Reply-To: <CAMe9rOr+FOEiDkqEZUFw8UXyF=hh+kXYA2_qk4i-KD7P07=NeA@mail.gmail.com>
On 19/12/23 21:31, H.J. Lu wrote:
> On Tue, Dec 19, 2023 at 4:04 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>>
>> commit 2a969b53c0b02fed7e43473a92f219d737fd217a
>> Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>> Date: Wed Dec 6 10:24:01 2023 -0300
>>
>> elf: Do not duplicate the GLIBC_TUNABLES string
>>
>> has
>>
>> @@ -38,7 +39,7 @@
>> which isn't available. */
>> #define CHECK_GLIBC_IFUNC_PREFERRED_OFF(f, cpu_features, name, len) \
>> _Static_assert (sizeof (#name) - 1 == len, #name " != " #len); \
>> - if (memcmp (f, #name, len) == 0) \
>> + if (tunable_str_comma_strcmp_cte (&f, #name) == 0) \
>> { \
>> cpu_features->preferred[index_arch_##name] \
>> &= ~bit_arch_##name; \
>> @@ -46,12 +47,11 @@
>>
>> Fix it by removing "== 0" after tunable_str_comma_strcmp_cte.
>> ---
>> sysdeps/x86/cpu-tunables.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sysdeps/x86/cpu-tunables.c b/sysdeps/x86/cpu-tunables.c
>> index ef96148d30..142c6b9240 100644
>> --- a/sysdeps/x86/cpu-tunables.c
>> +++ b/sysdeps/x86/cpu-tunables.c
>> @@ -39,7 +39,7 @@
>> which isn't available. */
>> #define CHECK_GLIBC_IFUNC_PREFERRED_OFF(f, cpu_features, name, len) \
>> _Static_assert (sizeof (#name) - 1 == len, #name " != " #len); \
>> - if (tunable_str_comma_strcmp_cte (&f, #name) == 0) \
>> + if (tunable_str_comma_strcmp_cte (&f, #name)) \
>> { \
>> cpu_features->preferred[index_arch_##name] \
>> &= ~bit_arch_##name; \
>> --
>> 2.43.0
>>
>
> I am checking it in.
>
LGTM, thanks.
next prev parent reply other threads:[~2023-12-20 12:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 0:04 H.J. Lu
2023-12-20 0:31 ` H.J. Lu
2023-12-20 12:28 ` Adhemerval Zanella Netto [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-12-19 21:27 H.J. Lu
2023-12-19 21:35 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0760aaa-4127-4975-8651-e02f9a6aabc0@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).