From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by sourceware.org (Postfix) with ESMTPS id BF35E3858C31 for ; Wed, 20 Dec 2023 12:28:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BF35E3858C31 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BF35E3858C31 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::536 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703075330; cv=none; b=blYhKtCNgt04sD/peAkfIW9yNuxY5zemStxWVUdWMLaTeLrTeGDhcM6jQXCiPyD6mg8DkySpN9urZ4T+zvlcryRIZ4q0lg3NLxmO1se9zELSwqVy5+cRacIwDntpJxn0wX+jiOMboqUmKlOZ0SiKWf5LpJjWOpy7Eb1AOVdQJX4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703075330; c=relaxed/simple; bh=ZdYck0rxyK2RH1VLmOjnHX26mKAetTLX5Bw8mm1JY9w=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=nJxT42NtTukJFchG727GM4rqH6wbqMvmAsZaZ87vULL/M1b2GFL1hdOJ89176DYYcRzMqFa+c6c/aqeZj0R6pbE8daj1/J3B7zS2EDpH+vKqxGe2rmAfwYPjiepM6B+X23Y6jMW7puAaUvVlIwOulXVwzJ8IFo4CqBeaKc6V2T8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pg1-x536.google.com with SMTP id 41be03b00d2f7-53fbf2c42bfso4264978a12.3 for ; Wed, 20 Dec 2023 04:28:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1703075328; x=1703680128; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+yBQ9D8T8jejLx2Ncsb3WHM8ma5p5ZsEIZAOFhrjjKI=; b=q6K33MqVxehsRzh72T9K8BKZR+dHnN/CghagW2ELRduUWhWyCz2NTY3mKFU9XbP3NL o1yAoVK4X0MK7M3Z4bIASwJiDINiWIaw1ZsvZq+nMmS+e31s5bAczbohpjM86aQfU8y5 MTFH8lhEoUE+f+px7D6JVtY971KWVlu+wyH0tsfrbfimUqKn6DntzdO6y/33LuDxv53K J2HTwaDKqybjHm/E4bAUv2+p1kbR9Jc0UrcSl6tbxvmr2IYOnEJTol/74CTZ0+0zHNRl ClACZBNlGQ7hLENrdJ0W9DAev7GnevYnUENtxma+xs2a7pFiiiOvYfjX+DMfcVBORohK T+uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703075328; x=1703680128; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+yBQ9D8T8jejLx2Ncsb3WHM8ma5p5ZsEIZAOFhrjjKI=; b=kAL8/gLZRq7/DqCoEdF7BKlN8QEnqVhkTOT1c8GXrjSXQkNWF+N1piuSvTQsWAUGKk HvTu2cc2Wx7Ojbl0YvdFm4rbZe//kLH8xwj2Lz5jVCVX6r1cO2qA/W9QlzWksNu04R/P gZmex4NqHOlMUv86na1XxxRRhUpmeFfXbKKp5piJIPDzQND0pe6ueMNT146FxHUHxD4U zjZ1U0YLx+O17UpDcwp5CnZPM2+vtj1gPgmOK1clvdXtsn7ZkFsD7C/w782ZYp5Do1G7 KY5ZuKNNSthgYTZNgHqhOUz2HuldAkx260NzJdlJ9guduSed9fxnNxEVCIvIi9WDqQQq MQxA== X-Gm-Message-State: AOJu0Yw4H4d9ZCa9GNfGU7quf7DmLZF8/zWJUl+Ma71sJ24bCcoD39lV xvHq9HLOKlNR9jbvqBxtEjxLTcA/D2WU+nkfhOk= X-Google-Smtp-Source: AGHT+IETi7BKMBLT2Ig0813xLUYkNqOZF9OhkW8ewzMZRSVuEVfJPEjPx9780NgPaUBmEkdffjANJQ== X-Received: by 2002:a05:6a21:a5a8:b0:194:7371:b2de with SMTP id gd40-20020a056a21a5a800b001947371b2demr4429886pzc.84.1703075327732; Wed, 20 Dec 2023 04:28:47 -0800 (PST) Received: from [192.168.15.31] ([187.34.212.103]) by smtp.gmail.com with ESMTPSA id n20-20020a056a0007d400b006d45707d8edsm7288107pfu.7.2023.12.20.04.28.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Dec 2023 04:28:47 -0800 (PST) Message-ID: Date: Wed, 20 Dec 2023 09:28:44 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Fix elf: Do not duplicate the GLIBC_TUNABLES string Content-Language: en-US To: "H.J. Lu" , libc-alpha@sourceware.org References: <20231220000448.1420614-1-hjl.tools@gmail.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 19/12/23 21:31, H.J. Lu wrote: > On Tue, Dec 19, 2023 at 4:04 PM H.J. Lu wrote: >> >> commit 2a969b53c0b02fed7e43473a92f219d737fd217a >> Author: Adhemerval Zanella >> Date: Wed Dec 6 10:24:01 2023 -0300 >> >> elf: Do not duplicate the GLIBC_TUNABLES string >> >> has >> >> @@ -38,7 +39,7 @@ >> which isn't available. */ >> #define CHECK_GLIBC_IFUNC_PREFERRED_OFF(f, cpu_features, name, len) \ >> _Static_assert (sizeof (#name) - 1 == len, #name " != " #len); \ >> - if (memcmp (f, #name, len) == 0) \ >> + if (tunable_str_comma_strcmp_cte (&f, #name) == 0) \ >> { \ >> cpu_features->preferred[index_arch_##name] \ >> &= ~bit_arch_##name; \ >> @@ -46,12 +47,11 @@ >> >> Fix it by removing "== 0" after tunable_str_comma_strcmp_cte. >> --- >> sysdeps/x86/cpu-tunables.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/sysdeps/x86/cpu-tunables.c b/sysdeps/x86/cpu-tunables.c >> index ef96148d30..142c6b9240 100644 >> --- a/sysdeps/x86/cpu-tunables.c >> +++ b/sysdeps/x86/cpu-tunables.c >> @@ -39,7 +39,7 @@ >> which isn't available. */ >> #define CHECK_GLIBC_IFUNC_PREFERRED_OFF(f, cpu_features, name, len) \ >> _Static_assert (sizeof (#name) - 1 == len, #name " != " #len); \ >> - if (tunable_str_comma_strcmp_cte (&f, #name) == 0) \ >> + if (tunable_str_comma_strcmp_cte (&f, #name)) \ >> { \ >> cpu_features->preferred[index_arch_##name] \ >> &= ~bit_arch_##name; \ >> -- >> 2.43.0 >> > > I am checking it in. > LGTM, thanks.