From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-73140-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 78890 invoked by alias); 8 Sep 2016 10:28:03 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 77943 invoked by uid 89); 8 Sep 2016 10:28:02 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:352
X-HELO: mx1.redhat.com
Subject: Re: [PATCH v2] Add getrandom implementation [BZ #17252]
To: Andreas Schwab <schwab@suse.de>
References: <88371300-c533-9886-f1de-e34f17f7cbb4@redhat.com>
 <5774E713.5000907@pacific.net>
 <700f4f79-2ef1-c34b-2ce9-190e5899fa64@redhat.com>
 <mvmy432em3i.fsf@hawking.suse.de>
Cc: Rical Jasan <ricaljasan@pacific.net>,
        libc-alpha <libc-alpha@sourceware.org>
From: Florian Weimer <fweimer@redhat.com>
Message-ID: <d08e7db5-f223-ac41-c7f7-09554ceba777@redhat.com>
Date: Thu, 08 Sep 2016 10:28:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <mvmy432em3i.fsf@hawking.suse.de>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 8bit
X-SW-Source: 2016-09/txt/msg00116.txt.bz2

On 09/08/2016 12:12 PM, Andreas Schwab wrote:

>> +      if (!((flags & GRND_RANDOM)
>> +            && (flags & GRND_NONBLOCK)
>
> Please add != 0 (no implicit boolean coercion).

The wiki says this is okay (search for “foo & BIT”):

   <https://sourceware.org/glibc/wiki/Style_and_Conventions>

Thanks,
Florian