From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by sourceware.org (Postfix) with ESMTPS id 3F151385C40F for ; Sat, 10 Jul 2021 20:03:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3F151385C40F Received: by mail-pj1-x102a.google.com with SMTP id x21-20020a17090aa395b029016e25313bfcso8082663pjp.2 for ; Sat, 10 Jul 2021 13:03:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=iyJhPV5jdltpc0ecRqvwjZn13Rk6VzmxO6DlQAEte08=; b=VxWuqUaamxbMn7DmFiXNWA4ftd7+l8g25OP1dGOQW80TGBqw/gj0spNNNshd5iy7h/ G1f1gogLJiSV0d1vKdlkP70b0jBj7wAwq2pPBqHyGsjsTXTPGk6mOq1AEyUYjLmMrO1M wARQ7FWfIWD01ff0+hgR7c0JqmpwGxUfjTHwU3Jnb4kOlEYULM11Pbd3UMhq2v6G13qf OFUjEDtfVY69snaFxPSmhKX6MIfS3UobcsVWeo80PFjC535GDmfG1UGvP1fl9lki/qbp b7Ec1MlWawIoAErJxeGQuHtALUIgKLyf72BFKBkBg+xNlPmS2bMN2SVSsZ//lkDo3jeZ 6lfg== X-Gm-Message-State: AOAM531Kh0FEL7j3kF12CJx+f98saE2tnh2Sa9dAlV2cWY/w3FZZicxo bnsNTCi23OB2oTSumJ6qcwS8w6UBcuMdNQ== X-Google-Smtp-Source: ABdhPJwwvOuNxhHJ/PVd85a1d1/VfrEc4hBcaZ6HxqElREYgVNb/2Ljjqx5wIkNUt27+T3X+X783Zg== X-Received: by 2002:a17:90b:688:: with SMTP id m8mr504800pjz.45.1625947404089; Sat, 10 Jul 2021 13:03:24 -0700 (PDT) Received: from [192.168.1.108] ([177.194.59.218]) by smtp.gmail.com with ESMTPSA id v14sm11817783pgo.89.2021.07.10.13.03.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 10 Jul 2021 13:03:23 -0700 (PDT) Subject: Re: [PATCH] Linux: Use 32-bit vDSO for clock_gettime, gettimeofday, time (bug 28071) To: Florian Weimer Cc: libc-alpha@sourceware.org References: <87czrqf5un.fsf@oldenburg.str.redhat.com> <878s2ef19p.fsf@oldenburg.str.redhat.com> <874kd2ey6s.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Message-ID: Date: Sat, 10 Jul 2021 17:03:21 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <874kd2ey6s.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Jul 2021 20:03:27 -0000 On 10/07/2021 17:00, Florian Weimer wrote: > * Adhemerval Zanella: > >> On 10/07/2021 15:54, Florian Weimer wrote: >>> * Adhemerval Zanella: >>> >>>> This does not fix the issue for __ASSUME_TIME64_SYSCALLS where it still uses >>>> INLINE_SYSCALL_CALL which might clobber the errno, besides adding another >>>> ifdef code path (which I really want to avoid). Instead I think we need to >>>> open-coded the INLINE_VSYSCALL macro and replace all INLINE_SYSCALL_CALL >>>> with INTERNAL_SYSCALL_CALLS: >>> >>> But for __ASSUME_TIME64_SYSCALLS, clock_gettime64 will not fail. >>> >>> What am I missing? Is the issue that INLINE_VSYSCALL may set ENOSYS >>> artificially? >> >> I meant for __clock_gettime64, where it may still clobber the errno >> on older kernels (although it might be a fringe case). In any case, >> I still think making all time32 call to call time64 is a better >> implementation than add some specific calls for time32. > > So do you want to send an alternative patch? I can add my tests on top > of that. > Let me prepare one.