From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22659 invoked by alias); 12 Jun 2018 10:17:36 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 22637 invoked by uid 89); 12 Jun 2018 10:17:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,KAM_SHORT,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=company X-HELO: mx1.redhat.com Subject: Re: [PATCH] aarch64: add HXT Phecda core memory operation ifuncs To: Siddhesh Poyarekar , Hongbo Zhang Cc: marcus.shawcroft@arm.com, szabolcs.nagy@arm.com, libc-alpha@sourceware.org References: <1528710363-25909-1-git-send-email-hongbo.zhang@linaro.org> <6a8119c7-d683-59b1-be85-9dfc767f0687@gotplt.org> <85008ec7-5554-4d3b-d0c7-9aa021589379@gotplt.org> <93d90087-1822-a211-80a8-9aa2089d7a67@redhat.com> <1398bad5-2996-d776-3823-0912d5bd7118@gotplt.org> From: Florian Weimer Message-ID: Date: Tue, 12 Jun 2018 10:17:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <1398bad5-2996-d776-3823-0912d5bd7118@gotplt.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2018-06/txt/msg00230.txt.bz2 On 06/12/2018 12:03 PM, Siddhesh Poyarekar wrote: > On 06/12/2018 03:12 PM, Florian Weimer wrote: >> For a company, usually someone who has authorization to negotiate and >> sign contracts has to do this, not individual patch authors. >> >> In this case, I think we can still accept the patch because the number >> of lines changes is small (10 lines), but we'd need it for the next >> patch. > > I am ambivalent about the legal significance since although the number > of lines of the change is small it could be argued as being a > significant feature addition given that it chooses optimal routines for > a specific processor core and implicitly provides information about the > Phecda microarchitecture.  As such, it is borderline newsworthy, > speaking of which, maybe it needs a NEWS entry like so: > >  * Improved string routine performance for the Aarch64 HXT Phecda core. To be clear, I did not comment on the significance of the patch (legal or otherwise). I just repeated the rules used by the FSF used to determine if copyright assignment | A change of just a few lines (less than 15 or so) is not legally | significant for copyright. I think we all agree that the size of the patch has little to do with how much work went into it and how much impact it will have on users. 8-) Thanks, Florian