From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.cs.ucla.edu (mail.cs.ucla.edu [131.179.128.66]) by sourceware.org (Postfix) with ESMTPS id 9F9003858D1E for ; Sat, 8 Apr 2023 22:09:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9F9003858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=cs.ucla.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cs.ucla.edu Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 18A813C09FA05; Sat, 8 Apr 2023 15:09:10 -0700 (PDT) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id V-fA6rGf14n2; Sat, 8 Apr 2023 15:09:09 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 7D2853C09FA06; Sat, 8 Apr 2023 15:09:09 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 7D2853C09FA06 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1680991749; bh=UDdODR9moXsnj4IQuJBHihCjAarTSGO1q2RuHc2HCKI=; h=Message-ID:Date:MIME-Version:To:From; b=aa1oUqeHY8nE8RYV/XKIUSQmX95CQXeMmA8Y2Y3rhakM0w2LoC6sH7MHaj2gKLf3M vsNg4oEb23yXVLqqDlZggyp/0zyycIzEpjdCq7ohixGlDWuDDsIEu1YMQjrwe93evM 8qtel83Wv6iXazpWfF4IUDBAfv6V70QRx4T54L+FChf2a2bZKyZk8/o4uwJmqHc+FB Im5BbTuMM3LC7y9JrRqMAFT37/EA82MfSkIFyUSVVoBF9hCl66LYmDPrqJdCo2Zqfu ftosRyckef1Kgw+xt/9LJtHUzDVwAxsHUbMXs/U7pC+SJnljj1mK9MtaD43BFrTVKW Nv8u0ePEAqO+A== X-Virus-Scanned: amavisd-new at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id C1I9mOyG221V; Sat, 8 Apr 2023 15:09:09 -0700 (PDT) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id 56C243C09FA05; Sat, 8 Apr 2023 15:09:09 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------zPHods7OEw1lh2C73RR5z7PY" Message-ID: Date: Sat, 8 Apr 2023 15:09:09 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Content-Language: en-US To: Florian Weimer References: <6c94849aad1952b50504894b35fa462d445c3a4f.1680693362.git.fweimer@redhat.com> From: Paul Eggert Organization: UCLA Computer Science Department Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 2/2] Add the wcslcpy, wcslcat functions In-Reply-To: <6c94849aad1952b50504894b35fa462d445c3a4f.1680693362.git.fweimer@redhat.com> X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,GIT_PATCH_0,JMQ_SPF_NEUTRAL,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------zPHods7OEw1lh2C73RR5z7PY Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Although I didn't look at the wcslcpy/wcslcat code carefully, it clearly has problems similar to those of the strlcpy/strlcat code and should be fixed the same way. Nobody uses these functions, so their performance does not matter. Certainly we should not try to optimize them. The manual could use a bit of fixup; please see attached. --------------zPHods7OEw1lh2C73RR5z7PY Content-Type: text/x-patch; charset=UTF-8; name="0001-manual-improve-wcslcpy-wcslcat-doc.patch" Content-Disposition: attachment; filename="0001-manual-improve-wcslcpy-wcslcat-doc.patch" Content-Transfer-Encoding: base64 RnJvbSA2MTFmNTNhNTEwNzQzZTc0YWY5YzY5NDI1MWMwNThlNWI3NTA3YjZmIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBTYXQsIDggQXByIDIwMjMgMTM6NTQ6MzcgLTA3MDAKU3ViamVjdDogW1BBVENI XSBtYW51YWw6IGltcHJvdmUgd2NzbGNweS93Y3NsY2F0IGRvYwoKTWVudGlvbiBPcGVuQlNE IHZlcnNpb25zLCBhbmQgbWVudGlvbiB0aGUgbmV3CmZ1bmN0aW9ucyBlbHNld2hlcmUgd2hl biBhcHByb3ByaWF0ZS4KLS0tCiBtYW51YWwvbWFpbnQudGV4aSAgfCAgNCArKysrCiBtYW51 YWwvc3RyaW5nLnRleGkgfCAxMyArKysrKysrLS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDEx IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbWFudWFsL21h aW50LnRleGkgYi9tYW51YWwvbWFpbnQudGV4aQppbmRleCAzYWQ0NjQ3Y2YzLi44OWRhNzA0 ZjQ1IDEwMDY0NAotLS0gYS9tYW51YWwvbWFpbnQudGV4aQorKysgYi9tYW51YWwvbWFpbnQu dGV4aQpAQCAtNDE1LDYgKzQxNSwxMCBAQCBUaGUgZm9sbG93aW5nIGZ1bmN0aW9ucyBhbmQg bWFjcm9zIGFyZSBmb3J0aWZpZWQgaW4gQHRoZWdsaWJje306CiAKIEBpdGVtIEBjb2Rle3dj c2NweX0KIAorQGl0ZW0gQGNvZGV7d2NzbGNhdH0KKworQGl0ZW0gQGNvZGV7d2NzbGNweX0K KwogQGl0ZW0gQGNvZGV7d2NzbmNhdH0KIAogQGl0ZW0gQGNvZGV7d2NzbmNweX0KZGlmZiAt LWdpdCBhL21hbnVhbC9zdHJpbmcudGV4aSBiL21hbnVhbC9zdHJpbmcudGV4aQppbmRleCA3 ODFmYmEyNDVhLi5kMmMzYjZjOTAyIDEwMDY0NAotLS0gYS9tYW51YWwvc3RyaW5nLnRleGkK KysrIGIvbWFudWFsL3N0cmluZy50ZXhpCkBAIC03MjcsNyArNzI3LDggQEAgQXMgbm90ZWQg YmVsb3csIHRoaXMgZnVuY3Rpb24gaGFzIHNpZ25pZmljYW50IHBlcmZvcm1hbmNlIGlzc3Vl cy4KIEBlbmQgZGVmdHlwZWZ1bgogCiBQcm9ncmFtbWVycyB1c2luZyB0aGUgQGNvZGV7c3Ry Y2F0fSBvciBAY29kZXt3Y3NjYXR9IGZ1bmN0aW9ucyAob3IgdGhlCi1AY29kZXtzdHJsY2F0 fSwgQGNvZGV7c3RybmNhdH0gYW5kIEBjb2Rle3djc25jYXR9IGZ1bmN0aW9ucyBkZWZpbmVk IGluCitAY29kZXtzdHJsY2F0fSwgQGNvZGV7c3RybmNhdH0sIEBjb2Rle3djc2xjYXR9Cith bmQgQGNvZGV7d2NzbmNhdH0gZnVuY3Rpb25zIGRlZmluZWQgaW4KIGEgbGF0ZXIgc2VjdGlv biwgZm9yIHRoYXQgbWF0dGVyKQogY2FuIGVhc2lseSBiZSByZWNvZ25pemVkIGFzIGxhenkg YW5kIHJlY2tsZXNzLiAgSW4gYWxtb3N0IGFsbCBzaXR1YXRpb25zCiB0aGUgbGVuZ3RocyBv ZiB0aGUgcGFydGljaXBhdGluZyBzdHJpbmdzIGFyZSBrbm93biAoaXQgYmV0dGVyIHNob3Vs ZCBiZQpAQCAtODQ5LDcgKzg1MCw3IEBAIFdoZW5ldmVyIGEgcHJvZ3JhbW1lciBmZWVscyB0 aGUgbmVlZCB0byB1c2UgQGNvZGV7c3RyY2F0fSBzaGUgb3IgaGUKIHNob3VsZCB0aGluayB0 d2ljZSBhbmQgbG9vayB0aHJvdWdoIHRoZSBwcm9ncmFtIHRvIHNlZSB3aGV0aGVyIHRoZSBj b2RlIGNhbm5vdAogYmUgcmV3cml0dGVuIHRvIHRha2UgYWR2YW50YWdlIG9mIGFscmVhZHkg Y2FsY3VsYXRlZCByZXN1bHRzLgogVGhlIHJlbGF0ZWQgZnVuY3Rpb25zIEBjb2Rle3N0cmxj YXR9LCBAY29kZXtzdHJuY2F0fSwKLUBjb2Rle3djc2NhdH0gYW5kIEBjb2Rle3djc25jYXR9 CitAY29kZXt3Y3NjYXR9LCBAY29kZXt3Y3NsY2F0fSBhbmQgQGNvZGV7d2NzbmNhdH0KIGFy ZSBhbG1vc3QgYWx3YXlzIHVubmVjZXNzYXJ5LCB0b28uCiBBZ2FpbjogaXQgaXMgYWxtb3N0 IGFsd2F5cyB1bm5lY2Vzc2FyeSB0byB1c2UgZnVuY3Rpb25zIGxpa2UgQGNvZGV7c3RyY2F0 fS4KIApAQCAtMTEyMSwxMCArMTEyMiwxMCBAQCBUaGlzIGZ1bmN0aW9uIGlzIGRlcml2ZWQg ZnJvbSBPcGVuQlNEIDIuNC4KIEBzdGFuZGFyZHN7QlNELCBzdHJpbmcuaH0KIEBzYWZldHl7 QHByZWxpbXt9QG10c2FmZXt9QGFzc2FmZXt9QGFjc2FmZXt9fQogVGhpcyBmdW5jdGlvbiBp cyBhIHZhcmlhbnQgb2YgQGNvZGV7c3RybGNweX0gZm9yIHdpZGUgc3RyaW5ncy4KLVRoZSAg QHZhcntzaXplfSBhcmd1bWVudCBjb3VudHMgdGhlIGxlbmd0aCBvZiB0aGUgZGVzdGluYXRp b24gYnVmZmVyIGluCitUaGUgQHZhcntzaXplfSBhcmd1bWVudCBjb3VudHMgdGhlIGxlbmd0 aCBvZiB0aGUgZGVzdGluYXRpb24gYnVmZmVyIGluCiB3aWRlIGNoYXJhY3RlcnMgKGFuZCBu b3QgYnl0ZXMpLgogCi1UaGlzIGZ1bmN0aW9uIGlzIGRlcml2ZWQgZnJvbSBCU0QuCitUaGlz IGZ1bmN0aW9uIGlzIGRlcml2ZWQgZnJvbSBPcGVuQlNEIDMuOC4KIEBlbmQgZGVmdHlwZWZ1 bgogCiBAZGVmdHlwZWZ1biBzaXplX3Qgc3RybGNhdCAoY2hhciAqcmVzdHJpY3QgQHZhcnt0 b30sIGNvbnN0IGNoYXIgKnJlc3RyaWN0IEB2YXJ7ZnJvbX0sIHNpemVfdCBAdmFye3NpemV9 KQpAQCAtMTE2NywxMCArMTE2OCwxMCBAQCBUaGlzIGZ1bmN0aW9uIGlzIGRlcml2ZWQgZnJv bSBPcGVuQlNEIDIuNC4KIEBzdGFuZGFyZHN7QlNELCBzdHJpbmcuaH0KIEBzYWZldHl7QHBy ZWxpbXt9QG10c2FmZXt9QGFzc2FmZXt9QGFjc2FmZXt9fQogVGhpcyBmdW5jdGlvbiBpcyBh IHZhcmlhbnQgb2YgQGNvZGV7c3RybGNhdH0gZm9yIHdpZGUgc3RyaW5ncy4KLVRoZSAgQHZh cntzaXplfSBhcmd1bWVudCBjb3VudHMgdGhlIGxlbmd0aCBvZiB0aGUgZGVzdGluYXRpb24g YnVmZmVyIGluCitUaGUgQHZhcntzaXplfSBhcmd1bWVudCBjb3VudHMgdGhlIGxlbmd0aCBv ZiB0aGUgZGVzdGluYXRpb24gYnVmZmVyIGluCiB3aWRlIGNoYXJhY3RlcnMgKGFuZCBub3Qg Ynl0ZXMpLgogCi1UaGlzIGZ1bmN0aW9uIGlzIGRlcml2ZWQgZnJvbSBCU0QuCitUaGlzIGZ1 bmN0aW9uIGlzIGRlcml2ZWQgZnJvbSBPcGVuQlNEIDMuOC4KIEBlbmQgZGVmdHlwZWZ1bgog CiBCZWNhdXNlIHRoZXNlIGZ1bmN0aW9ucyBjYW4gYWJydXB0bHkgdHJ1bmNhdGUgc3RyaW5n cyBvciB3aWRlIHN0cmluZ3MsCi0tIAoyLjM5LjIKCg== --------------zPHods7OEw1lh2C73RR5z7PY--