From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31003 invoked by alias); 23 Apr 2018 13:28:54 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 30983 invoked by uid 89); 23 Apr 2018 13:28:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS,TIME_LIMIT_EXCEEDED,URIBL_RED autolearn=unavailable version=3.3.2 spammy= X-HELO: mail-qt0-f196.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=kl2yRmfqjyxDI6RygSNt2uNMnNCrHwF5ZR+E8sDW5zU=; b=pbsdK0rI+M2ZfUNQMN+1CVowQEUjKW38HY17veq7d7V7jQDb7tFAPKvrQrOhTilFfj qVHXotxW83fbm5a8HdYS/JWwKK4jcV9pIxOFEeuvL5D0+xNjv07xoQXdBANmvGxSpdlY 3KS5tHua/Fq78sXK17/Lur2ZUDOe+g7GcJkLA/USjdgfgdyMajktEfd4Q16Qzh0GPI7d FHq8ykNxI3a7V8fuwkVUJEjPGJq5+taYGQbo+MRvO746Nv/ZvrBht8de9R0P0QYaRG3j gD3WC5z10BjiLi+MXA2juYfCfaahJ7ymBE2OmAUYIaziAU2WFb9zeRPhznEn+xLqTBI1 xh/A== X-Gm-Message-State: ALQs6tBlOhmc1sFbLOMrql8BBAjGY7HTII/HWygdYDz4gzPS1pExp3F3 NI5dVbOMAENA5rOp55vMpx9QV3URCi0= X-Google-Smtp-Source: AIpwx49mfMFQWs4EjBsOG9bGXXAde4XpavTwPRV0GpTfnyE6tru6RUW7dLCkiofGduY+8al1EJHGqg== X-Received: by 2002:ac8:3a84:: with SMTP id x4-v6mr23258185qte.11.1524490121030; Mon, 23 Apr 2018 06:28:41 -0700 (PDT) Subject: Re: [PATCH] Add tst-sigaction.c to test BZ #23069 To: libc-alpha@sourceware.org References: <20180422111126.22811-1-aurelien@aurel32.net> From: Adhemerval Zanella Openpgp: preference=signencrypt Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= xsFNBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABzUlBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+wsF3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AqzsFNBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABwsFfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Message-ID: Date: Mon, 23 Apr 2018 13:28:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180422111126.22811-1-aurelien@aurel32.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2018-04/txt/msg00473.txt.bz2 On 22/04/2018 08:11, Aurelien Jarno wrote: > This simple test uses sigaction to define a signal handler. It then > uses sigaction again to fetch the information about the same signal > handler, and check that they are consistent. This is enough to detect > mismatches between struct kernel_sigaction and the kernel version of > struct sigaction, like in BZ #23069. > > Changelog: > * signal/tst-sigaction.c: New file to test BZ #23069. > * signal/Makefile (tests): Fix indentation. Add tst-sigaction. LGTM with just one comment below. > --- > ChangeLog | 5 +++++ > signal/Makefile | 2 +- > signal/tst-sigaction.c | 55 ++++++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 61 insertions(+), 1 deletion(-) > create mode 100644 signal/tst-sigaction.c > > diff --git a/ChangeLog b/ChangeLog > index 6b17507d53..31b8bb6e07 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,8 @@ > +2018-04-22 Aurelien Jarno > + > + * signal/tst-sigaction.c: New file to test BZ #23069. > + * signal/Makefile (tests): Fix indentation. Add tst-sigaction. > + > 2018-04-20 Joseph Myers > > * sysdeps/unix/sysv/linux/alpha/bits/termios.h [__USE_MISC] > diff --git a/signal/Makefile b/signal/Makefile > index a9b99a20be..aa63434f47 100644 > --- a/signal/Makefile > +++ b/signal/Makefile > @@ -46,7 +46,7 @@ routines := signal raise killpg \ > sighold sigrelse sigignore sigset > > tests := tst-signal tst-sigset tst-sigsimple tst-raise tst-sigset2 \ > - tst-sigwait-eintr \ > + tst-sigwait-eintr tst-sigaction \ > > include ../Rules > > diff --git a/signal/tst-sigaction.c b/signal/tst-sigaction.c > new file mode 100644 > index 0000000000..d988df1db8 > --- /dev/null > +++ b/signal/tst-sigaction.c > @@ -0,0 +1,55 @@ Need one line file description. > +/* Copyright (C) 2018 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#include > +#include > + > +#include > + > +static void > +my_sig_handler (int signum) > +{ > +} > + > +static int > +do_test (void) > +{ > + /* Define a simple signal handler */ > + struct sigaction act; > + act.sa_handler = my_sig_handler; > + act.sa_flags = 0; > + sigemptyset (&act.sa_mask); > + > + /* Set it as SIGUSR1 signal handler */ > + TEST_VERIFY_EXIT (sigaction (SIGUSR1, &act, NULL) == 0); > + > + /* Get SIGUSR1 signal handler */ > + TEST_VERIFY_EXIT (sigaction (SIGUSR1, NULL, &act) == 0); > + > + /* Check it is consistent with the defined one */ > + TEST_VERIFY (act.sa_handler == my_sig_handler); > + TEST_VERIFY (!(act.sa_flags & SA_RESETHAND)); > + > + for (int i = 1; i < _NSIG; i++) > + { > + TEST_VERIFY (!sigismember (&act.sa_mask, i)); > + } > + > + return 0; > +} > + > +#include >