From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 49BA33857C65 for ; Tue, 18 Jan 2022 18:05:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 49BA33857C65 Received: by mail-ot1-x333.google.com with SMTP id c3-20020a9d6c83000000b00590b9c8819aso25332313otr.6 for ; Tue, 18 Jan 2022 10:05:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Kufi30b2Dm9Nn+OnqnipjsyzCy2IT6Tqvp9JzpieQpQ=; b=4aieCGUZBVmY1+dUZ1XwixBzTIkI+KGv6fnZWe2jhnaLro9Fu49z2aatOcNCnaCSEL Z5YC4ZM+pWni35Q/l1Buga8p6s6PfoePKYfO/hLCtMeZDg9VdderlA9FdWabb8Gp1ZT5 vmq5fBdSy0WoSsABF8Y5tMXyzU8jvKQDGRMVzyhV0I/o/AbBh6/hBJTqYFVcS5Jr/s2Y ZbHrW28yCZ/DHhMisKkFv0WldKg6HItduWBJ5oRUAQzhXYjv4cqwZRrofsrvdWedUc68 0UUFxeH/pWIVIwix3VuXy4MllXaU77VlF20dA9K4+U2EiN8T5y0C9qOLJI30hI3UBXfC IZYg== X-Gm-Message-State: AOAM530s3+Ia+KjNZCnaB07+eTHsLJfIlp2M+VayBgewNg2YzkRu9g8+ PHKJFLM70zW87yT9OrRsqMW6Bg== X-Google-Smtp-Source: ABdhPJx4/MlKIY4UPm5Asr0w/PgGbElZecIDTHQQ7SQEzPANx2uWtfG9eYcVGmWjTg6PtjEjST/Xfw== X-Received: by 2002:a9d:7d9a:: with SMTP id j26mr18877495otn.88.1642529156557; Tue, 18 Jan 2022 10:05:56 -0800 (PST) Received: from ?IPV6:2804:431:c7cb:989a:419b:3fe6:8885:ab23? ([2804:431:c7cb:989a:419b:3fe6:8885:ab23]) by smtp.gmail.com with ESMTPSA id s15sm7272653oiw.37.2022.01.18.10.05.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Jan 2022 10:05:56 -0800 (PST) Message-ID: Date: Tue, 18 Jan 2022 15:05:54 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v7 4/4] elf: Add a test for PT_LOAD segments with invalid p_align [BZ #28688] Content-Language: en-US To: "H.J. Lu" , libc-alpha@sourceware.org Cc: Florian Weimer References: <20220103230433.1907240-1-hjl.tools@gmail.com> <20220103230433.1907240-5-hjl.tools@gmail.com> From: Adhemerval Zanella In-Reply-To: <20220103230433.1907240-5-hjl.tools@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jan 2022 18:05:59 -0000 On 03/01/2022 20:04, H.J. Lu wrote: > Build tst-p_alignmod3.so with 256 byte page size and verify that it is > rejected with a proper error message. > --- > elf/Makefile | 11 +++++++++++ > elf/tst-p_align3.c | 27 +++++++++++++++++++++++++++ > elf/tst-p_align3.sh | 26 ++++++++++++++++++++++++++ > elf/tst-p_alignmod3.c | 22 ++++++++++++++++++++++ > 4 files changed, 86 insertions(+) > create mode 100644 elf/tst-p_align3.c > create mode 100755 elf/tst-p_align3.sh > create mode 100644 elf/tst-p_alignmod3.c > > diff --git a/elf/Makefile b/elf/Makefile > index e4be3fa518..eca730ae8f 100644 > --- a/elf/Makefile > +++ b/elf/Makefile > @@ -409,6 +409,10 @@ tests += \ > tst-p_alignmod2-edit \ > tst-p_align1 \ > tst-p_align2 \ > + tst-p_align3 \ > + > +modules-names += \ > + tst-p_alignmod3 \ > > endif > > @@ -2110,3 +2114,10 @@ $(objpfx)tst-p_alignmod2.so: $(objpfx)tst-p_alignmod2-edit \ > cp $(objpfx)tst-alignmod3.so $@ > $(test-wrapper-env) $(run-program-env) $(rtld-prefix) \ > $(objpfx)tst-p_alignmod2-edit $@ > + > +LDFLAGS-tst-p_alignmod3.so += -Wl,-z,max-page-size=0x100,-z,common-page-size=0x100 > + > +$(objpfx)tst-p_align3: $(objpfx)tst-p_alignmod3.so > +$(objpfx)tst-p_align3.out: tst-p_align3.sh $(objpfx)tst-p_align3 > + $(SHELL) $< $(common-objpfx) '$(test-program-prefix)'; \ > + $(evaluate-test) > diff --git a/elf/tst-p_align3.c b/elf/tst-p_align3.c > new file mode 100644 > index 0000000000..61c616ac3b > --- /dev/null > +++ b/elf/tst-p_align3.c > @@ -0,0 +1,27 @@ > +/* Check invalid p_align of PT_LOAD segments in a shared library. > + Copyright (C) 2021 Free Software Foundation, Inc. Update Copyright years. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +extern int do_load_test (void); As before, do_load_test returns void. > + > +static int > +do_test (void) > +{ > + return do_load_test (); > +} > + > +#include > diff --git a/elf/tst-p_align3.sh b/elf/tst-p_align3.sh > new file mode 100755 > index 0000000000..11572aa217 > --- /dev/null > +++ b/elf/tst-p_align3.sh > @@ -0,0 +1,26 @@ > +#!/bin/sh > +# Check invalid p_align of PT_LOAD segments in a shared library. > +# Copyright (C) 2021 Free Software Foundation, Inc. Update Copyright years. > +# This file is part of the GNU C Library. > + > +# The GNU C Library is free software; you can redistribute it and/or > +# modify it under the terms of the GNU Lesser General Public > +# License as published by the Free Software Foundation; either > +# version 2.1 of the License, or (at your option) any later version. > + > +# The GNU C Library is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > +# Lesser General Public License for more details. > + > +# You should have received a copy of the GNU Lesser General Public > +# License along with the GNU C Library; if not, see > +# . > + > +common_objpfx=$1; shift > +test_program_prefix=$1; shift > + > +${test_program_prefix} \ > + ${common_objpfx}elf/tst-p_align3 \ > + 2> ${common_objpfx}elf/tst-p_align3.out && exit 1 I think we should test for command exit output: test $? -ne 127 && exit 1 > +grep "ELF load command address/offset not page-aligned" ${common_objpfx}elf/tst-p_align3.out > diff --git a/elf/tst-p_alignmod3.c b/elf/tst-p_alignmod3.c > new file mode 100644 > index 0000000000..90f3af467e > --- /dev/null > +++ b/elf/tst-p_alignmod3.c > @@ -0,0 +1,22 @@ > +/* Check invalid p_align of PT_LOAD segment in a shared library. > + Copyright (C) 2021 Free Software Foundation, Inc. Update Copyright years. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +void > +do_load_test (void) > +{ > +}