From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 6264038555A2 for ; Thu, 22 Dec 2022 16:09:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6264038555A2 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671725372; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bkUumE6TNOMqC0+OWAk7vxoLfkpzn5TwCwDv80dAWdI=; b=dpKaZubqf8lNOJ9vxRdpjuNljqFqqL6h3DOjF3hDb/zozDa8ajVKuZTKSYr0U9h95+CPJ0 yf5m6LgucGXe/Eoc27r2h200Nk9tFEpNkJP4V/CvIC/Aej+C4AkA7Ur3IWCnpocme5XOPS lLFAeMbDR298JM2UTXpXjoYp4FtBHAc= Received: from mail-io1-f71.google.com (mail-io1-f71.google.com [209.85.166.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-473-2MIcd0uDMmyL5qLkQiZ9xw-1; Thu, 22 Dec 2022 11:09:30 -0500 X-MC-Unique: 2MIcd0uDMmyL5qLkQiZ9xw-1 Received: by mail-io1-f71.google.com with SMTP id u24-20020a6be918000000b006ed1e9ad302so881028iof.22 for ; Thu, 22 Dec 2022 08:09:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bkUumE6TNOMqC0+OWAk7vxoLfkpzn5TwCwDv80dAWdI=; b=7foGdKkjxgjXLP5XIJ4H7gqG9MD3XDXcRyEdsLxrYgQ4/BAPyYTUEpRnzKelPZHN/q l2PYnRnk5Qd/s1QPBIsce99JpiF70OGD/WxhhcpMeETZzJ8V1rBS5fTviK/FfCCYkRGv 0URQUDcz+Xmf3QGqTYUvADJ2a59ipy0ppUlCJ/PvUSmC2Ku1rGQVzS0bw38ytv0YIc1m Dm765IhAnE3oKtGfC3Vm2aM3lfP0QPLu9qZZlcFoM0Y78OhHHwMALf/8bamN9C6uGe5c U//fj+h0SyB1QsvKiFYNRQKra7sDJ/72RTg/IlAAWI1Bmn7Pt8uGLT0lWkCdo8nloeSg qn3g== X-Gm-Message-State: AFqh2kq5eOTKhtVB+1NDBffPGWvvLQImtSg4ydfm/yQ0bXN0hQhhVBmj UsaJ09jvA2szQZS8bkU0jN8fodrIJHeBqHq7maSw9aZ/eJRgXI5qbmW+TIcu9SrUd4pLRPw3NBN nv2+4wwg7tdx9ufVq3ywu X-Received: by 2002:a5e:c708:0:b0:6bc:d715:362d with SMTP id f8-20020a5ec708000000b006bcd715362dmr3904323iop.2.1671725370167; Thu, 22 Dec 2022 08:09:30 -0800 (PST) X-Google-Smtp-Source: AMrXdXv+K9rFSBKJ2msMiPebU38LQiE6y5SquEvKz4HbM6aSCT3vjXGIJYHduPnBA2s0D6UrxHSykw== X-Received: by 2002:a5e:c708:0:b0:6bc:d715:362d with SMTP id f8-20020a5ec708000000b006bcd715362dmr3904303iop.2.1671725369902; Thu, 22 Dec 2022 08:09:29 -0800 (PST) Received: from [192.168.0.241] (192-0-145-146.cpe.teksavvy.com. [192.0.145.146]) by smtp.gmail.com with ESMTPSA id x7-20020a5d9907000000b006a129b10229sm250535iol.31.2022.12.22.08.09.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Dec 2022 08:09:29 -0800 (PST) Message-ID: Date: Thu, 22 Dec 2022 11:09:28 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] Simplify scripts/cross-test-ssh.sh configuration. To: Florian Weimer Cc: libc-alpha@sourceware.org References: <20221221223601.2258958-1-carlos@redhat.com> <87ili3oqnj.fsf@oldenburg.str.redhat.com> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <87ili3oqnj.fsf@oldenburg.str.redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/22/22 02:15, Florian Weimer wrote: > * Carlos O'Donell: > >> With modern ssh clients and daemons it is required to use AcceptEnv and >> SendEnv configuration options to correctly support testing the DSO sort >> ordering tests. This requirement is present because >> scripts/dso-ordering-test.py injects GLIBC_TUNABLES to the left of the >> ${test_wrapper_env} and so it must both be sent by the ssh client and >> accepted by the ssh daemon. This requirement is removed in this change >> and the injected GLIBC_TUNABLES is placed after ${run_program_env} and >> so still correctly provides the override that the test requires. >> This is similar to existing tests like elf/tst-pathopt.sh, >> elf/tst-rtld-load-self.sh, and locale/tst-locale-locpath.sh. >> >> Tested that it fixes two failures when cross-testing on aarch64 with >> scripts/cross-test-ssh.sh and an ssh client and daemon that do not pass >> GLIBC_TUNABLES. Without this fix such a configuration will report the >> following failures (since the GLIBC_TUNABLES not preserved): >> FAIL: elf/tst-bz15311 >> FAIL: elf/tst-bz28937 > > Nice explanation in the commit message. Looks okay to me. > > Reviewed-by: Florian Weimer Thanks. Pushed. -- Cheers, Carlos.