From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109742 invoked by alias); 22 Jun 2018 21:34:46 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 109727 invoked by uid 89); 22 Jun 2018 21:34:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:1194, H*M:125b X-HELO: mx1.redhat.com Subject: Re: [PATCH] m68k: Reorganize log1p and significand implementations To: Tulio Magno Quites Machado Filho , libc-alpha@sourceware.org Cc: Joseph Myers References: <20180622213326.8533-1-tuliom@linux.ibm.com> From: Jeff Law Openpgp: preference=signencrypt Message-ID: Date: Fri, 22 Jun 2018 21:34:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180622213326.8533-1-tuliom@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-06/txt/msg00713.txt.bz2 On 06/22/2018 03:33 PM, Tulio Magno Quites Machado Filho wrote: > Commit 5e79e0292bfb03f40e43379fd92581ad8eae9cb8 broke m68k after > s_significand.c became available in the build directory. All m68k > implementations of log1p and significand were including s_significand.c > and stopped working after the inclusion of the the auto-generated file. > > This patch reorganizes the implementation of log1p and significand for > m680x0 in order to avoid hitting this problem. > > 2018-06-22 Tulio Magno Quites Machado Filho > > * sysdeps/m68k/m680x0/fpu/s_log1p.c: Set as the generic file for > all log1p and significand functions on m680x0. > * sysdeps/m68k/m680x0/fpu/s_log1pf.c: Include s_log1p.c instead > of s_significand.c.. > * sysdeps/m68k/m680x0/fpu/s_log1pl.c: Likewise. > * sysdeps/m68k/m680x0/fpu/s_significandf.c: Likewise. > * sysdeps/m68k/m680x0/fpu/s_significandl.c: Likewise. > * sysdeps/m68k/m680x0/fpu/s_significand.c: Move all the code to > s_log1p.c and include it.. Thanks. My testers have been complaining about this for a couple days, but I haven't had a chance to investigate. jeff