From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x92e.google.com (mail-ua1-x92e.google.com [IPv6:2607:f8b0:4864:20::92e]) by sourceware.org (Postfix) with ESMTPS id C1DA13858409 for ; Thu, 30 Dec 2021 14:06:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C1DA13858409 Received: by mail-ua1-x92e.google.com with SMTP id az37so21827458uab.12 for ; Thu, 30 Dec 2021 06:06:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=3dZOZ4/3O1AkouuiX3dWOEsyRWmbEE6T/sAN2u/5hMU=; b=gqftykW1+ezoKmklu13i08/kE/6++mlQclUTJXUW4w3I7dwZPNCR+jSJbgW7O2hPc2 M614F+6/2gIWJnooW4GDULx6isssVYS3qZsFRAq00QUGEzn+jsIzAMuaHbYX78Yre3Gb kAnkbLQXoGoJrizrSBzQUKK/wxjRwjncETqDQsK6J3RIkZ/aF9bZAAqgeptTSW6/2XpF bpRFzBEjevL5CWc+U9Ubf4vvjgbM0bVYINvbFQAavw+ileHoQKN/71cH6w/V+nBAx297 BRdCWY1Efqtl2uL2IRH/T0WBE/zc2320g19OdKTCjCRNWYTjVDPXLGJ5tTVDsP1oMMij 24sg== X-Gm-Message-State: AOAM530fLIeOq1V0RBni4X7QOpaR+TMn45w5F+pvhuP2TulqbfFF1QrU N5imjhPsFRfLqnrUYyj9JhYLxVOOqiLlFA== X-Google-Smtp-Source: ABdhPJx4hJ+zXItcSJ7kHcWtsHBNlpjjTwXzOo+WV/X3X4n4JB2Lb9KpBf4QHQZa/2vZG2lXcRfPkg== X-Received: by 2002:a05:6102:3f50:: with SMTP id l16mr9558787vsv.85.1640873193192; Thu, 30 Dec 2021 06:06:33 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:a350:fdac:6660:7407:d883? ([2804:431:c7ca:a350:fdac:6660:7407:d883]) by smtp.gmail.com with ESMTPSA id w138sm1988921vkd.46.2021.12.30.06.06.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Dec 2021 06:06:32 -0800 (PST) Message-ID: Date: Thu, 30 Dec 2021 11:06:31 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH] resolv: Do not build libanl.so for ABIs starting at 2.35 Content-Language: en-US To: Florian Weimer Cc: libc-alpha@sourceware.org References: <20211229163951.3517051-1-adhemerval.zanella@linaro.org> <87czlfb6wk.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella In-Reply-To: <87czlfb6wk.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-14.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Dec 2021 14:06:36 -0000 On 29/12/2021 15:30, Florian Weimer wrote: > * Adhemerval Zanella: > >> --- >> resolv/Makefile | 11 ++++++++++- >> 1 file changed, 10 insertions(+), 1 deletion(-) >> >> diff --git a/resolv/Makefile b/resolv/Makefile >> index 59e599535c..5606eab1fd 100644 >> --- a/resolv/Makefile >> +++ b/resolv/Makefile >> @@ -78,8 +78,12 @@ generate := mtrace-tst-leaks.out tst-leaks.mtrace tst-leaks2.mtrace >> >> extra-libs := libresolv libnss_dns >> ifeq ($(have-thread-library),yes) >> -extra-libs += libanl >> routines += gai_sigqueue >> +endif >> + >> +ifeq ($(have-GLIBC_2.34)$(have-thread-library),yesyes) >> +# Empty compatibility library for old binaries. >> +extra-libs += libanl >> >> tests += \ >> tst-bug18665 \ >> @@ -176,6 +180,11 @@ $(libanl-routines-var) += \ >> libanl-routines += libanl-compat >> libanl-shared-only-routines += libanl-compat >> >> +# Pretend that libanl.so is a linker script, so that the symbolic link >> +# is not installed. >> +install-lib-ldscripts = libanl.so >> +$(inst_libdir)/libanl.so: >> + > > Looks okay. But the second hunk should be in a separate commit; I think > we should backport it. Done.