From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v2] Reinstate ftime and move define it for POSIX.1-2001 or older
Date: Mon, 26 Oct 2020 13:23:42 -0300 [thread overview]
Message-ID: <d2d24c5e-d4ce-ca2f-2a31-7f4c0a9fcd39@linaro.org> (raw)
In-Reply-To: <878sbtarjn.fsf@oldenburg2.str.redhat.com>
On 26/10/2020 13:19, Florian Weimer wrote:
> * Adhemerval Zanella:
>
>> +struct timeb
>> + {
>> + time_t time; /* Seconds since epoch, as from `time'. */
>> + unsigned short int millitm; /* Additional milliseconds. */
>> + short int timezone; /* Minutes west of GMT. */
>> + short int dstflag; /* Nonzero if Daylight Savings Time used. */
>> + };
>
> I think you could add __attribute_deprecated_msg__ on the struct itself.
I tried to add on it, but it would require to add the warning suppression
on ftime.c build before the header inclusion and also on check-local header
tests as well (since it includes). I think adding on the function itself
should suffice, using the struct without calling ftime should be unusual
scenario.
>
> Rest looks okay to me.
>
> Thanks,
> Florian
>
next prev parent reply other threads:[~2020-10-26 16:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 19:13 [PATCH 1/2] " Adhemerval Zanella
2020-10-19 19:13 ` [PATCH 2/2] time: Add 64-bit time_t support for ftime Adhemerval Zanella
2020-10-20 8:18 ` Lukasz Majewski
2020-10-27 17:38 ` Joseph Myers
2020-10-27 17:44 ` Adhemerval Zanella
2020-10-20 8:14 ` [PATCH 1/2] Reinstate ftime and move define it for POSIX.1-2001 or older Lukasz Majewski
2020-10-20 20:33 ` Adhemerval Zanella
2020-10-20 18:04 ` Szabolcs Nagy
2020-10-20 18:20 ` Adhemerval Zanella
2020-10-21 5:17 ` Florian Weimer
2020-10-21 11:03 ` Adhemerval Zanella
2020-10-21 11:05 ` Florian Weimer
2020-10-21 12:35 ` [PATCH v2] " Adhemerval Zanella
2020-10-26 12:17 ` Adhemerval Zanella
2020-10-26 16:03 ` Szabolcs Nagy
2020-10-26 16:13 ` Adhemerval Zanella
2020-10-26 16:19 ` Florian Weimer
2020-10-26 16:23 ` Adhemerval Zanella [this message]
2020-10-26 16:29 ` Florian Weimer
2020-10-26 17:09 ` Adhemerval Zanella
2020-10-28 13:54 ` Florian Weimer
2020-10-28 14:12 ` Zack Weinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2d24c5e-d4ce-ca2f-2a31-7f4c0a9fcd39@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).