From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 687FE385843D for ; Thu, 23 Mar 2023 06:04:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 687FE385843D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32N4Josk017842 for ; Thu, 23 Mar 2023 06:04:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=Ul04jx+HsPXoO7K6TW4vY8bk8mqwFi9+ZOmUjHJot64=; b=VFJvWA5JUbXYI+5/GDnW8k3yax0EHKLuLEsysk/Pa5pAo6POK63ldQbq7zIGHIydv6OY WordsBzzKsXN44kx1mTz1JjeBXI6YH59/oBa3UaQMBXJ3GworXDoUQWxz7aUhPxvRDAN ZVR1DlJHCuJMUJbN/5QzUyvzePrDU77itKuaUUhcX9u6gxNTeVBU5Sj/qJrbkjZYoeFV u+tZzhAB8UtbmDQYzXWaVuSLLldkRdwsQNi0BztiSXg4e6nNuNucySRFCnqHwVB1Dkuz xl8LpPFaUPTJWfbw8AHDDS+RA2bI+EQbnAhlOAh9jcIS/3brS9soF0NYt1j8QlkCLmJh 2w== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3pgfn91xc7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 23 Mar 2023 06:04:51 +0000 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 32N5vBnG000557 for ; Thu, 23 Mar 2023 06:04:51 GMT Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3pgfn91xbs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Mar 2023 06:04:51 +0000 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 32N4H5wb011328; Thu, 23 Mar 2023 06:04:50 GMT Received: from smtprelay06.dal12v.mail.ibm.com ([9.208.130.100]) by ppma03dal.us.ibm.com (PPS) with ESMTPS id 3pd4x7k8ra-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Mar 2023 06:04:50 +0000 Received: from smtpav02.wdc07v.mail.ibm.com (smtpav02.wdc07v.mail.ibm.com [10.39.53.229]) by smtprelay06.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 32N64lWH8585970 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 23 Mar 2023 06:04:47 GMT Received: from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7B9295805C; Thu, 23 Mar 2023 06:04:47 +0000 (GMT) Received: from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 90D075805B; Thu, 23 Mar 2023 06:04:45 +0000 (GMT) Received: from [9.203.96.121] (unknown [9.203.96.121]) by smtpav02.wdc07v.mail.ibm.com (Postfix) with ESMTP; Thu, 23 Mar 2023 06:04:45 +0000 (GMT) Message-ID: Date: Thu, 23 Mar 2023 11:34:43 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2] Skip mcount overflow and tunables tests on "--disable-tunables" To: DJ Delorie Cc: libc-alpha@sourceware.org, rajis@linux.ibm.com, skissane@gmail.com, mahesh.bodapati@ibm.com References: Content-Language: en-US From: MAHESH BODAPATI In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: dMY_VfvBhob6BWiZPvdnPaOT1YMTvI4F X-Proofpoint-GUID: j_D5VOsQ8wA0zAha_5m3akH4nCd74qc1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-22_21,2023-03-22_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 spamscore=0 suspectscore=0 adultscore=0 priorityscore=1501 impostorscore=0 phishscore=0 mlxlogscore=988 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303150002 definitions=main-2303230046 X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 22/03/23 3:18 am, DJ Delorie wrote: > MAHESH BODAPATI writes: >> +have-tunables = @have_tunables@ > config.make.in already has one of these. > > The rest looks OK, but did you test it with tunables disabled vs enabled? Yes,I tested the glibc with tunables enabled vs disabled.have_tunables can't be used in gmon/Makefile so have-tunables variable has been set in config.make.in > >> diff --git a/gmon/Makefile b/gmon/Makefile >> index 213622a7ad..934a2b230d 100644 >> --- a/gmon/Makefile >> +++ b/gmon/Makefile >> @@ -26,7 +26,11 @@ include ../Makeconfig >> headers := sys/gmon.h sys/gmon_out.h sys/profil.h >> routines := gmon mcount profil sprofil prof-freq >> >> -tests = tst-sprofil tst-gmon tst-mcount-overflow tst-mcleanup >> +tests = tst-sprofil tst-gmon tst-mcleanup >> +ifeq ($(have-tunables),yes) >> +tests += tst-mcount-overflow >> +endif >> + >> ifeq ($(build-profile),yes) >> tests += tst-profile-static >> tests-static += tst-profile-static >> @@ -57,6 +61,7 @@ ifeq ($(run-built-tests),yes) >> tests-special += $(objpfx)tst-gmon-gprof.out >> endif >> >> +ifeq ($(have-tunables),yes) >> CFLAGS-tst-mcount-overflow.c := -fno-omit-frame-pointer -pg >> tst-mcount-overflow-no-pie = yes >> CRT-tst-mcount-overflow := $(csu-objpfx)g$(start-installed-name) >> @@ -68,6 +73,7 @@ tst-mcount-overflow-ARGS := 2>&1 1>/dev/null | cat >> ifeq ($(run-built-tests),yes) >> tests-special += $(objpfx)tst-mcount-overflow-check.out >> endif >> +endif >> >> CFLAGS-tst-mcleanup.c := -fno-omit-frame-pointer -pg >> tst-mcleanup-no-pie = yes >> @@ -124,6 +130,7 @@ $(objpfx)tst-gmon.out: clean-tst-gmon-data >> clean-tst-gmon-data: >> rm -f $(objpfx)tst-gmon.data.* >> >> +ifeq ($(have-tunables),yes) >> $(objpfx)tst-mcount-overflow.o: clean-tst-mcount-overflow-data >> clean-tst-mcount-overflow-data: >> rm -f $(objpfx)tst-mcount-overflow.data.* >> @@ -131,6 +138,7 @@ clean-tst-mcount-overflow-data: >> $(objpfx)tst-mcount-overflow-check.out: tst-mcount-overflow-check.sh $(objpfx)tst-mcount-overflow.out >> $(SHELL) $< $(objpfx)tst-mcount-overflow > $@; \ >> $(evaluate-test) >> +endif >> >> $(objpfx)tst-mcleanup.out: clean-tst-mcleanup-data >> clean-tst-mcleanup-data: