From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id 09B083858406 for ; Mon, 24 Jan 2022 13:55:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 09B083858406 Received: by mail-ot1-x331.google.com with SMTP id o9-20020a9d7189000000b0059ee49b4f0fso5213587otj.2 for ; Mon, 24 Jan 2022 05:55:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=IN7Uusq5Ab/5PPa313mWxbwISYSsPNNMjslUal9AZas=; b=zJH7spi+4SfEKcUVXaiyKDRcchf7QJba/8sfgqwEHvBBPnBavYAZPam2TQbqjh+PL1 wCRS1B9FnhCqjut88Ucpoy3BQ0PckXbStGxQpWH/B991gChcJ8t8b1xXxVYpSqYTByJC 77bUTiGAYrcgbJtQp2Wj8S4o8WHwhLznfnbm7vKZP9v/n9GtFWKMaXWralUWCKPYNweu 285hHIYvCjkNILmOvfy5i9M5fYPRIJ0Lb14tRKzDq9z+7bnOVlXx8FWf8svllWcv7jjy ZwQms8umtX84XCWfbhrewze8IlRG1rc8BsZA+r0zjmwNJEGr62G6VSttemr48NMwNfSZ n7rQ== X-Gm-Message-State: AOAM533phQvSwhXPY5XCpneSzTIU2lhdj0UOHzcLAFebHtd9R3ekz6OB By1A/XDWgcM96bPJB0lmRJoqusP8Xw6JTg== X-Google-Smtp-Source: ABdhPJyRUjWqMYk5ScY1MIpTDz4KPZn9YkkjzY50xkJIs8k5XIgCi6/PAS3WMvY/4IjjpxHL1Hnmpw== X-Received: by 2002:a05:6830:2a03:: with SMTP id y3mr11882225otu.360.1643032500446; Mon, 24 Jan 2022 05:55:00 -0800 (PST) Received: from ?IPV6:2804:431:c7cb:27f8:c505:63c0:de61:b716? ([2804:431:c7cb:27f8:c505:63c0:de61:b716]) by smtp.gmail.com with ESMTPSA id h1sm5111902otb.58.2022.01.24.05.54.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jan 2022 05:55:00 -0800 (PST) Message-ID: Date: Mon, 24 Jan 2022 10:54:58 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [OpenRISC] [PATCH v5 00/13] Glibc OpenRISC port Content-Language: en-US To: Florian Weimer , Stafford Horne Cc: Openrisc , GLIBC patches References: <20220104031414.2416928-1-shorne@gmail.com> <87tudt2rpg.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella In-Reply-To: <87tudt2rpg.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Jan 2022 13:55:02 -0000 On 24/01/2022 10:23, Florian Weimer via Libc-alpha wrote: > * Stafford Horne: > >> This is the OpenRISC port for glibc that I have been working on. > > The port does not define PI_STATIC_AND_HIDDEN. Is this really > necessary, or just an oversight due to the way the port was constructed > (presumably with MIPS as the template)? > > PI_STATIC_AND_HIDDEN means that references to static functions and data > and symbols with hidden visibility do not need any run-time relocations > after the final link, with the build flags used by glibc. At least the loader with a simple hello world does not fail with qemu with PI_STATIC_AND_HIDDEN set. Staffork, could you confirm it is ok to make or1k use PI_STATIC_AND_HIDDEN?