From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by sourceware.org (Postfix) with ESMTPS id A6FF53858D33 for ; Tue, 17 Oct 2023 13:43:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A6FF53858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A6FF53858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::634 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697550212; cv=none; b=o+C6GOGrsrNIx8ZpefN6k1F1yBSL88zz9V6IP2lLMjJG6FRz87razajEhsmRxoN2q5WkWHk2KyvdwUBA49IC8PgRqZBpg6qdmJIIDSb3vPFjb3Q8qwEnyPLwoETUDLRW9wdmDQBrAnc1Xr8R508HsIVr3Z7psdeZtLxZa2mGJOE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697550212; c=relaxed/simple; bh=pq9FHlfh5NDWewcVJkO3CVlRBsWBWBLRCDcj2O7hofI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=WhhQit5I4oabpskmlxC5htwx8kroCtJWSm1AVsqZwbb5E06I1bjbBN4cBwdLAOMqAvUGoQzz4Om2p05hMR0Tz7fB1z7c26YInNQXjlVIRzwDITMoYj5otEM70M9CABk0quClpBmdAihncs/PNve/A6jlEYcltgwOX9pOawpfJ98= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-1ca74e77aecso16943815ad.1 for ; Tue, 17 Oct 2023 06:43:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697550209; x=1698155009; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=NX8qWToJxcXkzYH65BfVJUpp+RY2yDZkECim4Fumank=; b=UCunE+lQ7qyxfuQ3lhffuMOUT9dEykL1EudIwlp9CZUvOmcRbZBe3fr2fQEjkWMCJK Aoq7ABu2Lehc8MwF4y/Wdnon7vMzOsVCqFBCxpNw51NM9exsOHHaGBmmQH+VG6B0jo9o OLeYpLnJNOqS7MWrfcMVOhG1XVQVmeo1EVM/620s2z12clyJrdV4fq3L5BzrhGh4pYj/ hTgWg140faEy7SwSQ24+0bGUhzdmvRt1I6A5hlIHvzJV1vZ5qg8kpWv7VVkjPZ362Sz7 bRc8lqhC0XuWPBIAZ2UPx0awHwoqmuB3vriqoQ+efqbTRNd9myLfUD981mpo/1cEb4T5 xAPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697550209; x=1698155009; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NX8qWToJxcXkzYH65BfVJUpp+RY2yDZkECim4Fumank=; b=g5iTJ6Zma19yfU9riKQyo+E5EZcl3KMau9UpSqUsrk7tS/lqombBBFzzlLhtWHhZJa VbvlEeXA35NPSMc4ki5jTdGy9OOm/qC4MhHs5b3KUauB0VJLIYnoqaH1P8a9EnGYul24 BWMyc0EPiJjU+aOQ2fScrGVjYXirjnSpvj3wuxjOAvS99AsHQsHEW6f14h/7zR1Zs3Vs nSYpUQXGcYaNo9fI6puIN73JKBkD127wksjLasAk+HK+hmcOqrmoq8fQj8Ubu2KxzlNk eH7F+aBK+E6THI0mB4c29Vabh3zMORzs2IgDn9pgzVt/vmBGmUG9JJRv3eKb9e5iw2vf 8uSA== X-Gm-Message-State: AOJu0YxxSPKprHP+y3N1tPcbDNxmzdl2IHNqgSHEGx2AefU9rC3faAxL eHpOxeVCY1yzgjQS6IO7hlLrLw== X-Google-Smtp-Source: AGHT+IF5BABcoCn8nX0YV06yCFgbBua9kWqIqU6Yg1BGVIeWunmPEQuS2EvdFzpLZ8MeSwpJhLxdXA== X-Received: by 2002:a17:902:db09:b0:1c6:23fd:fb18 with SMTP id m9-20020a170902db0900b001c623fdfb18mr2931896plx.0.1697550209544; Tue, 17 Oct 2023 06:43:29 -0700 (PDT) Received: from [192.168.15.31] (201-92-183-120.dsl.telesp.net.br. [201.92.183.120]) by smtp.gmail.com with ESMTPSA id bb11-20020a170902bc8b00b001c5d09e9437sm1537932plb.25.2023.10.17.06.43.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Oct 2023 06:43:29 -0700 (PDT) Message-ID: Date: Tue, 17 Oct 2023 10:42:10 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] RISC-V: Enable static-pie. Content-Language: en-US To: "Wang, Yanzhang" , Palmer Dabbelt Cc: DJ Delorie , Darius Rad , "libc-alpha@sourceware.org" References: <1d075708-675d-0ad6-e51c-f911f09ee084@linaro.org> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_ASCII_DIVIDERS,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 21/09/23 10:47, Wang, Yanzhang wrote: > Thanks for all your comments, Palmer, DJ, Dairus and Adhemerval. > Your suggestions are so helpful to me. > > Yes. I also found this issue on GitHub too and the math failures didn't > appear with QEMU system. So it's definitely a hardware bug. > > And I found the root cause of almost of the other failures. It's > because I use sshfs not nfs. :( .. I don't have access to RISCV hardware, but we can use the 2.38 release [1] as the baseline [1]. > > Even though I set a larger TIMEOUTFACTOR as you said, there're still > some timeout failures like below. And seems the timeout is not stable. > Sometimes, nptl/tst-stack4 can pass on lp4a and sometimes not. The tst-stack4 was a long standing issue that should be fixed on master [2]. > > master with qemu-system master on lp4a static-pie patch on lp4a > ----------------------------- ----------------------------- ----------------------------- > resolv/tst-resolv-res_ninit resolv/tst-resolv-res_ninit resolv/tst-resolv-res_ninit > nptl/tst-stack4 nptl/tst-stack4 iconvdata/tst-loading > libio/tst-fopenloc libio/tst-fopenloc localedata/tst-leaks > iconvdata/tst-loading iconvdata/tst-loading malloc/tst-dynarray-fail > localedata/tst-leaks localedata/tst-leaks posix/tst-fnmatch > malloc/tst-dynarray-fail malloc/tst-dynarray-fail > posix/tst-glob-tilde posix/tst-glob-tilde > posix/tst-fnmatch posix/tst-fnmatch For static-pie I would focus on the *static* tests and check for any regressions. On the above, all are dynamic and most likely the timeout you have found are due a low TIMEOUTFACTOR value. You can check by testing each one individually: $ TIMEOUTFACTOR=100 make test t= # for instance, posix/tst-fnmatch > > For the FAIL tests, it's like below. The math failures are filtered out > on lp4a and not appear on qemu-system. > > master with qemu-system master on lp4a static-pie patch on lp4a > ----------------------------------------------- ----------------------------------------------- ----------------------------------------------- > resolv/mtrace-tst-resolv-res_ninit resolv/mtrace-tst-resolv-res_ninit resolv/mtrace-tst-resolv-res_ninit > nptl/tst-cancel21-static libio/tst-fopenloc-mem elf/tst-tls-allocation-failure-static-patched > libio/tst-fopenloc-mem libio/tst-fopenloc-cmp elf/tst-rtld-list-diagnostics > libio/tst-fopenloc-cmp elf/tst-tls-allocation-failure-static-patched elf/tst-sprof-basic > elf/tst-tls-allocation-failure-static-patched elf/tst-rtld-list-diagnostics iconvdata/mtrace-tst-loading > elf/tst-rtld-list-diagnostics elf/tst-sprof-basic localedata/mtrace-tst-leaks > elf/tst-sprof-basic iconvdata/mtrace-tst-loading malloc/tst-dynarray-fail-mem > iconvdata/mtrace-tst-loading localedata/mtrace-tst-leaks posix/tst-fnmatch-mem > localedata/mtrace-tst-leaks malloc/tst-dynarray-fail-mem > malloc/tst-dynarray-fail-mem posix/tst-glob-tilde-mem > posix/tst-glob-tilde-mem posix/tst-fnmatch-mem > posix/tst-fnmatch-mem > posix/globtest The elf/tst-sprof-basic seems to be a know issue based on 2.38 release wiki, and most of them seems also for related to the low TIMEOUTFACTOR. > > Take master on lp4a as an example, > > - elf/tst-rtld-list-diagnostics, due to missing abnf module > - elf/tst-sprof-basic, successfully print hello world but return status is 1, still unknown root cause > - elf/tst-tls-allocation-failure-static-patched, exec format error, still unknown root cause This seems to be a real regression, and I think you should sort this out before the patch is installed (I see no failure on qemu-user on master). The exec format error seems to come from kernel, due the execve failure; and might a corrupted binary. > - the others are memory not freed > > The difference between qemu-system and lp4a for master is the two cases, > > - nptl/tst-cancel21-static, it said sa_flags = SA_ONSTACK and haven't investigated. This might a unrelated issue [3], either in compiler optimization or due the the long-standing BZ#12683 issue. > - posix/globtest, because my qemu-system has a different user name. > > The XFAILs and XPASSes are the same on all platforms and all branches. > So not list here. > > I use the commit 4be913652ca115160bae1daf560170ef8b112ccb of master branch. > > So is this the expected test result? Or is there still any case not correct FAIL or PASS? I think the output look pretty ok, the only issue being the elf/tst-tls-allocation-failure-static failure. [1] https://sourceware.org/glibc/wiki/Release/2.38#RISC-V_.28rv64imac.2Flp64.29 [2] https://sourceware.org/bugzilla/show_bug.cgi?id=19329 [3] https://sourceware.org/pipermail/libc-alpha/2019-September/106641.html