From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-88038-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 80486 invoked by alias); 11 Dec 2017 20:09:21 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 80467 invoked by uid 89); 11 Dec 2017 20:09:20 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mail-qt0-f170.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=BILsi7OyyQzVlkH3XQvsATQDku2tGuj558W4eahHT6E=;
        b=SPO/rp8CObZYjqrFjGohPGfixMOfWD99CHvARt7k8ayDFxsVGlvaPat4IZMvpdwfwm
         YhV8iLrtukhezk0fuKCldQXSsiyE613dMnPBznUt64GUewW3fx3dP1Gq96OgC+TfGmFq
         tWVPo3LGidwprTOo2JTU2ABKDDnsndvAZXojcG/VWQ2Wd2bC2LoavI2G9Qzk5s6F9mwt
         fAE+Qr1HvtTLDu1Nkh7Oeg1RbjGpggXcByJBQ0OIjqX6D5tUx6+hQ29V8dkvGDYGQIC/
         Jkqmnl0Xy7HatOU+7bhTutpt8nZ4iMOWcpDk4GHMsi+K779F8Ix/pHSbOcmS0eQlXPlD
         NpMA==
X-Gm-Message-State: AKGB3mJ0GvufbDXBHLBr9k9IjNARVHskMY8eSroCayyzx2uMraRH343P
	NnsT+jIaQQ1TYiZ2/piCLo/KkQ==
X-Google-Smtp-Source: ACJfBosX/je7POHZ65SM6sgkBXM2uivlg+eGPnwx8slWFtumS+hikZBRFDw9ciKf/kuIVNZQ1tmJ0g==
X-Received: by 10.55.41.36 with SMTP id p36mr2140944qkh.251.1513022956705;
        Mon, 11 Dec 2017 12:09:16 -0800 (PST)
Subject: Re: [PATCHv2] powerpc: POWER8 memcpy optimization for cached memory
To: Tulio Magno Quites Machado Filho <tuliom@linux.vnet.ibm.com>,
 Florian Weimer <fweimer@redhat.com>, libc-alpha@sourceware.org
Cc: Rajalakshmi Srinivasaraghavan <raji@linux.vnet.ibm.com>
References: <87vaik8uxy.fsf@linux.vnet.ibm.com>
 <20171208194020.5005-1-tuliom@linux.vnet.ibm.com>
 <f1c28160-ea24-50ab-eaa8-b75707a31202@redhat.com>
 <87d13l303o.fsf@linux.vnet.ibm.com>
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Message-ID: <d48337bf-a648-15a6-97ca-3cce8e6b56e9@linaro.org>
Date: Mon, 11 Dec 2017 20:09:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <87d13l303o.fsf@linux.vnet.ibm.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2017-12/txt/msg00338.txt.bz2



On 11/12/2017 10:44, Tulio Magno Quites Machado Filho wrote:
> Florian Weimer <fweimer@redhat.com> writes:
> 
>> On 12/08/2017 08:40 PM, Tulio Magno Quites Machado Filho wrote:
>>> +@deftp Tunable glibc.tune.cached_memopt
>>> +The @code{glibc.tune.cached_memopt=[0|1]} tunable allows the user to enable
>>> +optimizations recommended to cacheable memory.
>>> +
>>> +This tunable is specific to powerpc, powerpc64 and powerpc64le.
>>> +@end deftp
>>
>> I think this has a slight grammar problem.
>>
>> What about this instead?
>>
>> The @code{glibc.tune.cached_memopt=[0|1]} tunable allows the user to 
>> enable optimizations recommended for cacheable memory.  If set to 
>> @code{1}, @theglibc{} assumes that the process memory image consists of 
>> cacheable (non-device) memory only.  The default, @code{0}, indicates 
>> that the process may use device memory.
> 
> And a much better description.
> 
>> (I think it's best not to mention string functions here because it is 
>> impossible to describe how glibc.tune.cached_memopt affects them due to 
>> compiler optimizations.)
> 
> Ack.
> 
> Fixed locally.
> 
> Thanks!
> 

Thanks for working on this Tulio, LGTM.