From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) by sourceware.org (Postfix) with ESMTPS id 343453857829 for ; Wed, 17 Mar 2021 21:20:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 343453857829 Received: by mail-qt1-x82a.google.com with SMTP id g24so2553526qts.6 for ; Wed, 17 Mar 2021 14:20:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7eM3Ny4yCLJjaAlPCR1pymn+Lc07yDDXP7LHzy6JTD0=; b=YSQa93+FN42X98Zj1qsetB6Xz4TAlVzP8SGo7DXpFfLGqVr4qVUffXvn7dgy6slZrR 5xPdZEIZe6VmMUCZUYqek3o1tJITMSDJS9QF+S8BCu4rUrOE9QKEkVkQKUPZ1/Z43y6O wvuLJu1Dbki5hHWceJOEMkEUnnhNHHSjwnm/g2nA7Xzo2A/gJaiqNE/sBr5skikwYiTC +QUAEsD8yqyYCYnkOs8SzHBFgqCmYEdp3cbScb3KY/6+sZQEbzv2WdQvh/LeJodg38Af v5ZoQaWkUthpkd/Q/tkOG2a4oloijIFxS5gep60LrQQhwfBRVfMBYrjQsa+Img1zJRjI hyMw== X-Gm-Message-State: AOAM533CwRe1lOU6TVOmrthYEw4wYggF9w4oIeSdnWWYCxwfeFswoOhN sUZDkByDgfDADRvFAEFK1+KKkxVNuULj1jdE X-Google-Smtp-Source: ABdhPJwCWggxOX7C10Vq2egIHwL/tQvUQjeW6iTp4ezdlXVFM/GAfzer7Qho/K7EAGxBU3HNJfKM2g== X-Received: by 2002:ac8:1094:: with SMTP id a20mr994742qtj.248.1616016058608; Wed, 17 Mar 2021 14:20:58 -0700 (PDT) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id m90sm24629qte.44.2021.03.17.14.20.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Mar 2021 14:20:58 -0700 (PDT) Subject: Re: [PATCH] S390: Don't test nanoseconds in io/tst-stat.c To: libc-alpha@sourceware.org References: <20210317130352.1782897-1-stli@linux.ibm.com> From: Adhemerval Zanella Message-ID: Date: Wed, 17 Mar 2021 18:20:56 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Mar 2021 21:21:00 -0000 On 17/03/2021 18:01, Joseph Myers wrote: > On Wed, 17 Mar 2021, Stefan Liebler via Libc-alpha wrote: > >> Both new tests io/tst-stat and io/tst-stat-lfs (_FILE_OFFSET_BITS=64) >> are comparing the nanosecond fields with the statx result. Unfortunately >> on s390(31bit) those fields are always zero if old KABI with non-LFS >> support is used. With _FILE_OFFSET_BITS=64 stat is using statx internally. > > My understanding is that, if using a kernel that supports statx, this > disabling is not needed. The non-LFS stat does not call statx, so the nanoseconds call should be disable only for non-LFS mode. > > If so, we want to be sure to remove this disabling once we can assume a > kernel supporting statx (on s390). The way we ensure that is having a > conditional on __ASSUME_STATX in the code in question so that it's > immediately visible when we remove __ASSUME_STATX that this disabling can > be removed from the glibc source code as well. >