From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 5338D39A0010 for ; Fri, 4 Jun 2021 19:31:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5338D39A0010 Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-298-x9MRVWH9NGWIEGTjzixRaA-1; Fri, 04 Jun 2021 15:31:16 -0400 X-MC-Unique: x9MRVWH9NGWIEGTjzixRaA-1 Received: by mail-qk1-f197.google.com with SMTP id e8-20020a05620a2088b02903a5edeec4d6so7241043qka.11 for ; Fri, 04 Jun 2021 12:31:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=lRBDw4qeugvGzhmlsxakKvkbFdJMaOeglVaaYHBVDuM=; b=OXNqTCEWyDBTnVRDIx+ztM+n34TpyyiDNRvZUC+VUrDuBWFF183T9+w33KTou0TLk6 wzCg3pwX/yVSLPUFPRe2JpmWN29uee48pi5Y1RUbXQS2xV9NrPjNlM8yztbfL5ecpnh2 hMks2hZcZNIIiraEXAVgd/z31cka+bvPezCEAri+LdVoJ5bFD0sCKTMTgdyZfeI2sBX7 3DSd86idCE3w0Sn2QE1AukFbtT/LFRQa7c4SXz/a9+0AH/i7y9rjzZqaAJn9+RYbiguO UJAlADKJj6dwkFI23WHH9ul4R8z/QHFM5WMuO2r2MgJvferzH/HXFz7Rbn5c8f2hYSYM oLUw== X-Gm-Message-State: AOAM530KWej1K5yBMd4x28hNnvuxKXAFrhI0k6jSuvJ0Xdrq7/zsekhA rLXYlryCioE2gWPlMaYVPjlo58JuNxz/0qs8OweXnYrBaMrmHho3SP/Ets6kc8AROaxptXTldrO AL4yjxJ5bkn7F99M/vP0O X-Received: by 2002:a05:620a:a83:: with SMTP id v3mr2276082qkg.360.1622835075693; Fri, 04 Jun 2021 12:31:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwjb0bJRP1nUm0wA8qmxK2sW0SwYEQ/k1RMDD/ko5dSEac21io3veJD1vS0FtsbkrjixraqpQ== X-Received: by 2002:a05:620a:a83:: with SMTP id v3mr2276068qkg.360.1622835075516; Fri, 04 Jun 2021 12:31:15 -0700 (PDT) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id 90sm4250184qtg.9.2021.06.04.12.31.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Jun 2021 12:31:14 -0700 (PDT) From: Carlos O'Donell Subject: Re: [PATCH v2 09/25] y2038: Add __USE_TIME_BITS64 support for struct timeval To: Adhemerval Zanella , libc-alpha@sourceware.org References: <20210518205613.1487824-1-adhemerval.zanella@linaro.org> <20210518205613.1487824-10-adhemerval.zanella@linaro.org> Organization: Red Hat Message-ID: Date: Fri, 4 Jun 2021 15:31:14 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210518205613.1487824-10-adhemerval.zanella@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jun 2021 19:31:19 -0000 On 5/18/21 4:55 PM, Adhemerval Zanella wrote: > The __USE_TIME_BITS64 is not defined internally yet. LGTM. No regressions on x86_64, i686, ppc64le, aarch64, s390x. Reviewed-by: Carlos O'Donell Tested-by: Carlos O'Donell > --- > time/bits/types/struct_timeval.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/time/bits/types/struct_timeval.h b/time/bits/types/struct_timeval.h > index 70394ce886..3466137c35 100644 > --- a/time/bits/types/struct_timeval.h > +++ b/time/bits/types/struct_timeval.h > @@ -7,7 +7,12 @@ > microsecond but also has a range of years. */ > struct timeval > { > +#ifdef __USE_TIME_BITS64 > + __time64_t tv_sec; /* Seconds. */ > + __suseconds64_t tv_usec; /* Microseconds. */ OK. > +#else > __time_t tv_sec; /* Seconds. */ > __suseconds_t tv_usec; /* Microseconds. */ > +#endif > }; > #endif > -- Cheers, Carlos.