From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) by sourceware.org (Postfix) with ESMTPS id 0ADCC385152D for ; Fri, 28 Oct 2022 14:11:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0ADCC385152D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oi1-x22f.google.com with SMTP id s206so6271134oie.3 for ; Fri, 28 Oct 2022 07:11:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kBBsDAkzA5WEjqjwggUpVNQeMahoM+gHGyhpXbpnB0k=; b=ULs+FYSS2bdDXowRDTbyi1qp92bJPpXzqyM4b5D3tyMP+CAamfKJXR2mymu8P9C+vX hCeyQ1ZnquCkkOkoJ9e3XAm851YKjYlVTjjrr4ztScPrHSfhkO9+WzpXK/jsGGLXMDm9 DdszR9LVu6ulGMCwQTqEI839uGAvlLRbzjFjvYNhaieGoouUmf+ofI6R6Kpk1cACZjTs 3NRCZ5JsQIBP1RQnizjyCbDTzHHr7l+U91vR1eoivCm+psFxaI6t1nhr3L7mdMeAkrVd 3GhJ+w31QUh33hKXfxYKzYuMCS17zr8Yg8Q6t6E1pBd9a4th8VIenBtoTE67pQX+0DTF j13Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kBBsDAkzA5WEjqjwggUpVNQeMahoM+gHGyhpXbpnB0k=; b=ZAHInWNLDhyCsbeSeKNit+A1XmXev8GS6KOxslOUrNDnPHN98n0XQ1yUi258b2EGwc SBqx+BTD41IMnzdF8Epcn2Q/Fig/u0ijmOQqGvOwQpXNxYtWfLjPCJmAVhRMesWAZYyw skvihMyz8kk8buc46sjORtMPz4Ip37K51eH5UClOCmtDNRsXvzPHCgDq/nxcOuY0Hg85 3Ukbt8zZlV46Hz06KhRWEALqz/2vQn/eK1l1NvoJ6fpnNKzPL2qq/URKkK05kO2fvvSk u+Fs5vNoc8KJnarLUrsn3GOdGsJqxXF9r+icq269bO5b8XvY8nwDSFDmwP5tBYa02IPj /lKw== X-Gm-Message-State: ACrzQf0Yw7+enSlX9YROWhmr7/VlNlrTe/ebdBmQeSIvWG+JwlR6Xd+C mmeiGPJVZYxTWK5Lxq8SL49cQdV/6Ql2MELz X-Google-Smtp-Source: AMsMyM4eE/BkFNsz9l6jK4Q8/P+6o5KVqOBA3teuL6g+tQ8Uej6HxTdH4gokqF2f0Pkc9643hvtD6Q== X-Received: by 2002:a54:458d:0:b0:359:a896:7581 with SMTP id z13-20020a54458d000000b00359a8967581mr8295568oib.22.1666966277048; Fri, 28 Oct 2022 07:11:17 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c0:17c8:607a:e74b:8f20:5e5b? ([2804:1b3:a7c0:17c8:607a:e74b:8f20:5e5b]) by smtp.gmail.com with ESMTPSA id j126-20020aca3c84000000b0035770fc6ca9sm1550665oia.16.2022.10.28.07.11.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Oct 2022 07:11:16 -0700 (PDT) Message-ID: Date: Fri, 28 Oct 2022 11:11:14 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 13/20] Use uintptr_t in string/tester for pointer alignment Content-Language: en-US To: Szabolcs Nagy , libc-alpha@sourceware.org References: <84fb3b5f7c4c0ea690ac3056fb2a8d97610dd3b4.1666877952.git.szabolcs.nagy@arm.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <84fb3b5f7c4c0ea690ac3056fb2a8d97610dd3b4.1666877952.git.szabolcs.nagy@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 27/10/22 12:33, Szabolcs Nagy via Libc-alpha wrote: > The code assumed unsigned long can represent pointers. LGTM, thanks. Reviewed-by: Adhemerval Zanella > --- > string/tester.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/string/tester.c b/string/tester.c > index eed76239f5..ba948c5723 100644 > --- a/string/tester.c > +++ b/string/tester.c > @@ -27,6 +27,7 @@ > #endif > > #include > +#include > #include > #include > #include > @@ -529,7 +530,7 @@ test_strlen (void) > char *p; > for (i=0; i < 0x100; i++) > { > - p = (char *) ((unsigned long int)(buf + 0xff) & ~0xff) + i; > + p = (char *) ((uintptr_t)(buf + 0xff) & ~0xff) + i; > strcpy (p, "OK"); > strcpy (p+3, "BAD/WRONG"); > check (strlen (p) == 2, 4+i); > @@ -554,7 +555,7 @@ test_strnlen (void) > char buf[4096]; > for (int i = 0; i < 0x100; ++i) > { > - char *p = (char *) ((unsigned long int)(buf + 0xff) & ~0xff) + i; > + char *p = (char *) ((uintptr_t)(buf + 0xff) & ~0xff) + i; > strcpy (p, "OK"); > strcpy (p + 3, "BAD/WRONG"); > check (strnlen (p, 100) == 2, 10 + i); > @@ -582,7 +583,7 @@ test_strchr (void) > char *p; > for (i=0; i < 0x100; i++) > { > - p = (char *) ((unsigned long int) (buf + 0xff) & ~0xff) + i; > + p = (char *) ((uintptr_t) (buf + 0xff) & ~0xff) + i; > strcpy (p, "OK"); > strcpy (p+3, "BAD/WRONG"); > check (strchr (p, '/') == NULL, 9+i); > @@ -614,7 +615,7 @@ test_strchrnul (void) > char *p; > for (i=0; i < 0x100; i++) > { > - p = (char *) ((unsigned long int) (buf + 0xff) & ~0xff) + i; > + p = (char *) ((uintptr_t) (buf + 0xff) & ~0xff) + i; > strcpy (p, "OK"); > strcpy (p+3, "BAD/WRONG"); > cp = strchrnul (p, '/'); > @@ -643,7 +644,7 @@ test_rawmemchr (void) > char *p; > for (i=0; i < 0x100; i++) > { > - p = (char *) ((unsigned long int) (buf + 0xff) & ~0xff) + i; > + p = (char *) ((uintptr_t) (buf + 0xff) & ~0xff) + i; > strcpy (p, "OK"); > strcpy (p+3, "BAD/WRONG"); > check (rawmemchr (p, 'R') == p+8, 6+i); > @@ -689,7 +690,7 @@ test_strrchr (void) > char *p; > for (i=0; i < 0x100; i++) > { > - p = (char *) ((unsigned long int) (buf + 0xff) & ~0xff) + i; > + p = (char *) ((uintptr_t) (buf + 0xff) & ~0xff) + i; > strcpy (p, "OK"); > strcpy (p+3, "BAD/WRONG"); > check (strrchr (p, '/') == NULL, 9+i);