Re: [PATCH] csu: Fix static when PIE is enabled but static PIE is not supported (BZ #29575)

[Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>]

On 06/10/22 15:21, Siddhesh Poyarekar wrote:
> On 2022-10-06 14:09, Adhemerval Zanella Netto wrote:
>>
>>
>> On 05/10/22 16:04, Siddhesh Poyarekar wrote:
>>>
>>>
>>> On 2022-10-05 13:08, Adhemerval Zanella wrote:
>>>> On architectures where static PIE is not supported, both libc and
>>>> static binaries are built still with -fPIE and -DPIC.  It leads to
>>>> wrong code for some architectures (for instance sparc).
>>>>
>>>> This patch only enables -DPIC for .o files iff static-pie is also
>>>> supported.  Since the same rule is used for both libc.a objects and
>>>> installed binaries, the -fno-pie is added if static-pie is not
>>>> supported (with a strategy similar to how stack protector is
>>>> disabled for some architectures).
>>>>
>>>> Checked on x86_64-linux-gnu (with and without --disable-static-pie)
>>>> and I also checked on sparc64-linux-gnu to verify that static binaries
>>>> are not broken and both binaries and tests continue to be built
>>>> for PIE.
>>>> ---
>>>
>>> It should be --disable-default-pie.  Can you please check again and confirm?
>>
>> My mistake, I did use --disable-default-pie (the config.make files on
>> sparc64 build differs for build-pie-default).
> 
> OK then it looks good with the typo fixed.
> 
> Thanks,
> Sid

Sigh... it is not correct if gcc has --enable-default-pie.