From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tom@honermann.net>
Received: from smtp89.iad3a.emailsrvr.com (smtp89.iad3a.emailsrvr.com
 [173.203.187.89])
 by sourceware.org (Postfix) with ESMTPS id 4C4273AAB43B
 for <libc-alpha@sourceware.org>; Fri, 11 Jun 2021 11:25:45 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4C4273AAB43B
X-Auth-ID: tom@honermann.net
Received: by smtp12.relay.iad3a.emailsrvr.com (Authenticated sender:
 tom-AT-honermann.net) with ESMTPSA id E58E124F2D; 
 Fri, 11 Jun 2021 07:25:44 -0400 (EDT)
Subject: Re: [PATCH 3/3]: C++20 P0482R6 and C2X N2653: Tests for mbrtoc8,
 c8rtomb, char8_t
To: Joseph Myers <joseph@codesourcery.com>
Cc: libc-alpha <libc-alpha@sourceware.org>
References: <895dc28e-d2d6-6c6a-1637-f84184e84190@honermann.net>
 <alpine.DEB.2.22.394.2106071933511.207568@digraph.polyomino.org.uk>
From: Tom Honermann <tom@honermann.net>
Message-ID: <d5fdcaa5-9703-016c-9d8c-19c07152f855@honermann.net>
Date: Fri, 11 Jun 2021 07:25:44 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.22.394.2106071933511.207568@digraph.polyomino.org.uk>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
X-Classification-ID: 23e530da-b868-4244-ab0c-1f3dab744a2e-1-1
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE,
 RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Jun 2021 11:25:46 -0000

On 6/7/21 3:35 PM, Joseph Myers wrote:
> New tests should use support/test-driver.c not the older test-skeleton.c
> (see support/README-testing.c) and should preferably use the interfaces in
> support/check.h in place of plain assert.  Very few tests should need to
> define any feature test macros, because they're built with _GNU_SOURCE by
> default.
>
Thank you.  I'll correct and provide an updated patch.

Tom.