From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) by sourceware.org (Postfix) with ESMTPS id 388B23854838 for ; Thu, 17 Jun 2021 13:04:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 388B23854838 Received: by mail-qk1-x732.google.com with SMTP id 5so2987371qkc.8 for ; Thu, 17 Jun 2021 06:04:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8JtRg5Komd2YhJWxSlraL4QAVUdQKHwQT425ChVZ4bc=; b=VNnsMPdB9Wj45ATalc3/bOY7jxuXn+pfyzo2HR49+JTHPFT8k3vtY4fPStIg7ldLQ4 Q875EZfec5DdknVm33MDJXoGWEnDs0hBjOri7x66n+ld2RvYBGlzG1Y5h7eqKSpbqxlk o5/lIXuWMerg/Uuc4r5wMppSoN2QCIK6IGy3HeHubiGepeZtknKQEs8Oly1l+PafdCDM aVlquzfQ4Da2QZBhHFe4uVbvQWjk8VlSoB8IL8zR5vmRrYoCweMu0oHBmpRs797bcxa0 exftcCXsHXfBQBGasmIotRrZ4FF1VubKk1ePsE4DPRPqkjTLHhb8IfVo4HHI+dG/h/HP b3gw== X-Gm-Message-State: AOAM531yjwWTVlBB85Azk4hqo/ypAYxfHQfr1CNlcoVooaaSlTgQtQ94 ARIVS8GDHF/6YOEHxSoEsS8khlktdwwBWw== X-Google-Smtp-Source: ABdhPJz/L57VG7AJcINFasFppUJJZQ9dMZdjSr76y/nfy0Zazosirzm0Hw/wfW9s4DmEAjaDX1UmWQ== X-Received: by 2002:a37:7d83:: with SMTP id y125mr3771046qkc.7.1623935093461; Thu, 17 Jun 2021 06:04:53 -0700 (PDT) Received: from [192.168.1.4] ([177.194.59.218]) by smtp.gmail.com with ESMTPSA id 4sm1667140qkv.134.2021.06.17.06.04.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Jun 2021 06:04:53 -0700 (PDT) Subject: Re: [PATCH] nptl: Use SA_RESTART for SIGCANCEL handler To: Andreas Schwab , Adhemerval Zanella via Libc-alpha References: <20210617125241.1415287-1-adhemerval.zanella@linaro.org> <877dismyma.fsf@igel.home> From: Adhemerval Zanella Message-ID: Date: Thu, 17 Jun 2021 10:04:50 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <877dismyma.fsf@igel.home> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jun 2021 13:04:59 -0000 On 17/06/2021 10:03, Andreas Schwab wrote: > On Jun 17 2021, Adhemerval Zanella via Libc-alpha wrote: > >> diff --git a/nptl/pthread_cancel.c b/nptl/pthread_cancel.c >> index 0698cd2046..cc25ff21f3 100644 >> --- a/nptl/pthread_cancel.c >> +++ b/nptl/pthread_cancel.c >> @@ -72,7 +72,11 @@ __pthread_cancel (pthread_t th) >> { >> struct sigaction sa; >> sa.sa_sigaction = sigcancel_handler; >> - sa.sa_flags = SA_SIGINFO; >> + /* The signal handle should be non-interruptible to avoid the risk of > > The signal handler should be non-interrupting Ack, I fixed it locally.