From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>,
'GNU C Library' <libc-alpha@sourceware.org>
Subject: Re: [PATCH 1/5] benchtests: Add exp10f benchmark
Date: Tue, 14 Apr 2020 09:18:46 -0300 [thread overview]
Message-ID: <d6ac7a52-5b89-f94d-f403-49bb08b36d57@linaro.org> (raw)
In-Reply-To: <DB8PR08MB50366E360127AEED241B7F5583DA0@DB8PR08MB5036.eurprd08.prod.outlook.com>
On 14/04/2020 08:15, Wilco Dijkstra wrote:
> Hi Adhemerval/Paul,
>
>> It is based on converting the expf one and removing the
>> workload-spec2017.wrf line.
>
> I don't see the values converted - to keep the same output range I'd do:
> new_val = (float) log10 (exp ((double)old_val)). Otherwise given the larger
> base I'd expect it to hit huge values and exceptional cases far more often
> than the original trace, making it less relevant.
>
> Also keeping the workload line means we get more accurate benchmark
> results, including throughput and latency.
Ok I will update the patch with this suggestion.
next prev parent reply other threads:[~2020-04-14 12:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 11:15 Wilco Dijkstra
2020-04-14 12:18 ` Adhemerval Zanella [this message]
2020-04-15 8:05 ` paul zimmermann
2020-04-15 8:51 ` Wilco Dijkstra
-- strict thread matches above, loose matches on Subject: below --
2020-06-18 16:17 Wilco Dijkstra
2020-04-09 19:59 Adhemerval Zanella
2020-04-16 20:41 ` Adhemerval Zanella
2020-04-29 17:11 ` Adhemerval Zanella
2020-05-20 20:18 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6ac7a52-5b89-f94d-f403-49bb08b36d57@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=Wilco.Dijkstra@arm.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).