From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) by sourceware.org (Postfix) with ESMTPS id B48B93858433 for ; Wed, 22 Mar 2023 19:11:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B48B93858433 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oi1-x234.google.com with SMTP id bj20so5007005oib.3 for ; Wed, 22 Mar 2023 12:11:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679512273; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EyWpm35S5A00/qfS9pUvbfwJjzOp2cYc6SMEh62JyPQ=; b=EMWJ7wtfP1AzyjcqyI6fsRViSSqqjG8PZB78VeIPh8n8/afR+bJ5Iu9wPV0rFfGCLY mbLOKdImPu0t7RcOMPXRfZvAglfOt6A13XUjsS77B9zdBGvciWA8+KmjWfW/Va5fzu6C KeoGhM56x1hm39TQTv7x4DsiBalu9Z5hdtRW9bLsLKpB3Ynt1b8nei6PJQbIb2Yg6vnb Xydj3nE7N19HMHKHvDeCr5xBFJnlnsxCUcBdYsUxvb45j5RmYYLLlOJXDB0TpsbK+zWP 7NIi4pES6rF8bU5bvwtN9mWDdQ39Qv7trQDXm32nN0VAWYOIdy/96grOXlW1KrP60ZvO VzTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679512273; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EyWpm35S5A00/qfS9pUvbfwJjzOp2cYc6SMEh62JyPQ=; b=N6Qk+72te3qfkJfe1FTtjLVAiwzFtiF/CLoHQj95uuuBK+JolIiu7bE7zlLi50i5IU aEdxaY3uSYjqnK9/XEnKtetvmDAoJlMfIAjM9TUqmTcuEKUuIxc6hDEkV22OWlEIBQaA Olo89LXCdHAmiPP8pmjZepjgGF63SwZ6bfsL5+XOfPLDOk0abWBmBJK4397iudaZzsA5 L6Zjn4EO6zwKOsyyM9HYCBCnsG/g82VLAF7QVwbQB7iy0Mhkb4dd5RQFOgCupAIHrxca szy6dpMCuviN2WCL6PjBs1G5KeDNGmI3zfZcvK9If15yJTm00t2DbmgpKsAKpFn4iFSH 4BCg== X-Gm-Message-State: AO0yUKXHtVa1x2yZ0FBVT7Pr4h2/44jQg96trPJmz9+ru4V0JYIO9/ij ancquht5N9ynQoX63x2HDFHEOg== X-Google-Smtp-Source: AK7set87rMe6JHKps3zBrpicjlr7BYN48wBn8TSZtDca+wx93RHp/has0jMqqrN+ybDFnJe/rXCGsw== X-Received: by 2002:a54:4414:0:b0:364:443a:96c3 with SMTP id k20-20020a544414000000b00364443a96c3mr1785344oiw.22.1679512272938; Wed, 22 Mar 2023 12:11:12 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c0:c260:7930:b4e8:7389:be1f? ([2804:1b3:a7c0:c260:7930:b4e8:7389:be1f]) by smtp.gmail.com with ESMTPSA id s129-20020acadb87000000b0038756901d1esm88105oig.35.2023.03.22.12.11.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Mar 2023 12:11:12 -0700 (PDT) Message-ID: Date: Wed, 22 Mar 2023 16:11:09 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 1/2] elf: Remove glibc.rtld.dynamic_sort tunable Content-Language: en-US To: Siddhesh Poyarekar , libc-alpha@sourceware.org, Florian Weimer References: <20230313190627.2000578-1-adhemerval.zanella@linaro.org> <20230313190627.2000578-2-adhemerval.zanella@linaro.org> <45835a92-55a1-6637-183a-4ecad79d9065@linaro.org> <50f4d048-bdde-fccc-fdd2-edd7b67994ee@gotplt.org> <67b70774-d319-b23d-3d42-b08aa5f10da2@gotplt.org> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <67b70774-d319-b23d-3d42-b08aa5f10da2@gotplt.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 22/03/23 15:52, Siddhesh Poyarekar wrote: > On 2023-03-22 14:46, Adhemerval Zanella Netto wrote: >>> OK, I'll stick to reviewing the --enable-tunables patch then, assuming that it can go in independently of this one.  I feel much less comfortable acking this one since I haven't been closely involved in sorting algorithm selection.  I get the sense that maybe it makes sense to wait a couple more releases before removing the old sort algorithm but that's not based on any specific knowledge, just an instinct. >> >> Well, without tunables the old algorithm can not be selected.  So the second >> part does depend of this. > > I don't get it, wouldn't the old algorithm get selected using the glibc.rtld.dynamic_sort tunable?  How would the ability to disable tunables affect that? > You are right, I got myself confused. >> The old algorithm was kept mainly to provide some fallback compatibility to >> binaries that does not work correctly with newer one; but the default one >> is already in 3 release, it is faster, and so far I have not heard of any >> drawnback. > > It may take 2-3 years for some of the slower moving application devs to get to use the current glibc, hence my spitball about another year or so.  But don't mind my opinion on this, hopefully others can chime in on it.