From: Siddhesh Poyarekar <siddhesh@gotplt.org>
To: Joe Simmons-Talbott <josimmon@redhat.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH] if_index: Remove unneeded alloca.h include
Date: Tue, 25 Apr 2023 10:32:50 -0400 [thread overview]
Message-ID: <d8b3f7cf-bca5-b9a2-5ace-bf1dc3ed1c3c@gotplt.org> (raw)
In-Reply-To: <20230425142654.511300-1-josimmon@redhat.com>
On 2023-04-25 10:26, Joe Simmons-Talbott via Libc-alpha wrote:
> Nothing is being used from this header.
LGTM.
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
> ---
> sysdeps/unix/sysv/linux/if_index.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sysdeps/unix/sysv/linux/if_index.c b/sysdeps/unix/sysv/linux/if_index.c
> index ac22d0b742..432a3f9251 100644
> --- a/sysdeps/unix/sysv/linux/if_index.c
> +++ b/sysdeps/unix/sysv/linux/if_index.c
> @@ -15,7 +15,6 @@
> License along with the GNU C Library; if not, see
> <https://www.gnu.org/licenses/>. */
>
> -#include <alloca.h>
> #include <errno.h>
> #include <string.h>
> #include <stdio.h>
prev parent reply other threads:[~2023-04-25 14:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 14:26 Joe Simmons-Talbott
2023-04-25 14:32 ` Siddhesh Poyarekar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8b3f7cf-bca5-b9a2-5ace-bf1dc3ed1c3c@gotplt.org \
--to=siddhesh@gotplt.org \
--cc=josimmon@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).