From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from forward102c.mail.yandex.net (forward102c.mail.yandex.net [IPv6:2a02:6b8:c03:500:1:45:d181:d102]) by sourceware.org (Postfix) with ESMTPS id 664113858D1E for ; Wed, 29 Mar 2023 15:34:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 664113858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=yandex.ru Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=yandex.ru Received: from mail-nwsmtp-smtp-production-canary-88.sas.yp-c.yandex.net (mail-nwsmtp-smtp-production-canary-88.sas.yp-c.yandex.net [IPv6:2a02:6b8:c14:7296:0:640:126f:0]) by forward102c.mail.yandex.net (Yandex) with ESMTP id D148B600E0; Wed, 29 Mar 2023 18:34:11 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-canary-88.sas.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id 9YK70F4DRa60-DybzN5RI; Wed, 29 Mar 2023 18:34:11 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1680104051; bh=VxOWRTDRfhR+w8obDt3QdJZoXP+yIIZIv1aXCdqgcOs=; h=In-Reply-To:From:Date:References:To:Subject:Message-ID; b=kKFSej3Icd70L/fDjwnv1P0jME0kz+Mqik/RB9HrpnSNEwxzZAxpEJ8fGjXMWeFtQ zWWMrKZNXKGIXlJ/KOuctnYqKPgiUl4K+LBrvewBODPWQgpNO+E5puLWc7lrMRchrp PrSCJGbi2Qb17bjLjacw7OFWwjbT3GDfa/4+nMo0= Authentication-Results: mail-nwsmtp-smtp-production-canary-88.sas.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Message-ID: Date: Wed, 29 Mar 2023 20:34:08 +0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 12/13] dlfcn,elf: implement dlmem() [BZ #11767] Content-Language: en-US To: Carlos O'Donell , Jonathon Anderson , libc-alpha@sourceware.org References: <20230318165110.3672749-1-stsp2@yandex.ru> <20230318165110.3672749-13-stsp2@yandex.ru> <3541bbd7-8a68-2064-bb63-2a921cfe3bb1@yandex.ru> <630fa17528c6050d60f524aa88ad5a057cae1603.camel@rice.edu> <840c2d32-8fd9-39fc-59d7-4552aaa8da39@yandex.ru> <96851dc6-4f32-9c09-7309-b2b106cfc9b4@redhat.com> From: stsp In-Reply-To: <96851dc6-4f32-9c09-7309-b2b106cfc9b4@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: 29.03.2023 20:20, Carlos O'Donell пишет: > It is not a reviewers task to show this to you, it is only their task that > they tell you that it exists. The onus is strongly on the patch submitter to > produce evidence to the contrary. The reviewers on the list here are a scarce > resource, and they offer the experience and technical knowledge to help you. OK, I'll try to demonstrate the contrary, but I am not even sure in what way you want such a demonstration... But lets try: $ LD_LIBRARY_PATH=..:. ./tst-dlmem-fdlopen unaligned buf gives buffer not aligned: Invalid argument 7fb413101000-7fb413102000 r--p 00000000 00:28 17195405 /home/stas/src/glibc-dev/build/dlfcn/glreflib1.so 7fb413102000-7fb413103000 r-xp 00001000 00:28 17195405 /home/stas/src/glibc-dev/build/dlfcn/glreflib1.so 7fb413103000-7fb413104000 r--p 00002000 00:28 17195405 /home/stas/src/glibc-dev/build/dlfcn/glreflib1.so 7fb413104000-7fb413105000 r--p 00002000 00:28 17195405 /home/stas/src/glibc-dev/build/dlfcn/glreflib1.so 7fb413105000-7fb413106000 rw-p 00003000 00:28 17195405 /home/stas/src/glibc-dev/build/dlfcn/glreflib1.so This is the output of my test-case in v9. As you can see, I tried to code up the proof already there. "buffer not aligned" message comes from the test that tries to submit an unaligned buffer, so that's fine. The next lines show you exactly the fact that an elf was laid out per vaddr's. If it wouldn't be the case then /proc/self/maps would just have 1 reference to the .so file, and in that example it does have 5. Is this a proof? If not - what kind of proof do you need?